From: clabbe.montjoie@gmail.com (Corentin Labbe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac
Date: Sun, 20 Aug 2017 08:57:57 +0200 [thread overview]
Message-ID: <20170820065757.GA6081@Red> (raw)
In-Reply-To: <20170819203836.GA21567@lunn.ch>
On Sat, Aug 19, 2017 at 10:38:36PM +0200, Andrew Lunn wrote:
> On Sat, Aug 19, 2017 at 08:50:25PM +0200, Corentin Labbe wrote:
> > On Sat, Aug 19, 2017 at 01:05:21AM +0800, Chen-Yu Tsai wrote:
> > > On Fri, Aug 18, 2017 at 8:21 PM, Corentin Labbe
> > > <clabbe.montjoie@gmail.com> wrote:
> > > > In case of a MDIO switch, the registered MDIO node should be
> > > > the parent of the PHY. Otherwise of_phy_connect will fail.
>
> Hi Corentin
>
> Sorry, I missed this patch series. Looking at patchwork...
That's my fault, I forgot to set you in recipient like in last send.
>
> Can you represent the MDIO mux using
>
> Documentation/devicetree/bindings/net/mdio-mux-mmioreg.txt
>
> It would be better if you could reuse existing infrastructure than
> invent something new.
>
I think we cannot use mdio-mux-mmioreg since the register for doing the switch is in middle of the "System Control" and shared with other functions.
This is why we use a sycon/regmap for selecting the MDIO.
Regards
WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Giuseppe Cavallaro <peppe.cavallaro-qxv4g6HH51o@public.gmane.org>,
Alexandre Torgue <alexandre.torgue-qxv4g6HH51o@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac
Date: Sun, 20 Aug 2017 08:57:57 +0200 [thread overview]
Message-ID: <20170820065757.GA6081@Red> (raw)
In-Reply-To: <20170819203836.GA21567-g2DYL2Zd6BY@public.gmane.org>
On Sat, Aug 19, 2017 at 10:38:36PM +0200, Andrew Lunn wrote:
> On Sat, Aug 19, 2017 at 08:50:25PM +0200, Corentin Labbe wrote:
> > On Sat, Aug 19, 2017 at 01:05:21AM +0800, Chen-Yu Tsai wrote:
> > > On Fri, Aug 18, 2017 at 8:21 PM, Corentin Labbe
> > > <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > > > In case of a MDIO switch, the registered MDIO node should be
> > > > the parent of the PHY. Otherwise of_phy_connect will fail.
>
> Hi Corentin
>
> Sorry, I missed this patch series. Looking at patchwork...
That's my fault, I forgot to set you in recipient like in last send.
>
> Can you represent the MDIO mux using
>
> Documentation/devicetree/bindings/net/mdio-mux-mmioreg.txt
>
> It would be better if you could reuse existing infrastructure than
> invent something new.
>
I think we cannot use mdio-mux-mmioreg since the register for doing the switch is in middle of the "System Control" and shared with other functions.
This is why we use a sycon/regmap for selecting the MDIO.
Regards
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac
Date: Sun, 20 Aug 2017 08:57:57 +0200 [thread overview]
Message-ID: <20170820065757.GA6081@Red> (raw)
In-Reply-To: <20170819203836.GA21567@lunn.ch>
On Sat, Aug 19, 2017 at 10:38:36PM +0200, Andrew Lunn wrote:
> On Sat, Aug 19, 2017 at 08:50:25PM +0200, Corentin Labbe wrote:
> > On Sat, Aug 19, 2017 at 01:05:21AM +0800, Chen-Yu Tsai wrote:
> > > On Fri, Aug 18, 2017 at 8:21 PM, Corentin Labbe
> > > <clabbe.montjoie@gmail.com> wrote:
> > > > In case of a MDIO switch, the registered MDIO node should be
> > > > the parent of the PHY. Otherwise of_phy_connect will fail.
>
> Hi Corentin
>
> Sorry, I missed this patch series. Looking at patchwork...
That's my fault, I forgot to set you in recipient like in last send.
>
> Can you represent the MDIO mux using
>
> Documentation/devicetree/bindings/net/mdio-mux-mmioreg.txt
>
> It would be better if you could reuse existing infrastructure than
> invent something new.
>
I think we cannot use mdio-mux-mmioreg since the register for doing the switch is in middle of the "System Control" and shared with other functions.
This is why we use a sycon/regmap for selecting the MDIO.
Regards
next prev parent reply other threads:[~2017-08-20 6:57 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 12:21 [PATCH v3 0/4] net: stmmac: Detect PHY location with phy-is-integrated Corentin Labbe
2017-08-18 12:21 ` Corentin Labbe
2017-08-18 12:21 ` [PATCH v3 1/4] ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac Corentin Labbe
2017-08-18 12:21 ` Corentin Labbe
2017-08-18 12:21 ` [PATCH v3 2/4] net: stmmac: dwmac-sun8i: choose internal PHY via phy-is-integrated Corentin Labbe
2017-08-18 12:21 ` Corentin Labbe
2017-08-18 16:58 ` Chen-Yu Tsai
2017-08-18 16:58 ` Chen-Yu Tsai
2017-08-22 16:40 ` Florian Fainelli
2017-08-22 16:40 ` Florian Fainelli
2017-08-18 12:21 ` [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac Corentin Labbe
2017-08-18 12:21 ` Corentin Labbe
2017-08-18 17:05 ` Chen-Yu Tsai
2017-08-18 17:05 ` Chen-Yu Tsai
2017-08-19 18:50 ` Corentin Labbe
2017-08-19 18:50 ` Corentin Labbe
2017-08-19 20:38 ` Andrew Lunn
2017-08-19 20:38 ` Andrew Lunn
2017-08-20 6:57 ` Corentin Labbe [this message]
2017-08-20 6:57 ` Corentin Labbe
2017-08-20 6:57 ` Corentin Labbe
2017-08-20 14:25 ` Andrew Lunn
2017-08-20 14:25 ` Andrew Lunn
2017-08-20 14:25 ` Andrew Lunn
2017-08-21 8:10 ` Chen-Yu Tsai
2017-08-21 8:10 ` Chen-Yu Tsai
2017-08-21 13:20 ` Andrew Lunn
2017-08-21 13:20 ` Andrew Lunn
2017-08-21 13:31 ` Maxime Ripard
2017-08-21 13:31 ` Maxime Ripard
2017-08-21 14:23 ` Andrew Lunn
2017-08-21 14:23 ` Andrew Lunn
2017-08-21 14:23 ` Andrew Lunn
2017-08-22 7:59 ` Corentin Labbe
2017-08-22 7:59 ` Corentin Labbe
2017-08-22 15:39 ` Chen-Yu Tsai
2017-08-22 15:39 ` Chen-Yu Tsai
2017-08-22 15:39 ` Chen-Yu Tsai
2017-08-22 16:40 ` Florian Fainelli
2017-08-22 16:40 ` Florian Fainelli
2017-08-22 16:40 ` Florian Fainelli
2017-08-22 18:11 ` Corentin Labbe
2017-08-22 18:11 ` Corentin Labbe
2017-08-22 18:35 ` Florian Fainelli
2017-08-22 18:35 ` Florian Fainelli
2017-08-22 19:37 ` Corentin Labbe
2017-08-22 19:37 ` Corentin Labbe
2017-08-23 7:49 ` Maxime Ripard
2017-08-23 7:49 ` Maxime Ripard
2017-08-23 16:31 ` Florian Fainelli
2017-08-23 16:31 ` Florian Fainelli
2017-08-24 8:12 ` Maxime Ripard
2017-08-24 8:12 ` Maxime Ripard
2017-08-24 8:12 ` Maxime Ripard
2017-08-24 8:21 ` Corentin Labbe
2017-08-24 8:21 ` Corentin Labbe
2017-08-24 19:44 ` Corentin Labbe
2017-08-24 19:44 ` Corentin Labbe
2017-08-24 19:59 ` Florian Fainelli
2017-08-24 19:59 ` Florian Fainelli
2017-08-24 19:59 ` Florian Fainelli
2017-08-25 2:54 ` Chen-Yu Tsai
2017-08-25 2:54 ` Chen-Yu Tsai
2017-08-25 3:05 ` Florian Fainelli
2017-08-25 3:05 ` Florian Fainelli
2017-08-25 3:05 ` Florian Fainelli
2017-08-25 3:41 ` Chen-Yu Tsai
2017-08-25 3:41 ` Chen-Yu Tsai
2017-08-25 3:41 ` Chen-Yu Tsai
2017-08-25 3:59 ` Florian Fainelli
2017-08-25 3:59 ` Florian Fainelli
2017-08-25 13:26 ` Andrew Lunn
2017-08-25 13:26 ` Andrew Lunn
2017-08-22 16:50 ` Maxime Ripard
2017-08-22 16:50 ` Maxime Ripard
2017-08-22 16:50 ` Maxime Ripard
2017-08-18 12:21 ` [PATCH v3 4/4] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY Corentin Labbe
2017-08-18 12:21 ` Corentin Labbe
2017-08-18 16:57 ` Chen-Yu Tsai
2017-08-18 16:57 ` Chen-Yu Tsai
2017-08-19 18:33 ` Corentin Labbe
2017-08-19 18:33 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170820065757.GA6081@Red \
--to=clabbe.montjoie@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.