From: Thierry Reding <thierry.reding@gmail.com>
To: Fabrice Gasnier <fabrice.gasnier@st.com>
Cc: lee.jones@linaro.org, benjamin.gaignard@linaro.org,
jic23@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
alexandre.torgue@st.com, mcoquelin.stm32@gmail.com,
benjamin.gaignard@st.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH v3 4/9] pwm: Add STM32 LPTimer PWM driver
Date: Mon, 21 Aug 2017 09:01:52 +0200 [thread overview]
Message-ID: <20170821070152.GJ18996@ulmo> (raw)
In-Reply-To: <1499445068-7037-5-git-send-email-fabrice.gasnier@st.com>
[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]
On Fri, Jul 07, 2017 at 06:31:03PM +0200, Fabrice Gasnier wrote:
> Add support for single PWM channel on Low-Power Timer, that can be
> found on some STM32 platforms.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
> Changes in v3:
> - remove prescalers[] array, use power-of-2 presc directly
> - Update following Thierry's comments:
> - fix issue using FIELD_GET() macro
> - Add get_state() callback
> - remove some checks in probe
> - slight rework 'reenable' flag
> - use more common method to disable pwm in remove()
>
> Changes in v2:
> - s/Low Power/Low-Power
> - update few comment lines
> ---
> drivers/pwm/Kconfig | 10 ++
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-stm32-lp.c | 246 +++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 257 insertions(+)
> create mode 100644 drivers/pwm/pwm-stm32-lp.c
Sorry, this fell through the cracks: changes in v3 look good to me:
Acked-by: Thierry Reding <thierry.reding@gmail.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Fabrice Gasnier <fabrice.gasnier-qxv4g6HH51o@public.gmane.org>
Cc: lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
alexandre.torgue-qxv4g6HH51o@public.gmane.org,
mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
benjamin.gaignard-qxv4g6HH51o@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 4/9] pwm: Add STM32 LPTimer PWM driver
Date: Mon, 21 Aug 2017 09:01:52 +0200 [thread overview]
Message-ID: <20170821070152.GJ18996@ulmo> (raw)
In-Reply-To: <1499445068-7037-5-git-send-email-fabrice.gasnier-qxv4g6HH51o@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]
On Fri, Jul 07, 2017 at 06:31:03PM +0200, Fabrice Gasnier wrote:
> Add support for single PWM channel on Low-Power Timer, that can be
> found on some STM32 platforms.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier-qxv4g6HH51o@public.gmane.org>
> ---
> Changes in v3:
> - remove prescalers[] array, use power-of-2 presc directly
> - Update following Thierry's comments:
> - fix issue using FIELD_GET() macro
> - Add get_state() callback
> - remove some checks in probe
> - slight rework 'reenable' flag
> - use more common method to disable pwm in remove()
>
> Changes in v2:
> - s/Low Power/Low-Power
> - update few comment lines
> ---
> drivers/pwm/Kconfig | 10 ++
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-stm32-lp.c | 246 +++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 257 insertions(+)
> create mode 100644 drivers/pwm/pwm-stm32-lp.c
Sorry, this fell through the cracks: changes in v3 look good to me:
Acked-by: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/9] pwm: Add STM32 LPTimer PWM driver
Date: Mon, 21 Aug 2017 09:01:52 +0200 [thread overview]
Message-ID: <20170821070152.GJ18996@ulmo> (raw)
In-Reply-To: <1499445068-7037-5-git-send-email-fabrice.gasnier@st.com>
On Fri, Jul 07, 2017 at 06:31:03PM +0200, Fabrice Gasnier wrote:
> Add support for single PWM channel on Low-Power Timer, that can be
> found on some STM32 platforms.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
> Changes in v3:
> - remove prescalers[] array, use power-of-2 presc directly
> - Update following Thierry's comments:
> - fix issue using FIELD_GET() macro
> - Add get_state() callback
> - remove some checks in probe
> - slight rework 'reenable' flag
> - use more common method to disable pwm in remove()
>
> Changes in v2:
> - s/Low Power/Low-Power
> - update few comment lines
> ---
> drivers/pwm/Kconfig | 10 ++
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-stm32-lp.c | 246 +++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 257 insertions(+)
> create mode 100644 drivers/pwm/pwm-stm32-lp.c
Sorry, this fell through the cracks: changes in v3 look good to me:
Acked-by: Thierry Reding <thierry.reding@gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170821/6dbb14ed/attachment.sig>
next prev parent reply other threads:[~2017-08-21 7:01 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 16:30 [PATCH v3 0/9] Add STM32 LPTimer: PWM, trigger and counter Fabrice Gasnier
2017-07-07 16:30 ` Fabrice Gasnier
2017-07-07 16:30 ` Fabrice Gasnier
2017-07-07 16:31 ` [PATCH v3 1/9] dt-bindings: mfd: Add STM32 LPTimer binding Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-10 15:26 ` Rob Herring
2017-07-10 15:26 ` Rob Herring
2017-07-10 15:26 ` Rob Herring
2017-07-17 18:34 ` Lee Jones
2017-07-17 18:34 ` Lee Jones
2017-07-07 16:31 ` [PATCH v3 2/9] mfd: Add STM32 LPTimer driver Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-17 18:33 ` Lee Jones
2017-07-17 18:33 ` Lee Jones
2017-07-07 16:31 ` [PATCH v3 3/9] dt-bindings: pwm: Add STM32 LPTimer PWM binding Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-07 16:31 ` [PATCH v3 4/9] pwm: Add STM32 LPTimer PWM driver Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-26 12:35 ` Fabrice Gasnier
2017-07-26 12:35 ` Fabrice Gasnier
2017-07-26 12:35 ` Fabrice Gasnier
2017-08-21 7:01 ` Thierry Reding [this message]
2017-08-21 7:01 ` Thierry Reding
2017-08-21 7:01 ` Thierry Reding
2017-07-07 16:31 ` [PATCH v3 5/9] dt-bindings: iio: Add STM32 LPTimer trigger binding Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-10 15:27 ` Rob Herring
2017-07-10 15:27 ` Rob Herring
2017-07-10 15:27 ` Rob Herring
2017-07-07 16:31 ` [PATCH v3 6/9] iio: trigger: Add STM32 LPTimer trigger driver Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-09 20:04 ` Jonathan Cameron
2017-07-09 20:04 ` Jonathan Cameron
2017-07-09 20:04 ` Jonathan Cameron
2017-07-07 16:31 ` [PATCH v3 7/9] dt-bindings: iio: Add STM32 LPTimer quadrature encoder and counter Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-07 16:31 ` [PATCH v3 8/9] iio: counter: Add support for STM32 LPTimer Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-09 20:12 ` Jonathan Cameron
2017-07-09 20:12 ` Jonathan Cameron
2017-07-09 20:12 ` Jonathan Cameron
2017-07-09 20:12 ` Jonathan Cameron
2017-07-10 12:54 ` William Breathitt Gray
2017-07-10 12:54 ` William Breathitt Gray
2017-07-10 12:54 ` William Breathitt Gray
2017-07-10 12:54 ` William Breathitt Gray
2017-07-07 16:31 ` [PATCH v3 9/9] iio: adc: stm32: add support for lptimer triggers Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-07 16:31 ` Fabrice Gasnier
2017-07-09 20:13 ` Jonathan Cameron
2017-07-09 20:13 ` Jonathan Cameron
2017-07-09 20:13 ` Jonathan Cameron
2017-08-21 7:24 ` [PATCH v3 0/9] Add STM32 LPTimer: PWM, trigger and counter Lee Jones
2017-08-21 7:24 ` Lee Jones
2017-08-21 7:24 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170821070152.GJ18996@ulmo \
--to=thierry.reding@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@st.com \
--cc=jic23@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.