All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
	linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/5] BTRFS: Fine-tuning for five function implementations
Date: Mon, 21 Aug 2017 13:24:28 +0000	[thread overview]
Message-ID: <20170821132428.GC2866@suse.cz> (raw)
In-Reply-To: <1e8e1da2-a9e3-9dc7-6ffe-6c32f8464337@users.sourceforge.net>

On Mon, Aug 21, 2017 at 02:35:56PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 21 Aug 2017 14:30:12 +0200
> 
> A few update suggestions were taken into account
> from static source code analysis.

All patches make a nice gallery of anti-patterns.  None of them will get
applied.

WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
	linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/5] BTRFS: Fine-tuning for five function implementations
Date: Mon, 21 Aug 2017 15:24:28 +0200	[thread overview]
Message-ID: <20170821132428.GC2866@suse.cz> (raw)
In-Reply-To: <1e8e1da2-a9e3-9dc7-6ffe-6c32f8464337@users.sourceforge.net>

On Mon, Aug 21, 2017 at 02:35:56PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 21 Aug 2017 14:30:12 +0200
> 
> A few update suggestions were taken into account
> from static source code analysis.

All patches make a nice gallery of anti-patterns.  None of them will get
applied.

  parent reply	other threads:[~2017-08-21 13:24 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-21 12:35 [PATCH 0/5] BTRFS: Fine-tuning for five function implementations SF Markus Elfring
2017-08-21 12:35 ` SF Markus Elfring
2017-08-21 12:37 ` [PATCH 1/5] btrfs: Use common error handling code in tree_mod_log_eb_copy() SF Markus Elfring
2017-08-21 12:37   ` SF Markus Elfring
2017-08-21 12:38 ` [PATCH 2/5] btrfs: Use common error handling code in __btrfs_free_extent() SF Markus Elfring
2017-08-21 12:38   ` SF Markus Elfring
2017-08-21 13:07   ` Jeff Mahoney
2017-08-21 13:07     ` Jeff Mahoney
2017-08-21 13:14     ` Dan Carpenter
2017-08-21 13:14       ` Dan Carpenter
2017-08-21 12:40 ` [PATCH 3/5] btrfs: Use common error handling code in btrfs_update_root() SF Markus Elfring
2017-08-21 12:40   ` SF Markus Elfring
2017-08-21 13:09   ` Jeff Mahoney
2017-08-21 13:09     ` Jeff Mahoney
2017-08-21 12:41 ` [PATCH 4/5] btrfs: Use common error handling code in update_ref_path() SF Markus Elfring
2017-08-21 12:41   ` SF Markus Elfring
2017-08-21 13:08   ` Jeff Mahoney
2017-08-21 13:08     ` Jeff Mahoney
2017-08-21 13:42     ` Dan Carpenter
2017-08-21 13:42       ` Dan Carpenter
2017-08-21 13:52       ` [PATCH v2] " SF Markus Elfring
2017-08-21 13:52         ` SF Markus Elfring
2017-08-21 12:42 ` [PATCH 5/5] btrfs: Use common error handling code in btrfs_mark_extent_written() SF Markus Elfring
2017-08-21 12:42   ` SF Markus Elfring
2017-08-21 13:07   ` Jeff Mahoney
2017-08-21 13:07     ` Jeff Mahoney
2017-08-21 13:24 ` David Sterba [this message]
2017-08-21 13:24   ` [PATCH 0/5] BTRFS: Fine-tuning for five function implementations David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170821132428.GC2866@suse.cz \
    --to=dsterba@suse.cz \
    --cc=clm@fb.com \
    --cc=elfring@users.sourceforge.net \
    --cc=jbacik@fb.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.