From: Christoph Hellwig <hch@lst.de>
To: David Miller <davem@davemloft.net>
Cc: hch@lst.de, mroos@linux.ee, helgaas@kernel.org,
sparclinux@vger.kernel.org, linux-pci@vger.kernel.org,
qla2xxx-upstream@qlogic.com, linux-kernel@vger.kernel.org
Subject: Re: 4.13.0-rc4 sparc64: can't allocate MSI-X affinity masks for 2 vectors
Date: Tue, 22 Aug 2017 18:39:16 +0200 [thread overview]
Message-ID: <20170822163916.GA31671@lst.de> (raw)
In-Reply-To: <20170822.093139.473720171751670244.davem@davemloft.net>
On Tue, Aug 22, 2017 at 09:31:39AM -0700, David Miller wrote:
> > I fear my commit message (but not the code) might be wrong.
> > irq_create_affinity_masks can return NULL any time we don't have any
> > affinity masks. I've already had a discussion about this elsewhere
> > with Bjorn, and I suspect we need to kill the warning or move it
> > to irq_create_affinity_masks only for genuine failure cases.
>
> This is a rather large machine with 64 or more cpus and several NUMA
> nodes. Why wouldn't there be any affinity masks available?
The drivers only asked for two MSI-X vectors, and marked bost of them
as pre-vectors that should not be spread. So there is no actual
vector left that we want to actually spread.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: David Miller <davem@davemloft.net>
Cc: hch@lst.de, mroos@linux.ee, helgaas@kernel.org,
sparclinux@vger.kernel.org, linux-pci@vger.kernel.org,
qla2xxx-upstream@qlogic.com, linux-kernel@vger.kernel.org
Subject: Re: 4.13.0-rc4 sparc64: can't allocate MSI-X affinity masks for 2 vectors
Date: Tue, 22 Aug 2017 16:39:16 +0000 [thread overview]
Message-ID: <20170822163916.GA31671@lst.de> (raw)
In-Reply-To: <20170822.093139.473720171751670244.davem@davemloft.net>
On Tue, Aug 22, 2017 at 09:31:39AM -0700, David Miller wrote:
> > I fear my commit message (but not the code) might be wrong.
> > irq_create_affinity_masks can return NULL any time we don't have any
> > affinity masks. I've already had a discussion about this elsewhere
> > with Bjorn, and I suspect we need to kill the warning or move it
> > to irq_create_affinity_masks only for genuine failure cases.
>
> This is a rather large machine with 64 or more cpus and several NUMA
> nodes. Why wouldn't there be any affinity masks available?
The drivers only asked for two MSI-X vectors, and marked bost of them
as pre-vectors that should not be spread. So there is no actual
vector left that we want to actually spread.
next prev parent reply other threads:[~2017-08-22 16:39 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 14:54 4.13.0-rc4 sparc64: can't allocate MSI-X affinity masks for 2 vectors Meelis Roos
2017-08-15 14:54 ` Meelis Roos
2017-08-15 18:44 ` Bjorn Helgaas
2017-08-15 18:44 ` Bjorn Helgaas
2017-08-15 20:24 ` Meelis Roos
2017-08-15 20:24 ` Meelis Roos
2017-08-16 18:39 ` Meelis Roos
2017-08-16 18:39 ` Meelis Roos
2017-08-16 19:02 ` Bjorn Helgaas
2017-08-16 19:02 ` Bjorn Helgaas
2017-08-17 14:47 ` Meelis Roos
2017-08-17 14:47 ` Meelis Roos
2017-08-21 18:27 ` David Miller
2017-08-21 18:27 ` David Miller
2017-08-21 18:34 ` Christoph Hellwig
2017-08-21 18:34 ` Christoph Hellwig
2017-08-21 19:20 ` mroos
2017-08-21 19:20 ` mroos
2017-08-21 20:35 ` David Miller
2017-08-21 20:35 ` David Miller
2017-08-22 5:02 ` Meelis Roos
2017-08-22 5:02 ` Meelis Roos
2017-08-22 6:35 ` Christoph Hellwig
2017-08-22 6:35 ` Christoph Hellwig
2017-08-22 16:31 ` David Miller
2017-08-22 16:31 ` David Miller
2017-08-22 16:33 ` Meelis Roos
2017-08-22 16:33 ` Meelis Roos
2017-08-22 16:45 ` David Miller
2017-08-22 16:45 ` David Miller
2017-08-22 16:39 ` Christoph Hellwig [this message]
2017-08-22 16:39 ` Christoph Hellwig
2017-08-22 16:52 ` David Miller
2017-08-22 16:52 ` David Miller
2017-08-17 10:09 ` Christoph Hellwig
2017-08-17 10:09 ` Christoph Hellwig
2017-08-17 10:17 ` Meelis Roos
2017-08-17 10:17 ` Meelis Roos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170822163916.GA31671@lst.de \
--to=hch@lst.de \
--cc=davem@davemloft.net \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=qla2xxx-upstream@qlogic.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.