All of lore.kernel.org
 help / color / mirror / Atom feed
From: antoine.tenart@free-electrons.com (Antoine Tenart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next v2 10/10] arm64: dts: marvell: mcbin: enable more networking ports
Date: Wed, 23 Aug 2017 10:11:12 +0200	[thread overview]
Message-ID: <20170823081112.GC5202@kwain> (raw)
In-Reply-To: <20170823072842.ibk6gqtswhamvppy@sapphire.tkos.co.il>

Hi Baruch,

On Wed, Aug 23, 2017 at 10:28:42AM +0300, Baruch Siach wrote:
> On Tue, Aug 22, 2017 at 07:08:30PM +0200, Antoine Tenart wrote:
> > This patch enables the two GE/SFP ports. They are configured in 10GKR
> > mode by default. To do this the cpm_xdmio is enabled as well, and two
> > phy descriptions are added.
> > 
> > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> > Tested-by: Marcin Wojtas <mw@semihalf.com>
> > ---
> >  arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 30 +++++++++++++++++++++++
> >  1 file changed, 30 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> > index abd39d1c1739..6cb4b000e1ac 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> > +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> > @@ -127,6 +127,30 @@
> >  	};
> >  };
> >  
> > +&cpm_xmdio {
> > +	status = "okay";
> > +
> > +	phy0: ethernet-phy at 0 {
> > +		compatible = "ethernet-phy-ieee802.3-c45";
> > +		reg = <0>;
> > +	};
> > +
> > +	phy1: ethernet-phy at 1 {
> 
> Should be named 'ethernet-phy at 8' to match the 'reg' property.

That's right.

Thanks!
Antoine

-- 
Antoine T?nart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170823/a5c64539/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>,
	davem@davemloft.net, jason@lakedaemon.net, andrew@lunn.ch,
	gregory.clement@free-electrons.com,
	sebastian.hesselbarth@gmail.com,
	thomas.petazzoni@free-electrons.com, netdev@vger.kernel.org,
	linux@armlinux.org.uk, nadavh@marvell.com, stefanc@marvell.com,
	mw@semihalf.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v2 10/10] arm64: dts: marvell: mcbin: enable more networking ports
Date: Wed, 23 Aug 2017 10:11:12 +0200	[thread overview]
Message-ID: <20170823081112.GC5202@kwain> (raw)
In-Reply-To: <20170823072842.ibk6gqtswhamvppy@sapphire.tkos.co.il>

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]

Hi Baruch,

On Wed, Aug 23, 2017 at 10:28:42AM +0300, Baruch Siach wrote:
> On Tue, Aug 22, 2017 at 07:08:30PM +0200, Antoine Tenart wrote:
> > This patch enables the two GE/SFP ports. They are configured in 10GKR
> > mode by default. To do this the cpm_xdmio is enabled as well, and two
> > phy descriptions are added.
> > 
> > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> > Tested-by: Marcin Wojtas <mw@semihalf.com>
> > ---
> >  arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 30 +++++++++++++++++++++++
> >  1 file changed, 30 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> > index abd39d1c1739..6cb4b000e1ac 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> > +++ b/arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts
> > @@ -127,6 +127,30 @@
> >  	};
> >  };
> >  
> > +&cpm_xmdio {
> > +	status = "okay";
> > +
> > +	phy0: ethernet-phy@0 {
> > +		compatible = "ethernet-phy-ieee802.3-c45";
> > +		reg = <0>;
> > +	};
> > +
> > +	phy1: ethernet-phy@1 {
> 
> Should be named 'ethernet-phy@8' to match the 'reg' property.

That's right.

Thanks!
Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-08-23  8:11 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-22 17:08 [PATCH net-next v2 00/10] net: mvpp2: MAC/GoP configuration Antoine Tenart
2017-08-22 17:08 ` Antoine Tenart
2017-08-22 17:08 ` [PATCH net-next v2 01/10] net: mvpp2: unify register definitions coding style Antoine Tenart
2017-08-22 17:08   ` Antoine Tenart
2017-08-22 17:08 ` [PATCH net-next v2 02/10] net: mvpp2: fix the synchronization module bypass macro name Antoine Tenart
2017-08-22 17:08   ` Antoine Tenart
2017-08-22 17:08 ` [PATCH net-next v2 03/10] net: mvpp2: move the mii configuration in the ndo_open path Antoine Tenart
2017-08-22 17:08   ` Antoine Tenart
2017-08-22 17:08 ` [PATCH net-next v2 04/10] net: mvpp2: initialize the GMAC when using a port Antoine Tenart
2017-08-22 17:08   ` Antoine Tenart
2017-08-22 17:08 ` [PATCH net-next v2 05/10] net: mvpp2: initialize the XLG MAC " Antoine Tenart
2017-08-22 17:08   ` Antoine Tenart
2017-08-22 17:08 ` [PATCH net-next v2 06/10] net: mvpp2: set maximum packet size for 10G ports Antoine Tenart
2017-08-22 17:08   ` Antoine Tenart
2017-08-22 17:08 ` [PATCH net-next v2 07/10] net: mvpp2: initialize the GoP Antoine Tenart
2017-08-22 17:08   ` Antoine Tenart
2017-08-22 17:08 ` [PATCH net-next v2 08/10] Documentation/bindings: net: marvell-pp2: add the system controller Antoine Tenart
2017-08-22 17:08   ` Antoine Tenart
2017-08-22 17:08 ` [PATCH net-next v2 09/10] arm64: dts: marvell: add a reference to the sysctrl syscon in the ppv2 node Antoine Tenart
2017-08-22 17:08   ` Antoine Tenart
2017-08-22 17:08 ` [PATCH net-next v2 10/10] arm64: dts: marvell: mcbin: enable more networking ports Antoine Tenart
2017-08-22 17:08   ` Antoine Tenart
2017-08-23  7:28   ` Baruch Siach
2017-08-23  7:28     ` Baruch Siach
2017-08-23  8:11     ` Antoine Tenart [this message]
2017-08-23  8:11       ` Antoine Tenart
2017-08-22 18:07 ` [PATCH net-next v2 00/10] net: mvpp2: MAC/GoP configuration Andrew Lunn
2017-08-22 18:07   ` Andrew Lunn
2017-08-22 18:38   ` Antoine Tenart
2017-08-22 18:38     ` Antoine Tenart
2017-08-22 21:32 ` David Miller
2017-08-22 21:32   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170823081112.GC5202@kwain \
    --to=antoine.tenart@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.