* [PATCH v3 1/4] loop: fix hang if LOOP_SET_STATUS gets invalid blocksize or encrypt type
2017-08-22 17:32 [PATCH v3 0/4] loop: LO_FLAGS_BLOCKSIZE fixes Omar Sandoval
@ 2017-08-22 17:32 ` Omar Sandoval
2017-08-22 17:32 ` [PATCH v3 2/4] loop: set discard and write zeroes limits in 512 byte sectors Omar Sandoval
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Omar Sandoval @ 2017-08-22 17:32 UTC (permalink / raw)
To: linux-block; +Cc: kernel-team, Hannes Reinecke, Ming Lei, Karel Zak, Milan Broz
From: Omar Sandoval <osandov@fb.com>
In both of these error cases, we need to make sure to unfreeze the queue
before we return.
Fixes: ecdd09597a57 ("block/loop: fix race between I/O and set_status")
Fixes: f2c6df7dbf9a ("loop: support 4k physical blocksize")
Tested-by: Milan Broz <gmazyland@gmail.com>
Reviewed-by: Milan Broz <gmazyland@gmail.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Omar Sandoval <osandov@fb.com>
---
drivers/block/loop.c | 24 ++++++++++++++++--------
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index ef8334949b42..26548e07bc31 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1125,11 +1125,15 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
if (info->lo_encrypt_type) {
unsigned int type = info->lo_encrypt_type;
- if (type >= MAX_LO_CRYPT)
- return -EINVAL;
+ if (type >= MAX_LO_CRYPT) {
+ err = -EINVAL;
+ goto exit;
+ }
xfer = xfer_funcs[type];
- if (xfer == NULL)
- return -EINVAL;
+ if (xfer == NULL) {
+ err = -EINVAL;
+ goto exit;
+ }
} else
xfer = NULL;
@@ -1144,10 +1148,14 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
if (LO_INFO_BLOCKSIZE(info) != 512 &&
LO_INFO_BLOCKSIZE(info) != 1024 &&
LO_INFO_BLOCKSIZE(info) != 2048 &&
- LO_INFO_BLOCKSIZE(info) != 4096)
- return -EINVAL;
- if (LO_INFO_BLOCKSIZE(info) > lo->lo_blocksize)
- return -EINVAL;
+ LO_INFO_BLOCKSIZE(info) != 4096) {
+ err = -EINVAL;
+ goto exit;
+ }
+ if (LO_INFO_BLOCKSIZE(info) > lo->lo_blocksize) {
+ err = -EINVAL;
+ goto exit;
+ }
}
if (lo->lo_offset != info->lo_offset ||
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v3 2/4] loop: set discard and write zeroes limits in 512 byte sectors
2017-08-22 17:32 [PATCH v3 0/4] loop: LO_FLAGS_BLOCKSIZE fixes Omar Sandoval
2017-08-22 17:32 ` [PATCH v3 1/4] loop: fix hang if LOOP_SET_STATUS gets invalid blocksize or encrypt type Omar Sandoval
@ 2017-08-22 17:32 ` Omar Sandoval
2017-08-23 6:19 ` Hannes Reinecke
2017-08-22 17:33 ` [PATCH v3 3/4] loop: use queue limit instead of private lo_logical_blocksize Omar Sandoval
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Omar Sandoval @ 2017-08-22 17:32 UTC (permalink / raw)
To: linux-block; +Cc: kernel-team, Hannes Reinecke, Ming Lei, Karel Zak, Milan Broz
From: Omar Sandoval <osandov@fb.com>
max_discard_sectors and max_write_zeroes_sectors are in 512 byte
sectors, not device sectors.
Fixes: f2c6df7dbf9a ("loop: support 4k physical blocksize")
Signed-off-by: Omar Sandoval <osandov@fb.com>
---
drivers/block/loop.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 26548e07bc31..a444dc2d5977 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -820,7 +820,6 @@ static void loop_config_discard(struct loop_device *lo)
struct file *file = lo->lo_backing_file;
struct inode *inode = file->f_mapping->host;
struct request_queue *q = lo->lo_queue;
- int lo_bits = 9;
/*
* We use punch hole to reclaim the free space used by the
@@ -840,11 +839,8 @@ static void loop_config_discard(struct loop_device *lo)
q->limits.discard_granularity = inode->i_sb->s_blocksize;
q->limits.discard_alignment = 0;
- if (lo->lo_flags & LO_FLAGS_BLOCKSIZE)
- lo_bits = blksize_bits(lo->lo_logical_blocksize);
-
- blk_queue_max_discard_sectors(q, UINT_MAX >> lo_bits);
- blk_queue_max_write_zeroes_sectors(q, UINT_MAX >> lo_bits);
+ blk_queue_max_discard_sectors(q, UINT_MAX >> 9);
+ blk_queue_max_write_zeroes_sectors(q, UINT_MAX >> 9);
queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, q);
}
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v3 2/4] loop: set discard and write zeroes limits in 512 byte sectors
2017-08-22 17:32 ` [PATCH v3 2/4] loop: set discard and write zeroes limits in 512 byte sectors Omar Sandoval
@ 2017-08-23 6:19 ` Hannes Reinecke
0 siblings, 0 replies; 9+ messages in thread
From: Hannes Reinecke @ 2017-08-23 6:19 UTC (permalink / raw)
To: Omar Sandoval, linux-block; +Cc: kernel-team, Ming Lei, Karel Zak, Milan Broz
On 08/22/2017 07:32 PM, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> max_discard_sectors and max_write_zeroes_sectors are in 512 byte
> sectors, not device sectors.
>
> Fixes: f2c6df7dbf9a ("loop: support 4k physical blocksize")
> Signed-off-by: Omar Sandoval <osandov@fb.com>
> ---
> drivers/block/loop.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 26548e07bc31..a444dc2d5977 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -820,7 +820,6 @@ static void loop_config_discard(struct loop_device *lo)
> struct file *file = lo->lo_backing_file;
> struct inode *inode = file->f_mapping->host;
> struct request_queue *q = lo->lo_queue;
> - int lo_bits = 9;
>
> /*
> * We use punch hole to reclaim the free space used by the
> @@ -840,11 +839,8 @@ static void loop_config_discard(struct loop_device *lo)
>
> q->limits.discard_granularity = inode->i_sb->s_blocksize;
> q->limits.discard_alignment = 0;
> - if (lo->lo_flags & LO_FLAGS_BLOCKSIZE)
> - lo_bits = blksize_bits(lo->lo_logical_blocksize);
> -
> - blk_queue_max_discard_sectors(q, UINT_MAX >> lo_bits);
> - blk_queue_max_write_zeroes_sectors(q, UINT_MAX >> lo_bits);
> + blk_queue_max_discard_sectors(q, UINT_MAX >> 9);
> + blk_queue_max_write_zeroes_sectors(q, UINT_MAX >> 9);
> queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, q);
> }
>
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3 3/4] loop: use queue limit instead of private lo_logical_blocksize
2017-08-22 17:32 [PATCH v3 0/4] loop: LO_FLAGS_BLOCKSIZE fixes Omar Sandoval
2017-08-22 17:32 ` [PATCH v3 1/4] loop: fix hang if LOOP_SET_STATUS gets invalid blocksize or encrypt type Omar Sandoval
2017-08-22 17:32 ` [PATCH v3 2/4] loop: set discard and write zeroes limits in 512 byte sectors Omar Sandoval
@ 2017-08-22 17:33 ` Omar Sandoval
2017-08-23 9:23 ` Karel Zak
2017-08-22 17:33 ` [PATCH v3 4/4] loop: always return block size in LOOP_GET_STATUS Omar Sandoval
2017-08-22 20:25 ` [PATCH v3 0/4] loop: LO_FLAGS_BLOCKSIZE fixes Jens Axboe
4 siblings, 1 reply; 9+ messages in thread
From: Omar Sandoval @ 2017-08-22 17:33 UTC (permalink / raw)
To: linux-block; +Cc: kernel-team, Hannes Reinecke, Ming Lei, Karel Zak, Milan Broz
From: Omar Sandoval <osandov@fb.com>
There's no reason to track this separately; just use the
logical_block_size queue limit. This also fixes an issue where the
physical block size would get changed unnecessarily.
Tested-by: Milan Broz <gmazyland@gmail.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Omar Sandoval <osandov@fb.com>
---
drivers/block/loop.c | 40 +++++++++++++++++-----------------------
drivers/block/loop.h | 1 -
2 files changed, 17 insertions(+), 24 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index a444dc2d5977..28026f0abaa9 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -221,8 +221,7 @@ static void __loop_update_dio(struct loop_device *lo, bool dio)
}
static int
-figure_loop_size(struct loop_device *lo, loff_t offset, loff_t sizelimit,
- loff_t logical_blocksize)
+figure_loop_size(struct loop_device *lo, loff_t offset, loff_t sizelimit)
{
loff_t size = get_size(offset, sizelimit, lo->lo_backing_file);
sector_t x = (sector_t)size;
@@ -234,12 +233,6 @@ figure_loop_size(struct loop_device *lo, loff_t offset, loff_t sizelimit,
lo->lo_offset = offset;
if (lo->lo_sizelimit != sizelimit)
lo->lo_sizelimit = sizelimit;
- if (lo->lo_flags & LO_FLAGS_BLOCKSIZE) {
- lo->lo_logical_blocksize = logical_blocksize;
- blk_queue_physical_block_size(lo->lo_queue, lo->lo_blocksize);
- blk_queue_logical_block_size(lo->lo_queue,
- lo->lo_logical_blocksize);
- }
set_capacity(lo->lo_disk, x);
bd_set_size(bdev, (loff_t)get_capacity(bdev->bd_disk) << 9);
/* let user-space know about the new size */
@@ -934,7 +927,6 @@ static int loop_set_fd(struct loop_device *lo, fmode_t mode,
lo->use_dio = false;
lo->lo_blocksize = lo_blocksize;
- lo->lo_logical_blocksize = 512;
lo->lo_device = bdev;
lo->lo_flags = lo_flags;
lo->lo_backing_file = file;
@@ -946,6 +938,9 @@ static int loop_set_fd(struct loop_device *lo, fmode_t mode,
if (!(lo_flags & LO_FLAGS_READ_ONLY) && file->f_op->fsync)
blk_queue_write_cache(lo->lo_queue, true, false);
+ blk_queue_logical_block_size(lo->lo_queue, 512);
+ blk_queue_physical_block_size(lo->lo_queue, 512);
+ blk_queue_io_min(lo->lo_queue, 512);
loop_update_dio(lo);
set_capacity(lo->lo_disk, size);
@@ -1133,14 +1128,7 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
} else
xfer = NULL;
- err = loop_init_xfer(lo, xfer, info);
- if (err)
- goto exit;
-
if (info->lo_flags & LO_FLAGS_BLOCKSIZE) {
- if (!(lo->lo_flags & LO_FLAGS_BLOCKSIZE))
- lo->lo_logical_blocksize = 512;
- lo->lo_flags |= LO_FLAGS_BLOCKSIZE;
if (LO_INFO_BLOCKSIZE(info) != 512 &&
LO_INFO_BLOCKSIZE(info) != 1024 &&
LO_INFO_BLOCKSIZE(info) != 2048 &&
@@ -1154,18 +1142,25 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
}
}
+ err = loop_init_xfer(lo, xfer, info);
+ if (err)
+ goto exit;
+
if (lo->lo_offset != info->lo_offset ||
lo->lo_sizelimit != info->lo_sizelimit ||
- lo->lo_flags != lo_flags ||
- ((lo->lo_flags & LO_FLAGS_BLOCKSIZE) &&
- lo->lo_logical_blocksize != LO_INFO_BLOCKSIZE(info))) {
- if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit,
- LO_INFO_BLOCKSIZE(info))) {
+ lo->lo_flags != lo_flags) {
+ if (figure_loop_size(lo, info->lo_offset, info->lo_sizelimit)) {
err = -EFBIG;
goto exit;
}
}
+ if (info->lo_flags & LO_FLAGS_BLOCKSIZE) {
+ blk_queue_logical_block_size(lo->lo_queue, LO_INFO_BLOCKSIZE(info));
+ blk_queue_physical_block_size(lo->lo_queue, LO_INFO_BLOCKSIZE(info));
+ blk_queue_io_min(lo->lo_queue, LO_INFO_BLOCKSIZE(info));
+ }
+
loop_config_discard(lo);
memcpy(lo->lo_file_name, info->lo_file_name, LO_NAME_SIZE);
@@ -1352,8 +1347,7 @@ static int loop_set_capacity(struct loop_device *lo)
if (unlikely(lo->lo_state != Lo_bound))
return -ENXIO;
- return figure_loop_size(lo, lo->lo_offset, lo->lo_sizelimit,
- lo->lo_logical_blocksize);
+ return figure_loop_size(lo, lo->lo_offset, lo->lo_sizelimit);
}
static int loop_set_dio(struct loop_device *lo, unsigned long arg)
diff --git a/drivers/block/loop.h b/drivers/block/loop.h
index 2c096b9a17b8..fecd3f97ef8c 100644
--- a/drivers/block/loop.h
+++ b/drivers/block/loop.h
@@ -49,7 +49,6 @@ struct loop_device {
struct file * lo_backing_file;
struct block_device *lo_device;
unsigned lo_blocksize;
- unsigned lo_logical_blocksize;
void *key_data;
gfp_t old_gfp_mask;
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v3 3/4] loop: use queue limit instead of private lo_logical_blocksize
2017-08-22 17:33 ` [PATCH v3 3/4] loop: use queue limit instead of private lo_logical_blocksize Omar Sandoval
@ 2017-08-23 9:23 ` Karel Zak
2017-08-23 16:16 ` Omar Sandoval
0 siblings, 1 reply; 9+ messages in thread
From: Karel Zak @ 2017-08-23 9:23 UTC (permalink / raw)
To: Omar Sandoval
Cc: linux-block, kernel-team, Hannes Reinecke, Ming Lei, Milan Broz
On Tue, Aug 22, 2017 at 10:33:00AM -0700, Omar Sandoval wrote:
> @@ -946,6 +938,9 @@ static int loop_set_fd(struct loop_device *lo, fmode_t mode,
>
> if (!(lo_flags & LO_FLAGS_READ_ONLY) && file->f_op->fsync)
> blk_queue_write_cache(lo->lo_queue, true, false);
> + blk_queue_logical_block_size(lo->lo_queue, 512);
> + blk_queue_physical_block_size(lo->lo_queue, 512);
> + blk_queue_io_min(lo->lo_queue, 512);
...
> @@ -1133,14 +1128,7 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
...
> + if (info->lo_flags & LO_FLAGS_BLOCKSIZE) {
> + blk_queue_logical_block_size(lo->lo_queue, LO_INFO_BLOCKSIZE(info));
> + blk_queue_physical_block_size(lo->lo_queue, LO_INFO_BLOCKSIZE(info));
> + blk_queue_io_min(lo->lo_queue, LO_INFO_BLOCKSIZE(info));
> + }
> +
I don't understand this.
* it seems the default is 512, but what about if the backing file
is not a regular file? For example "losetup -f /dev/sda" where
sda sector size is > 512.
* why the attributes in the /sys are affected by LO_FLAGS_BLOCKSIZE?
Would be better to have a real sizes there (independently on the flag)?
* I think kernel lies in /sys about I/O size now. The phy sector size
has never been 512, but PAGE_SIZE or real phy sector if backing file
is a block device.
Your patch improves it for LO_FLAGS_BLOCKSIZE, but it's still lies
about internally used I/O sizes.
Why we cannot use
blk_queue_physical_block_size(lo->lo_queue, lo->lo_blocksize);
blk_queue_logical_block_size(lo->lo_queue, lo->lo_logical_blocksize);
(as suggested by Hannes' original patch), but without
if (info->lo_flags & LO_FLAGS_BLOCKSIZE)
condition?
Yes, result will be backwardly incompatible, but the current
situation (all is 512) does not describe reality. It's legacy from
time where all in kernel was 512...
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v3 3/4] loop: use queue limit instead of private lo_logical_blocksize
2017-08-23 9:23 ` Karel Zak
@ 2017-08-23 16:16 ` Omar Sandoval
0 siblings, 0 replies; 9+ messages in thread
From: Omar Sandoval @ 2017-08-23 16:16 UTC (permalink / raw)
To: Karel Zak; +Cc: linux-block, kernel-team, Hannes Reinecke, Ming Lei, Milan Broz
On Wed, Aug 23, 2017 at 11:23:55AM +0200, Karel Zak wrote:
> On Tue, Aug 22, 2017 at 10:33:00AM -0700, Omar Sandoval wrote:
> > @@ -946,6 +938,9 @@ static int loop_set_fd(struct loop_device *lo, fmode_t mode,
> >
> > if (!(lo_flags & LO_FLAGS_READ_ONLY) && file->f_op->fsync)
> > blk_queue_write_cache(lo->lo_queue, true, false);
> > + blk_queue_logical_block_size(lo->lo_queue, 512);
> > + blk_queue_physical_block_size(lo->lo_queue, 512);
> > + blk_queue_io_min(lo->lo_queue, 512);
>
> ...
>
> > @@ -1133,14 +1128,7 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
> ...
> > + if (info->lo_flags & LO_FLAGS_BLOCKSIZE) {
> > + blk_queue_logical_block_size(lo->lo_queue, LO_INFO_BLOCKSIZE(info));
> > + blk_queue_physical_block_size(lo->lo_queue, LO_INFO_BLOCKSIZE(info));
> > + blk_queue_io_min(lo->lo_queue, LO_INFO_BLOCKSIZE(info));
> > + }
> > +
>
> I don't understand this.
>
> * it seems the default is 512, but what about if the backing file
> is not a regular file? For example "losetup -f /dev/sda" where
> sda sector size is > 512.
I didn't change the legacy behavior here, i.e., it's always 512 by
default.
> * why the attributes in the /sys are affected by LO_FLAGS_BLOCKSIZE?
> Would be better to have a real sizes there (independently on the flag)?
What do you mean? LO_FLAGS_BLOCKSIZE means I want to change the logical
blocksize of the loop device, so why shouldn't it be reflected in sysfs?
> * I think kernel lies in /sys about I/O size now. The phy sector size
> has never been 512, but PAGE_SIZE or real phy sector if backing file
> is a block device.
>
> Your patch improves it for LO_FLAGS_BLOCKSIZE, but it's still lies
> about internally used I/O sizes.
>
> Why we cannot use
>
> blk_queue_physical_block_size(lo->lo_queue, lo->lo_blocksize);
> blk_queue_logical_block_size(lo->lo_queue, lo->lo_logical_blocksize);
>
> (as suggested by Hannes' original patch), but without
>
> if (info->lo_flags & LO_FLAGS_BLOCKSIZE)
>
> condition?
>
> Yes, result will be backwardly incompatible, but the current
> situation (all is 512) does not describe reality. It's legacy from
> time where all in kernel was 512...
I went back and forth on this. Yeah, the kernel is lying, and using the
backing block size makes more sense, but backwards compatability is
exactly why I didn't change this. Then again, the physical block size is
more of a hint, so it might be safe to change this.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3 4/4] loop: always return block size in LOOP_GET_STATUS
2017-08-22 17:32 [PATCH v3 0/4] loop: LO_FLAGS_BLOCKSIZE fixes Omar Sandoval
` (2 preceding siblings ...)
2017-08-22 17:33 ` [PATCH v3 3/4] loop: use queue limit instead of private lo_logical_blocksize Omar Sandoval
@ 2017-08-22 17:33 ` Omar Sandoval
2017-08-22 20:25 ` [PATCH v3 0/4] loop: LO_FLAGS_BLOCKSIZE fixes Jens Axboe
4 siblings, 0 replies; 9+ messages in thread
From: Omar Sandoval @ 2017-08-22 17:33 UTC (permalink / raw)
To: linux-block; +Cc: kernel-team, Hannes Reinecke, Ming Lei, Karel Zak, Milan Broz
From: Omar Sandoval <osandov@fb.com>
When I was writing a test for the new loop device block size
functionality, I noticed a couple of issues with how LOOP_GET_STATUS
handles the block size:
- lo_init[0] is never filled in with the logical block size we
previously set
- lo_flags returned from LOOP_GET_STATUS will have LO_FLAGS_BLOCKSIZE
set if we previously called LOOP_SET_STATUS with LO_FLAGS_BLOCKSIZE
set, which doesn't really mean anything
Instead, for LOOP_GET_STATUS, let's always fill in lo_init[0] and set
the LO_FLAGS_BLOCKSIZE flag to indicate we support it.
Tested-by: Milan Broz <gmazyland@gmail.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Omar Sandoval <osandov@fb.com>
---
drivers/block/loop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 28026f0abaa9..b55a1f82f561 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -1222,7 +1222,7 @@ loop_get_status(struct loop_device *lo, struct loop_info64 *info)
info->lo_rdevice = huge_encode_dev(lo->lo_device ? stat.rdev : stat.dev);
info->lo_offset = lo->lo_offset;
info->lo_sizelimit = lo->lo_sizelimit;
- info->lo_flags = lo->lo_flags;
+ info->lo_flags = lo->lo_flags | LO_FLAGS_BLOCKSIZE;
memcpy(info->lo_file_name, lo->lo_file_name, LO_NAME_SIZE);
memcpy(info->lo_crypt_name, lo->lo_crypt_name, LO_NAME_SIZE);
info->lo_encrypt_type =
@@ -1232,6 +1232,7 @@ loop_get_status(struct loop_device *lo, struct loop_info64 *info)
memcpy(info->lo_encrypt_key, lo->lo_encrypt_key,
lo->lo_encrypt_key_size);
}
+ LO_INFO_BLOCKSIZE(info) = queue_logical_block_size(lo->lo_queue);
return 0;
}
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v3 0/4] loop: LO_FLAGS_BLOCKSIZE fixes
2017-08-22 17:32 [PATCH v3 0/4] loop: LO_FLAGS_BLOCKSIZE fixes Omar Sandoval
` (3 preceding siblings ...)
2017-08-22 17:33 ` [PATCH v3 4/4] loop: always return block size in LOOP_GET_STATUS Omar Sandoval
@ 2017-08-22 20:25 ` Jens Axboe
4 siblings, 0 replies; 9+ messages in thread
From: Jens Axboe @ 2017-08-22 20:25 UTC (permalink / raw)
To: Omar Sandoval, linux-block
Cc: kernel-team, Hannes Reinecke, Ming Lei, Karel Zak, Milan Broz
On 08/22/2017 11:32 AM, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> Patches 1, 3, and 4 are the same as v2, plus added reviewed-bys and
> tested-bys from Milan. Patch 2 is new.
>
> Omar Sandoval (4):
> loop: fix hang if LOOP_SET_STATUS gets invalid blocksize or encrypt
> type
> loop: set discard and write zeroes limits in 512 byte sectors
> loop: use queue limit instead of private lo_logical_blocksize
> loop: always return block size in LOOP_GET_STATUS
Queued up, thanks Omar.
--
Jens Axboe
^ permalink raw reply [flat|nested] 9+ messages in thread