From: Christoffer Dall <christoffer.dall@linaro.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: kvm@vger.kernel.org, marc.zyngier@arm.com,
linux-kernel@vger.kernel.org, pbonzini@redhat.com,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm/arm64: vgic: constify seq_operations and file_operations
Date: Thu, 24 Aug 2017 09:20:34 -0700 [thread overview]
Message-ID: <20170824162034.GC2150@lvm> (raw)
In-Reply-To: <de67d01fab53d5b7874cda1ac2c269887c673450.1503471217.git.arvind.yadav.cs@gmail.com>
On Wed, Aug 23, 2017 at 12:25:36PM +0530, Arvind Yadav wrote:
> vgic_debug_seq_ops and file_operations are not supposed to change
> at runtime and none of the structures is modified.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied, thanks.
-Christoffer
> ---
> virt/kvm/arm/vgic/vgic-debug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/virt/kvm/arm/vgic/vgic-debug.c b/virt/kvm/arm/vgic/vgic-debug.c
> index 7072ab7..10b3817 100644
> --- a/virt/kvm/arm/vgic/vgic-debug.c
> +++ b/virt/kvm/arm/vgic/vgic-debug.c
> @@ -234,7 +234,7 @@ static int vgic_debug_show(struct seq_file *s, void *v)
> return 0;
> }
>
> -static struct seq_operations vgic_debug_seq_ops = {
> +static const struct seq_operations vgic_debug_seq_ops = {
> .start = vgic_debug_start,
> .next = vgic_debug_next,
> .stop = vgic_debug_stop,
> @@ -255,7 +255,7 @@ static int debug_open(struct inode *inode, struct file *file)
> return ret;
> };
>
> -static struct file_operations vgic_debug_fops = {
> +static const struct file_operations vgic_debug_fops = {
> .owner = THIS_MODULE,
> .open = debug_open,
> .read = seq_read,
> --
> 1.9.1
>
WARNING: multiple messages have this Message-ID (diff)
From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] KVM: arm/arm64: vgic: constify seq_operations and file_operations
Date: Thu, 24 Aug 2017 09:20:34 -0700 [thread overview]
Message-ID: <20170824162034.GC2150@lvm> (raw)
In-Reply-To: <de67d01fab53d5b7874cda1ac2c269887c673450.1503471217.git.arvind.yadav.cs@gmail.com>
On Wed, Aug 23, 2017 at 12:25:36PM +0530, Arvind Yadav wrote:
> vgic_debug_seq_ops and file_operations are not supposed to change
> at runtime and none of the structures is modified.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied, thanks.
-Christoffer
> ---
> virt/kvm/arm/vgic/vgic-debug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/virt/kvm/arm/vgic/vgic-debug.c b/virt/kvm/arm/vgic/vgic-debug.c
> index 7072ab7..10b3817 100644
> --- a/virt/kvm/arm/vgic/vgic-debug.c
> +++ b/virt/kvm/arm/vgic/vgic-debug.c
> @@ -234,7 +234,7 @@ static int vgic_debug_show(struct seq_file *s, void *v)
> return 0;
> }
>
> -static struct seq_operations vgic_debug_seq_ops = {
> +static const struct seq_operations vgic_debug_seq_ops = {
> .start = vgic_debug_start,
> .next = vgic_debug_next,
> .stop = vgic_debug_stop,
> @@ -255,7 +255,7 @@ static int debug_open(struct inode *inode, struct file *file)
> return ret;
> };
>
> -static struct file_operations vgic_debug_fops = {
> +static const struct file_operations vgic_debug_fops = {
> .owner = THIS_MODULE,
> .open = debug_open,
> .read = seq_read,
> --
> 1.9.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Christoffer Dall <christoffer.dall@linaro.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: marc.zyngier@arm.com, pbonzini@redhat.com, rkrcmar@redhat.com,
linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm/arm64: vgic: constify seq_operations and file_operations
Date: Thu, 24 Aug 2017 09:20:34 -0700 [thread overview]
Message-ID: <20170824162034.GC2150@lvm> (raw)
In-Reply-To: <de67d01fab53d5b7874cda1ac2c269887c673450.1503471217.git.arvind.yadav.cs@gmail.com>
On Wed, Aug 23, 2017 at 12:25:36PM +0530, Arvind Yadav wrote:
> vgic_debug_seq_ops and file_operations are not supposed to change
> at runtime and none of the structures is modified.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Applied, thanks.
-Christoffer
> ---
> virt/kvm/arm/vgic/vgic-debug.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/virt/kvm/arm/vgic/vgic-debug.c b/virt/kvm/arm/vgic/vgic-debug.c
> index 7072ab7..10b3817 100644
> --- a/virt/kvm/arm/vgic/vgic-debug.c
> +++ b/virt/kvm/arm/vgic/vgic-debug.c
> @@ -234,7 +234,7 @@ static int vgic_debug_show(struct seq_file *s, void *v)
> return 0;
> }
>
> -static struct seq_operations vgic_debug_seq_ops = {
> +static const struct seq_operations vgic_debug_seq_ops = {
> .start = vgic_debug_start,
> .next = vgic_debug_next,
> .stop = vgic_debug_stop,
> @@ -255,7 +255,7 @@ static int debug_open(struct inode *inode, struct file *file)
> return ret;
> };
>
> -static struct file_operations vgic_debug_fops = {
> +static const struct file_operations vgic_debug_fops = {
> .owner = THIS_MODULE,
> .open = debug_open,
> .read = seq_read,
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-08-24 16:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 6:55 [PATCH] KVM: arm/arm64: vgic: constify seq_operations and file_operations Arvind Yadav
2017-08-23 6:55 ` Arvind Yadav
2017-08-24 16:20 ` Christoffer Dall [this message]
2017-08-24 16:20 ` Christoffer Dall
2017-08-24 16:20 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824162034.GC2150@lvm \
--to=christoffer.dall@linaro.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.