From: gregkh@linuxfoundation.org (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] binder: allow ANDROID_BINDER_IPC_32BIT to be unselected on 32bit ARM
Date: Thu, 24 Aug 2017 17:19:36 -0700 [thread overview]
Message-ID: <20170825001936.GA4811@kroah.com> (raw)
In-Reply-To: <20170824024928.707-1-jszhang@marvell.com>
On Thu, Aug 24, 2017 at 10:49:28AM +0800, Jisheng Zhang wrote:
> As noted in commit d0bdff0db809 ("staging: Fix build issues with new
> binder API"), we can add back the choice for 32bit ARM "once a 64bit
> __get_user_asm_* implementation is merged." Commit e38361d032f1 ("ARM:
> 8091/2: add get_user() support for 8 byte types") has added the
> support, so it's time to allow ANDROID_BINDER_IPC_32BIT to be
> unselected on 32bit ARM so that the 64bit ABI can be tested/used on
> 32bit systems.
>
> This change allows running the same 32bit userspace build no matter
> the kernel is 64bit or 32bit.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> Since v1:
> - fix the commit msg
>
> drivers/android/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig
> index 832e885349b1..aca5dc30b97b 100644
> --- a/drivers/android/Kconfig
> +++ b/drivers/android/Kconfig
> @@ -32,7 +32,7 @@ config ANDROID_BINDER_DEVICES
> therefore logically separated from the other devices.
>
> config ANDROID_BINDER_IPC_32BIT
> - bool
> + bool "Use old (Android 4.4 and earlier) 32-bit binder API"
Again, your changelog text does not match up with what this patch does
at all, please fix something...
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: arve@android.com, riandrews@android.com, john.stultz@linaro.org,
devel@driverdev.osuosl.org, robh@kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] binder: allow ANDROID_BINDER_IPC_32BIT to be unselected on 32bit ARM
Date: Thu, 24 Aug 2017 17:19:36 -0700 [thread overview]
Message-ID: <20170825001936.GA4811@kroah.com> (raw)
In-Reply-To: <20170824024928.707-1-jszhang@marvell.com>
On Thu, Aug 24, 2017 at 10:49:28AM +0800, Jisheng Zhang wrote:
> As noted in commit d0bdff0db809 ("staging: Fix build issues with new
> binder API"), we can add back the choice for 32bit ARM "once a 64bit
> __get_user_asm_* implementation is merged." Commit e38361d032f1 ("ARM:
> 8091/2: add get_user() support for 8 byte types") has added the
> support, so it's time to allow ANDROID_BINDER_IPC_32BIT to be
> unselected on 32bit ARM so that the 64bit ABI can be tested/used on
> 32bit systems.
>
> This change allows running the same 32bit userspace build no matter
> the kernel is 64bit or 32bit.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> Since v1:
> - fix the commit msg
>
> drivers/android/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig
> index 832e885349b1..aca5dc30b97b 100644
> --- a/drivers/android/Kconfig
> +++ b/drivers/android/Kconfig
> @@ -32,7 +32,7 @@ config ANDROID_BINDER_DEVICES
> therefore logically separated from the other devices.
>
> config ANDROID_BINDER_IPC_32BIT
> - bool
> + bool "Use old (Android 4.4 and earlier) 32-bit binder API"
Again, your changelog text does not match up with what this patch does
at all, please fix something...
greg k-h
next prev parent reply other threads:[~2017-08-25 0:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-24 2:49 [PATCH v2] binder: allow ANDROID_BINDER_IPC_32BIT to be unselected on 32bit ARM Jisheng Zhang
2017-08-24 2:49 ` Jisheng Zhang
2017-08-25 0:19 ` Greg KH [this message]
2017-08-25 0:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170825001936.GA4811@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.