All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Keeping <john@metanate.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
	Tom Rini <trini@konsulko.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Bard Liao <bardliao@realtek.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
Date: Fri, 25 Aug 2017 17:05:04 +0100	[thread overview]
Message-ID: <20170825170504.7d547aa4.john@metanate.com> (raw)
In-Reply-To: <20170825142426.GN2827@bill-the-cat>

On Fri, 25 Aug 2017 10:24:26 -0400, Tom Rini wrote:

> On Fri, Aug 25, 2017 at 04:56:47PM +0300, Andy Shevchenko wrote:
> > +John
> > 
> > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:  
> > > Not all devices with ACPI and this combination of sound devices will
> > > have the required information provided via ACPI.  Reintroduce the I2C
> > > device ID to restore sound functionality on on the Chromebook 'Samus'
> > > model.  
> > 
> > Tom, one more question.
> > 
> > Apparently you are the one who tested the commit
> > 	89128534f925 ("ASoC: rt5677: Add ACPI support")
> > year ago.  
> 
> Yes.
> 
> > The commit states that ACPI properties that are used in Chromebook Pixel
> > 2015 is non-standard (not the same as for DT).
> > 
> > However, DSDT shows the opposite!  
> 
> Interesting.  I'm not an ACPI person, I just tested what John came up
> with.

And the patch adding this was the first (and still only) time I've
really looked at ACPI, so it's quite possible that I misunderstood
something at the time.

From memory, I think the particular problem I was referring to in the
commit message was that certain GPIOs were only defined by index and not
by property name (specifically "plug-det-gpios", "mic-present-gpios" and
"headphone-enable-gpios"), and having dumped DSDT just now I do not see
those strings appearing anywhere.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

WARNING: multiple messages have this Message-ID (diff)
From: John Keeping <john@metanate.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Tom Rini <trini@konsulko.com>,
	linux-kernel@vger.kernel.org, Bard Liao <bardliao@realtek.com>,
	Oder Chiou <oder_chiou@realtek.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs
Date: Fri, 25 Aug 2017 17:05:04 +0100	[thread overview]
Message-ID: <20170825170504.7d547aa4.john@metanate.com> (raw)
In-Reply-To: <20170825142426.GN2827@bill-the-cat>

On Fri, 25 Aug 2017 10:24:26 -0400, Tom Rini wrote:

> On Fri, Aug 25, 2017 at 04:56:47PM +0300, Andy Shevchenko wrote:
> > +John
> > 
> > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:  
> > > Not all devices with ACPI and this combination of sound devices will
> > > have the required information provided via ACPI.  Reintroduce the I2C
> > > device ID to restore sound functionality on on the Chromebook 'Samus'
> > > model.  
> > 
> > Tom, one more question.
> > 
> > Apparently you are the one who tested the commit
> > 	89128534f925 ("ASoC: rt5677: Add ACPI support")
> > year ago.  
> 
> Yes.
> 
> > The commit states that ACPI properties that are used in Chromebook Pixel
> > 2015 is non-standard (not the same as for DT).
> > 
> > However, DSDT shows the opposite!  
> 
> Interesting.  I'm not an ACPI person, I just tested what John came up
> with.

And the patch adding this was the first (and still only) time I've
really looked at ACPI, so it's quite possible that I misunderstood
something at the time.

>From memory, I think the particular problem I was referring to in the
commit message was that certain GPIOs were only defined by index and not
by property name (specifically "plug-det-gpios", "mic-present-gpios" and
"headphone-enable-gpios"), and having dumped DSDT just now I do not see
those strings appearing anywhere.

  parent reply	other threads:[~2017-08-25 16:06 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-23  1:51 [PATCH] ASoC: rt5677: Reintroduce I2C device IDs Tom Rini
2017-08-23  1:51 ` Tom Rini
2017-08-23  9:28 ` Mark Brown
2017-08-23 22:35   ` Tom Rini
2017-08-23 22:47     ` Mark Brown
2017-08-23 22:54       ` Tom Rini
2017-08-23 22:54         ` Tom Rini
2017-08-23 23:15         ` Mark Brown
2017-08-23 23:02       ` Mark Brown
2017-08-23 14:29 ` Andy Shevchenko
2017-08-23 17:39   ` Tom Rini
2017-08-24  0:05     ` Tom Rini
2017-08-24  7:39       ` Andy Shevchenko
2017-08-24  7:39         ` Andy Shevchenko
2017-08-24 11:15         ` Tom Rini
2017-08-24 11:15           ` Tom Rini
2017-08-24 12:26           ` Andy Shevchenko
2017-08-24 13:41             ` Mark Brown
2017-08-24 13:47             ` Tom Rini
2017-08-24 14:28       ` [alsa-devel] " Takashi Iwai
2017-08-24 14:31         ` Takashi Iwai
2017-08-24 14:31           ` Takashi Iwai
2017-08-24 14:41           ` Tom Rini
2017-08-24 14:41             ` [alsa-devel] " Tom Rini
2017-08-24 15:42             ` Takashi Iwai
2017-08-24 15:52               ` Mark Brown
2017-08-24 15:52                 ` [alsa-devel] " Mark Brown
2017-08-24 15:54                 ` Takashi Iwai
2017-08-24 15:54                 ` Tom Rini
2017-08-24 16:06                   ` Takashi Iwai
2017-08-24 16:06                     ` [alsa-devel] " Takashi Iwai
2017-08-24 16:08                     ` Tom Rini
2017-08-24 17:16                     ` Andy Shevchenko
2017-08-24 17:44                       ` Takashi Iwai
2017-08-24 17:44                         ` [alsa-devel] " Takashi Iwai
2017-08-25 13:48                         ` Mark Brown
2017-08-25 13:48                           ` [alsa-devel] " Mark Brown
2017-08-25 13:09                     ` Mark Brown
2017-08-25 13:09                       ` [alsa-devel] " Mark Brown
2017-08-25 13:17                       ` Takashi Iwai
2017-08-25 13:17                         ` [alsa-devel] " Takashi Iwai
2017-08-25 13:56 ` Andy Shevchenko
2017-08-25 14:24   ` Tom Rini
2017-08-25 14:24     ` Tom Rini
2017-08-25 14:49     ` Andy Shevchenko
2017-08-25 16:05     ` John Keeping [this message]
2017-08-25 16:05       ` John Keeping
2017-08-25 16:42       ` Andy Shevchenko
2017-08-25 16:42         ` Andy Shevchenko
2017-08-25 17:09         ` John Keeping
2017-08-25 19:33         ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170825170504.7d547aa4.john@metanate.com \
    --to=john@metanate.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bardliao@realtek.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=tiwai@suse.com \
    --cc=torvalds@linux-foundation.org \
    --cc=trini@konsulko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.