From: Andrew Lunn <andrew@lunn.ch>
To: "Andreas Färber" <afaerber@suse.de>
Cc: linux-rtc@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>, Roc He <hepeng@zidoo.tv>,
????????? <jiang.liqin@geniatech.com>,
linux-kernel@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] rtc: Add Realtek RTD1295
Date: Sun, 27 Aug 2017 05:27:45 +0200 [thread overview]
Message-ID: <20170827032745.GC13622@lunn.ch> (raw)
In-Reply-To: <a2a21bc4-b7a9-cadf-920c-f078c673dbb9@suse.de>
On Sun, Aug 27, 2017 at 04:30:08AM +0200, Andreas Färber wrote:
> Am 27.08.2017 um 04:05 schrieb Andrew Lunn:
> > n Sun, Aug 27, 2017 at 02:33:27AM +0200, Andreas Färber wrote:
> >> +struct rtd119x_rtc {
> >> + void __iomem *base;
> >> + struct clk *clk;
> >> + struct rtc_device *rtcdev;
> >> + unsigned base_year;
> >> + spinlock_t lock;
> >
> > Where is this lock initialised? I would expect a call to
> > spin_lock_init() somewhere.
>
> Hm, the spinlock in my irq mux series doesn't have that call either; my
> reset driver did have it. The zero initialization appears to work OK,
> but you're probably right that it should be there.
Hi Andreas
I suspect you will have problems if you enable spin lock debug code,
like CONFIG_DEBUG_SPINLOCK.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/3] rtc: Add Realtek RTD1295
Date: Sun, 27 Aug 2017 05:27:45 +0200 [thread overview]
Message-ID: <20170827032745.GC13622@lunn.ch> (raw)
In-Reply-To: <a2a21bc4-b7a9-cadf-920c-f078c673dbb9@suse.de>
On Sun, Aug 27, 2017 at 04:30:08AM +0200, Andreas F?rber wrote:
> Am 27.08.2017 um 04:05 schrieb Andrew Lunn:
> > n Sun, Aug 27, 2017 at 02:33:27AM +0200, Andreas F?rber wrote:
> >> +struct rtd119x_rtc {
> >> + void __iomem *base;
> >> + struct clk *clk;
> >> + struct rtc_device *rtcdev;
> >> + unsigned base_year;
> >> + spinlock_t lock;
> >
> > Where is this lock initialised? I would expect a call to
> > spin_lock_init() somewhere.
>
> Hm, the spinlock in my irq mux series doesn't have that call either; my
> reset driver did have it. The zero initialization appears to work OK,
> but you're probably right that it should be there.
Hi Andreas
I suspect you will have problems if you enable spin lock debug code,
like CONFIG_DEBUG_SPINLOCK.
Andrew
next prev parent reply other threads:[~2017-08-27 3:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-27 0:33 [PATCH v2 0/3] arm64: Realtek RTD1295 RTC Andreas Färber
2017-08-27 0:33 ` Andreas Färber
2017-08-27 0:33 ` [PATCH v2 1/3] dt-bindings: rtc: Add Realtek RTD1295 Andreas Färber
2017-08-27 0:33 ` Andreas Färber
2017-08-27 0:33 ` Andreas Färber
2017-08-27 0:33 ` [PATCH v2 2/3] " Andreas Färber
2017-08-27 0:33 ` Andreas Färber
2017-08-27 2:05 ` Andrew Lunn
2017-08-27 2:05 ` Andrew Lunn
2017-08-27 2:30 ` Andreas Färber
2017-08-27 2:30 ` Andreas Färber
2017-08-27 3:27 ` Andrew Lunn [this message]
2017-08-27 3:27 ` Andrew Lunn
2017-08-27 10:21 ` Andreas Färber
2017-08-27 10:21 ` Andreas Färber
2017-08-27 8:27 ` Alexandre Belloni
2017-08-27 8:27 ` Alexandre Belloni
2017-08-27 10:28 ` Andreas Färber
2017-08-27 10:28 ` Andreas Färber
2017-08-27 9:13 ` Alexandre Belloni
2017-08-27 9:13 ` Alexandre Belloni
2017-08-27 11:30 ` Andreas Färber
2017-08-27 11:30 ` Andreas Färber
2017-08-27 13:37 ` Andrew Lunn
2017-08-27 13:37 ` Andrew Lunn
2017-08-27 19:26 ` Alexandre Belloni
2017-08-27 19:26 ` Alexandre Belloni
2017-08-28 15:50 ` Alexandre Belloni
2017-08-28 15:50 ` Alexandre Belloni
2017-08-27 0:33 ` [PATCH v2 3/3] arm64: dts: realtek: Add RTD1295 RTC node Andreas Färber
2017-08-27 0:33 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170827032745.GC13622@lunn.ch \
--to=andrew@lunn.ch \
--cc=a.zummo@towertech.it \
--cc=afaerber@suse.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=hepeng@zidoo.tv \
--cc=jiang.liqin@geniatech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.