All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jan Kara <jack@suse.cz>,
	linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: consolidate the various page fault handlers
Date: Mon, 28 Aug 2017 11:50:14 -0600	[thread overview]
Message-ID: <20170828175014.GA17577@linux.intel.com> (raw)
In-Reply-To: <20170825071538.GB9191@lst.de>

On Fri, Aug 25, 2017 at 09:15:38AM +0200, Christoph Hellwig wrote:
> On Thu, Aug 24, 2017 at 03:29:42PM -0600, Ross Zwisler wrote:
<>
> > I wonder if pe_size would be more readable as a string via __print_symbolic()
> > so we see "pe_size PMD" instead of "pe_size 1" from enum page_entry_size?
> 
> Probably.  I was just lazy :)  If I want to go all the way I could also
> use a __print_flags for the FAULT_FLAG_* flags.

Yep - I'm doing that in include/trace/events/fs_dax.h if you want to just copy
& paste.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org,
	linux-xfs@vger.kernel.org,
	Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 2/3] xfs: consolidate the various page fault handlers
Date: Mon, 28 Aug 2017 11:50:14 -0600	[thread overview]
Message-ID: <20170828175014.GA17577@linux.intel.com> (raw)
In-Reply-To: <20170825071538.GB9191@lst.de>

On Fri, Aug 25, 2017 at 09:15:38AM +0200, Christoph Hellwig wrote:
> On Thu, Aug 24, 2017 at 03:29:42PM -0600, Ross Zwisler wrote:
<>
> > I wonder if pe_size would be more readable as a string via __print_symbolic()
> > so we see "pe_size PMD" instead of "pe_size 1" from enum page_entry_size?
> 
> Probably.  I was just lazy :)  If I want to go all the way I could also
> use a __print_flags for the FAULT_FLAG_* flags.

Yep - I'm doing that in include/trace/events/fs_dax.h if you want to just copy
& paste.

  reply	other threads:[~2017-08-28 17:47 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 15:22 synchronous page faults for XFS Christoph Hellwig
2017-08-24 15:22 ` Christoph Hellwig
2017-08-24 15:22 ` [PATCH 1/3] iomap: return VM_FAULT_* codes from iomap_page_mkwrite Christoph Hellwig
2017-08-24 15:22   ` Christoph Hellwig
2017-08-24 19:26   ` Ross Zwisler
2017-08-24 19:26     ` Ross Zwisler
2017-08-25  7:10     ` Christoph Hellwig
2017-08-25  7:10       ` Christoph Hellwig
2017-08-24 15:22 ` [PATCH 2/3] xfs: consolidate the various page fault handlers Christoph Hellwig
2017-08-24 15:22   ` Christoph Hellwig
2017-08-24 21:29   ` Ross Zwisler
2017-08-24 21:29     ` Ross Zwisler
2017-08-25  7:15     ` Christoph Hellwig
2017-08-25  7:15       ` Christoph Hellwig
2017-08-28 17:50       ` Ross Zwisler [this message]
2017-08-28 17:50         ` Ross Zwisler
2017-08-28 17:52         ` Christoph Hellwig
2017-08-28 17:52           ` Christoph Hellwig
2017-08-28 20:09           ` Ross Zwisler
2017-08-28 20:09             ` Ross Zwisler
2017-08-24 15:22 ` [PATCH 3/3] xfs: support for synchronous DAX faults Christoph Hellwig
2017-08-24 15:22   ` Christoph Hellwig
2017-08-24 21:42   ` Ross Zwisler
2017-08-24 21:42     ` Ross Zwisler
2017-08-25  0:13   ` Dan Williams
2017-08-25  0:13     ` Dan Williams
2017-08-25  6:50     ` Christoph Hellwig
2017-08-25  6:50       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170828175014.GA17577@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.