All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Glisse <jglisse@redhat.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
	"Bernhard Held" <berny156@gmx.de>,
	"Adam Borowski" <kilobyte@angband.pl>,
	"Andrea Arcangeli" <aarcange@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Wanpeng Li" <kernellwp@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Takashi Iwai" <tiwai@suse.de>,
	"Nadav Amit" <nadav.amit@gmail.com>,
	"Mike Galbraith" <efault@gmx.de>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	axie <axie@amd.com>, "Andrew Morton" <akpm@linux-foundation.org>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Ross Zwisler" <ross.zwisler@linux.intel.com>
Subject: Re: [PATCH 0/4] mmu_notifier semantic update
Date: Tue, 29 Aug 2017 16:15:56 -0400	[thread overview]
Message-ID: <20170829201555.GG7546@redhat.com> (raw)
In-Reply-To: <20170829201132.9292-1-jglisse@redhat.com>

On Tue, Aug 29, 2017 at 04:11:28PM -0400, Jerome Glisse wrote:
> So we do not want to allow sleep during call to mmu_notifier_invalidate_page()
> but some code do not have surrounding mmu_notifier_invalidate_range_start()/
> mmu_notifier_invalidate_range_end() or mmu_notifier_invalidate_range()
> 
> This patch serie just make sure that there is at least a call (outside spinlock
> section) to mmu_notifier_invalidate_range() after mmu_notifier_invalidate_page()
> 
> This fix issue with AMD IOMMU v2 while avoiding to introduce issue for others
> user of the mmu_notifier API. For releavent threads see:
> 
> https://lkml.kernel.org/r/20170809204333.27485-1-jglisse@redhat.com
> https://lkml.kernel.org/r/20170804134928.l4klfcnqatni7vsc@black.fi.intel.com
> https://marc.info/?l=kvm&m=150327081325160&w=2

Please ignore this. Instead plan is to kill invalidate_page() switch
it to invalidate_range() and make sure there is always range_start/
range_end happening around.

Jerome

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Jerome Glisse <jglisse@redhat.com>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
	"Bernhard Held" <berny156@gmx.de>,
	"Adam Borowski" <kilobyte@angband.pl>,
	"Andrea Arcangeli" <aarcange@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"Wanpeng Li" <kernellwp@gmail.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Takashi Iwai" <tiwai@suse.de>,
	"Nadav Amit" <nadav.amit@gmail.com>,
	"Mike Galbraith" <efault@gmx.de>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	axie <axie@amd.com>, "Andrew Morton" <akpm@linux-foundation.org>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Ross Zwisler" <ross.zwisler@linux.intel.com>
Subject: Re: [PATCH 0/4] mmu_notifier semantic update
Date: Tue, 29 Aug 2017 16:15:56 -0400	[thread overview]
Message-ID: <20170829201555.GG7546@redhat.com> (raw)
In-Reply-To: <20170829201132.9292-1-jglisse@redhat.com>

On Tue, Aug 29, 2017 at 04:11:28PM -0400, Jérôme Glisse wrote:
> So we do not want to allow sleep during call to mmu_notifier_invalidate_page()
> but some code do not have surrounding mmu_notifier_invalidate_range_start()/
> mmu_notifier_invalidate_range_end() or mmu_notifier_invalidate_range()
> 
> This patch serie just make sure that there is at least a call (outside spinlock
> section) to mmu_notifier_invalidate_range() after mmu_notifier_invalidate_page()
> 
> This fix issue with AMD IOMMU v2 while avoiding to introduce issue for others
> user of the mmu_notifier API. For releavent threads see:
> 
> https://lkml.kernel.org/r/20170809204333.27485-1-jglisse@redhat.com
> https://lkml.kernel.org/r/20170804134928.l4klfcnqatni7vsc@black.fi.intel.com
> https://marc.info/?l=kvm&m=150327081325160&w=2

Please ignore this. Instead plan is to kill invalidate_page() switch
it to invalidate_range() and make sure there is always range_start/
range_end happening around.

Jérôme

  parent reply	other threads:[~2017-08-29 20:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29 20:11 [PATCH 0/4] mmu_notifier semantic update Jérôme Glisse
2017-08-29 20:11 ` Jérôme Glisse
2017-08-29 20:11 ` [PATCH 1/4] mm/mmu_notifier: document new behavior for mmu_notifier_invalidate_page() Jérôme Glisse
2017-08-29 20:11   ` Jérôme Glisse
2017-08-29 20:11 ` [PATCH 2/4] dax/mmu_notifier: update to new mmu_notifier semantic Jérôme Glisse
2017-08-29 20:11   ` Jérôme Glisse
2017-08-29 20:11 ` [PATCH 3/4] mm/rmap: update to new mmu_notifier_invalidate_page() semantic Jérôme Glisse
2017-08-29 20:11   ` Jérôme Glisse
2017-08-29 20:11 ` [PATCH 4/4] iommu/amd: " Jérôme Glisse
2017-08-29 20:11   ` Jérôme Glisse
2017-08-29 20:15 ` Jerome Glisse [this message]
2017-08-29 20:15   ` [PATCH 0/4] mmu_notifier semantic update Jerome Glisse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170829201555.GG7546@redhat.com \
    --to=jglisse@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axie@amd.com \
    --cc=berny156@gmx.de \
    --cc=dan.j.williams@intel.com \
    --cc=efault@gmx.de \
    --cc=kernellwp@gmail.com \
    --cc=kilobyte@angband.pl \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nadav.amit@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=ross.zwisler@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.