From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>,
Amitkumar Karwar <amit.karwar@redpinesignals.com>,
Karun Eagalapati <karun256@gmail.com>,
Johannes Berg <johannes.berg@intel.com>,
Andrew Zaborowski <andrew.zaborowski@intel.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [2/2] rsi: update some comments
Date: Wed, 30 Aug 2017 16:49:38 +0000 [thread overview]
Message-ID: <20170830164938.CBEEF60209@smtp.codeaurora.org> (raw)
In-Reply-To: <20170825084037.gxgsieknkb5hxdfs@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> These functions don't return -1 on failure.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> index 25331aa16e8e..e78e87e99804 100644
> --- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> +++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> @@ -754,7 +754,7 @@ static int rsi_mac80211_conf_tx(struct ieee80211_hw *hw,
> * @vif: Pointer to the ieee80211_vif structure.
> * @key: Pointer to the ieee80211_key_conf structure.
> *
> - * Return: status: 0 on success, -1 on failure.
> + * Return: status: 0 on success, negative error codes on failure.
> */
> static int rsi_hal_key_config(struct ieee80211_hw *hw,
> struct ieee80211_vif *vif,
> @@ -1194,7 +1194,7 @@ static void rsi_set_min_rate(struct ieee80211_hw *hw,
> * @vif: Pointer to the ieee80211_vif structure.
> * @sta: Pointer to the ieee80211_sta structure.
> *
> - * Return: 0 on success, -1 on failure.
> + * Return: 0 on success, negative error codes on failure.
> */
> static int rsi_mac80211_sta_add(struct ieee80211_hw *hw,
> struct ieee80211_vif *vif,
> @@ -1306,7 +1306,7 @@ static int rsi_mac80211_sta_add(struct ieee80211_hw *hw,
> * @vif: Pointer to the ieee80211_vif structure.
> * @sta: Pointer to the ieee80211_sta structure.
> *
> - * Return: 0 on success, -1 on failure.
> + * Return: 0 on success, negative error codes on failure.
> */
> static int rsi_mac80211_sta_remove(struct ieee80211_hw *hw,
> struct ieee80211_vif *vif,
> @@ -1426,7 +1426,7 @@ static int rsi_mac80211_set_antenna(struct ieee80211_hw *hw,
> * @tx_ant: Bitmap for tx antenna
> * @rx_ant: Bitmap for rx antenna
> *
> - * Return: 0 on success, -1 on failure.
> + * Return: 0 on success, negative error codes on failure.
> */
> static int rsi_mac80211_get_antenna(struct ieee80211_hw *hw,
> u32 *tx_ant, u32 *rx_ant)
> @@ -1533,7 +1533,7 @@ static struct ieee80211_ops mac80211_ops = {
> * rsi_mac80211_attach() - This function is used to initialize Mac80211 stack.
> * @common: Pointer to the driver private structure.
> *
> - * Return: 0 on success, -1 on failure.
> + * Return: 0 on success, negative error codes on failure.
> */
> int rsi_mac80211_attach(struct rsi_common *common)
> {
2 patches applied to wireless-drivers-next.git, thanks.
fc4386729491 rsi: update some comments
0270639e899e rsi: missing unlocks on error paths
--
https://patchwork.kernel.org/patch/9921425/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Prameela Rani Garnepudi <prameela.j04cs@gmail.com>,
Amitkumar Karwar <amit.karwar@redpinesignals.com>,
Karun Eagalapati <karun256@gmail.com>,
Johannes Berg <johannes.berg@intel.com>,
Andrew Zaborowski <andrew.zaborowski@intel.com>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [2/2] rsi: update some comments
Date: Wed, 30 Aug 2017 16:49:38 +0000 (UTC) [thread overview]
Message-ID: <20170830164938.CBEEF60209@smtp.codeaurora.org> (raw)
In-Reply-To: <20170825084037.gxgsieknkb5hxdfs@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> These functions don't return -1 on failure.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> index 25331aa16e8e..e78e87e99804 100644
> --- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> +++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
> @@ -754,7 +754,7 @@ static int rsi_mac80211_conf_tx(struct ieee80211_hw *hw,
> * @vif: Pointer to the ieee80211_vif structure.
> * @key: Pointer to the ieee80211_key_conf structure.
> *
> - * Return: status: 0 on success, -1 on failure.
> + * Return: status: 0 on success, negative error codes on failure.
> */
> static int rsi_hal_key_config(struct ieee80211_hw *hw,
> struct ieee80211_vif *vif,
> @@ -1194,7 +1194,7 @@ static void rsi_set_min_rate(struct ieee80211_hw *hw,
> * @vif: Pointer to the ieee80211_vif structure.
> * @sta: Pointer to the ieee80211_sta structure.
> *
> - * Return: 0 on success, -1 on failure.
> + * Return: 0 on success, negative error codes on failure.
> */
> static int rsi_mac80211_sta_add(struct ieee80211_hw *hw,
> struct ieee80211_vif *vif,
> @@ -1306,7 +1306,7 @@ static int rsi_mac80211_sta_add(struct ieee80211_hw *hw,
> * @vif: Pointer to the ieee80211_vif structure.
> * @sta: Pointer to the ieee80211_sta structure.
> *
> - * Return: 0 on success, -1 on failure.
> + * Return: 0 on success, negative error codes on failure.
> */
> static int rsi_mac80211_sta_remove(struct ieee80211_hw *hw,
> struct ieee80211_vif *vif,
> @@ -1426,7 +1426,7 @@ static int rsi_mac80211_set_antenna(struct ieee80211_hw *hw,
> * @tx_ant: Bitmap for tx antenna
> * @rx_ant: Bitmap for rx antenna
> *
> - * Return: 0 on success, -1 on failure.
> + * Return: 0 on success, negative error codes on failure.
> */
> static int rsi_mac80211_get_antenna(struct ieee80211_hw *hw,
> u32 *tx_ant, u32 *rx_ant)
> @@ -1533,7 +1533,7 @@ static struct ieee80211_ops mac80211_ops = {
> * rsi_mac80211_attach() - This function is used to initialize Mac80211 stack.
> * @common: Pointer to the driver private structure.
> *
> - * Return: 0 on success, -1 on failure.
> + * Return: 0 on success, negative error codes on failure.
> */
> int rsi_mac80211_attach(struct rsi_common *common)
> {
2 patches applied to wireless-drivers-next.git, thanks.
fc4386729491 rsi: update some comments
0270639e899e rsi: missing unlocks on error paths
--
https://patchwork.kernel.org/patch/9921425/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-08-30 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 8:43 [PATCH 1/2] rsi: missing unlocks on error paths Dan Carpenter
2017-08-25 8:43 ` Dan Carpenter
2017-08-25 8:40 ` [PATCH 2/2] rsi: update some comments Dan Carpenter
2017-08-25 8:40 ` Dan Carpenter
2017-08-30 16:49 ` Kalle Valo [this message]
2017-08-30 16:49 ` [2/2] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830164938.CBEEF60209@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amit.karwar@redpinesignals.com \
--cc=andrew.zaborowski@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=johannes.berg@intel.com \
--cc=karun256@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=prameela.j04cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.