All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	fstests@vger.kernel.org, Eryu Guan <eguan@redhat.com>,
	linux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org,
	linux-fsdevel@vger.kernel.org, Randy Dodgen <rdodgen@gmail.com>,
	Theodore Ts'o <tytso@mit.edu>
Subject: Re: [fstests PATCH] generic: add test for executables on read-only DAX mounts
Date: Wed, 30 Aug 2017 22:02:55 -0600	[thread overview]
Message-ID: <20170831040255.GB17095@linux.intel.com> (raw)
In-Reply-To: <20170830145103.GA10163@infradead.org>

On Wed, Aug 30, 2017 at 07:51:03AM -0700, Christoph Hellwig wrote:
> > The above patch fixes an issue with ext4 where executables cannot be run on
> > read-only filesystems mounted with the DAX option.
> > 
> > This issue does not appear to be present in ext2 or XFS, as they both pass
> > the test.  I've also confirmed outside of the test that they are both
> > indeed able to execute binaries on read-only DAX mounts.
> 
> It works for me on XFS.  But I don't really understand why, as the fault
> handler doesn't look very different.
> 
> Maybe the problem is that in ext4_journal_start_sb will fail on
> a read-only fs?
> 
> Even for xfs/ext2 it would seem odd that things like sb_start_pagefault
> just work. 
> 
> > +LS=$(which ls --skip-alias --skip-functions) 2>/dev/null
> > +if [ $? -ne 0 ]; then
> > +	status=$?
> > +	echo "Couldn't find 'ls'!?"
> > +	exit
> > +fi
> 
> These checks all fail for me..

Huh...really?  I'll send out v2 in a second, but if that fails for you as well
can you try and give me a hint as to what's going wrong with the test in your
setup?

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>,
	Eryu Guan <eguan-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
	Randy Dodgen <rdodgen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	fstests-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [fstests PATCH] generic: add test for executables on read-only DAX mounts
Date: Wed, 30 Aug 2017 22:02:55 -0600	[thread overview]
Message-ID: <20170831040255.GB17095@linux.intel.com> (raw)
In-Reply-To: <20170830145103.GA10163-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>

On Wed, Aug 30, 2017 at 07:51:03AM -0700, Christoph Hellwig wrote:
> > The above patch fixes an issue with ext4 where executables cannot be run on
> > read-only filesystems mounted with the DAX option.
> > 
> > This issue does not appear to be present in ext2 or XFS, as they both pass
> > the test.  I've also confirmed outside of the test that they are both
> > indeed able to execute binaries on read-only DAX mounts.
> 
> It works for me on XFS.  But I don't really understand why, as the fault
> handler doesn't look very different.
> 
> Maybe the problem is that in ext4_journal_start_sb will fail on
> a read-only fs?
> 
> Even for xfs/ext2 it would seem odd that things like sb_start_pagefault
> just work. 
> 
> > +LS=$(which ls --skip-alias --skip-functions) 2>/dev/null
> > +if [ $? -ne 0 ]; then
> > +	status=$?
> > +	echo "Couldn't find 'ls'!?"
> > +	exit
> > +fi
> 
> These checks all fail for me..

Huh...really?  I'll send out v2 in a second, but if that fails for you as well
can you try and give me a hint as to what's going wrong with the test in your
setup?

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Theodore Ts'o <tytso@mit.edu>, Eryu Guan <eguan@redhat.com>,
	linux-nvdimm@lists.01.org, Randy Dodgen <rdodgen@gmail.com>,
	fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-ext4@vger.kernel.org
Subject: Re: [fstests PATCH] generic: add test for executables on read-only DAX mounts
Date: Wed, 30 Aug 2017 22:02:55 -0600	[thread overview]
Message-ID: <20170831040255.GB17095@linux.intel.com> (raw)
In-Reply-To: <20170830145103.GA10163@infradead.org>

On Wed, Aug 30, 2017 at 07:51:03AM -0700, Christoph Hellwig wrote:
> > The above patch fixes an issue with ext4 where executables cannot be run on
> > read-only filesystems mounted with the DAX option.
> > 
> > This issue does not appear to be present in ext2 or XFS, as they both pass
> > the test.  I've also confirmed outside of the test that they are both
> > indeed able to execute binaries on read-only DAX mounts.
> 
> It works for me on XFS.  But I don't really understand why, as the fault
> handler doesn't look very different.
> 
> Maybe the problem is that in ext4_journal_start_sb will fail on
> a read-only fs?
> 
> Even for xfs/ext2 it would seem odd that things like sb_start_pagefault
> just work. 
> 
> > +LS=$(which ls --skip-alias --skip-functions) 2>/dev/null
> > +if [ $? -ne 0 ]; then
> > +	status=$?
> > +	echo "Couldn't find 'ls'!?"
> > +	exit
> > +fi
> 
> These checks all fail for me..

Huh...really?  I'll send out v2 in a second, but if that fails for you as well
can you try and give me a hint as to what's going wrong with the test in your
setup?
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  reply	other threads:[~2017-08-31  4:03 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-22 22:24 [PATCH] Fix ext4 fault handling when mounted with -o dax,ro Randy Dodgen
2017-08-23  3:37 ` [PATCH v2] " rdodgen
2017-08-23  3:37   ` rdodgen
     [not found]   ` <bea6897723e5bf09d893b2ca40263a894a284a5a.1503459187.git.dodgen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-08-23 16:38     ` Ross Zwisler
2017-08-23 16:38       ` Ross Zwisler
2017-08-23 20:11       ` Randy Dodgen
2017-08-23 20:11         ` Randy Dodgen
2017-08-23 21:26         ` [PATCH v3] " rdodgen
2017-08-23 21:26           ` rdodgen
     [not found]           ` <416a465a9fbe1d27085883dbf652c115cd195697.1503523424.git.dodgen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-08-24 14:45             ` Jan Kara
2017-08-24 14:45               ` Jan Kara
2017-08-24 15:11             ` Ross Zwisler
2017-08-24 15:11               ` Ross Zwisler
2017-08-24 16:01             ` Christoph Hellwig
2017-08-24 16:01               ` Christoph Hellwig
     [not found]               ` <20170824160144.GA14287-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-08-24 20:57                 ` Theodore Ts'o
2017-08-24 20:57                   ` Theodore Ts'o
2017-08-25  7:28                   ` Christoph Hellwig
2017-08-25  7:28                     ` Christoph Hellwig
2017-08-29 21:20               ` Christoph Hellwig
2017-08-29 21:20                 ` Christoph Hellwig
     [not found]                 ` <20170829212002.GA2154-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-08-29 21:37                   ` Ross Zwisler
2017-08-29 21:37                     ` Ross Zwisler
     [not found]                     ` <20170829213721.GA27686-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-08-29 22:07                       ` Randy Dodgen
2017-08-29 22:07                         ` Randy Dodgen
2017-08-29 22:37                     ` [fstests PATCH] generic: add test for executables on read-only DAX mounts Ross Zwisler
2017-08-29 22:37                       ` Ross Zwisler
2017-08-30 10:59                       ` Eryu Guan
2017-08-30 10:59                         ` Eryu Guan
2017-08-31  4:01                         ` Ross Zwisler
2017-08-31  4:01                           ` Ross Zwisler
2017-08-31  4:01                           ` Ross Zwisler
2017-08-31  4:09                         ` [fstests v2] " Ross Zwisler
2017-08-31  4:09                           ` Ross Zwisler
2017-08-30 14:51                       ` [fstests PATCH] " Christoph Hellwig
2017-08-30 14:51                         ` Christoph Hellwig
2017-08-30 14:51                         ` Christoph Hellwig
2017-08-31  4:02                         ` Ross Zwisler [this message]
2017-08-31  4:02                           ` Ross Zwisler
2017-08-31  4:02                           ` Ross Zwisler
2017-08-31 13:09                           ` Christoph Hellwig
2017-08-31 13:09                             ` Christoph Hellwig
2017-08-24 19:26             ` [PATCH v3] Fix ext4 fault handling when mounted with -o dax,ro Theodore Ts'o
2017-08-24 19:26               ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170831040255.GB17095@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=rdodgen@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.