From: Tony Lindgren <tony@atomide.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Timur Tabi <timur@codeaurora.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux-OMAP <linux-omap@vger.kernel.org>
Subject: Re: Regression in next with gpiolib
Date: Thu, 31 Aug 2017 07:02:21 -0700 [thread overview]
Message-ID: <20170831140221.GK6008@atomide.com> (raw)
In-Reply-To: <CACRpkdYUd2+FjhL_koEYjJXnci+khSOM9H6ahpXnzJoiYFCJdQ@mail.gmail.com>
* Linus Walleij <linus.walleij@linaro.org> [170830 22:59]:
> On Wed, Aug 30, 2017 at 11:41 PM, Tony Lindgren <tony@atomide.com> wrote:
>
> > Hi Timur, Linus & Grygorii,
> >
> > Looks like commit 108d23e322a2 ("gpiolib: request the gpio before
> > querying its direction") caused a regression on at least pandaboard
> > es with booting hanging shortly after gpio init.
> >
> > It seems to be that we're now calling request and free on all gpios
> > before they are properly configured?
> >
> > I narrowed the hang down to gpio bank1 lines 7 and possibly 8 where
> > not calling omap_gpio_free() on them makes the system boot again.
> >
> > These lines are used for the leds in omap4-panda-common.dtsi, and
> > omap_gpio_free() will by default set the unused lines for input
> > and bad things happen. I guess hardware failure could also happen
> > although I have not seen it here.
> >
> > It seems a similar issue can exist on other platforms too,
> > so it's probably a good idea to revert this for now.
>
> I reverted it for now.
OK thanks!
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: Regression in next with gpiolib
Date: Thu, 31 Aug 2017 07:02:21 -0700 [thread overview]
Message-ID: <20170831140221.GK6008@atomide.com> (raw)
In-Reply-To: <CACRpkdYUd2+FjhL_koEYjJXnci+khSOM9H6ahpXnzJoiYFCJdQ@mail.gmail.com>
* Linus Walleij <linus.walleij@linaro.org> [170830 22:59]:
> On Wed, Aug 30, 2017 at 11:41 PM, Tony Lindgren <tony@atomide.com> wrote:
>
> > Hi Timur, Linus & Grygorii,
> >
> > Looks like commit 108d23e322a2 ("gpiolib: request the gpio before
> > querying its direction") caused a regression on at least pandaboard
> > es with booting hanging shortly after gpio init.
> >
> > It seems to be that we're now calling request and free on all gpios
> > before they are properly configured?
> >
> > I narrowed the hang down to gpio bank1 lines 7 and possibly 8 where
> > not calling omap_gpio_free() on them makes the system boot again.
> >
> > These lines are used for the leds in omap4-panda-common.dtsi, and
> > omap_gpio_free() will by default set the unused lines for input
> > and bad things happen. I guess hardware failure could also happen
> > although I have not seen it here.
> >
> > It seems a similar issue can exist on other platforms too,
> > so it's probably a good idea to revert this for now.
>
> I reverted it for now.
OK thanks!
Tony
next prev parent reply other threads:[~2017-08-31 14:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 21:41 Regression in next with gpiolib Tony Lindgren
2017-08-30 21:41 ` Tony Lindgren
2017-08-30 21:49 ` Timur Tabi
2017-08-30 21:49 ` Timur Tabi
2017-08-31 5:59 ` Linus Walleij
2017-08-31 5:59 ` Linus Walleij
2017-08-31 14:02 ` Tony Lindgren [this message]
2017-08-31 14:02 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831140221.GK6008@atomide.com \
--to=tony@atomide.com \
--cc=grygorii.strashko@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.