From: Jesper Dangaard Brouer <brouer@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: andrew@lunn.ch, f.fainelli@gmail.com,
nikolay@cumulusnetworks.com, netdev@vger.kernel.org,
roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org,
brouer@redhat.com
Subject: Re: [Bridge] [PATCH net-next] bridge: add tracepoint in br_fdb_update
Date: Thu, 31 Aug 2017 21:50:34 -0000 [thread overview]
Message-ID: <20170831235026.6377bf86@redhat.com> (raw)
In-Reply-To: <20170831.114325.2027598728601121750.davem@davemloft.net>
On Thu, 31 Aug 2017 11:43:25 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> Date: Wed, 30 Aug 2017 22:18:13 -0700
>
> > From: Roopa Prabhu <roopa@cumulusnetworks.com>
> >
> > This extends bridge fdb table tracepoints to also cover
> > learned fdb entries in the br_fdb_update path. Note that
> > unlike other tracepoints I have moved this to when the fdb
> > is modified because this is in the datapath and can generate
> > a lot of noise in the trace output. br_fdb_update is also called
> > from added_by_user context in the NTF_USE case which is already
> > traced ..hence the !added_by_user check.
> >
> > Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> Applied.
>
> Let's use dev->name for now and if the tooling can eventually
> do transparent ifindex->name then we can consider redoing
> a bunch of networking tracepoints.
I agree! :-)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
WARNING: multiple messages have this Message-ID (diff)
From: Jesper Dangaard Brouer <brouer@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: brouer@redhat.com, roopa@cumulusnetworks.com,
netdev@vger.kernel.org, nikolay@cumulusnetworks.com,
f.fainelli@gmail.com, andrew@lunn.ch,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next] bridge: add tracepoint in br_fdb_update
Date: Thu, 31 Aug 2017 23:50:26 +0200 [thread overview]
Message-ID: <20170831235026.6377bf86@redhat.com> (raw)
In-Reply-To: <20170831.114325.2027598728601121750.davem@davemloft.net>
On Thu, 31 Aug 2017 11:43:25 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
> Date: Wed, 30 Aug 2017 22:18:13 -0700
>
> > From: Roopa Prabhu <roopa@cumulusnetworks.com>
> >
> > This extends bridge fdb table tracepoints to also cover
> > learned fdb entries in the br_fdb_update path. Note that
> > unlike other tracepoints I have moved this to when the fdb
> > is modified because this is in the datapath and can generate
> > a lot of noise in the trace output. br_fdb_update is also called
> > from added_by_user context in the NTF_USE case which is already
> > traced ..hence the !added_by_user check.
> >
> > Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> Applied.
>
> Let's use dev->name for now and if the tooling can eventually
> do transparent ifindex->name then we can consider redoing
> a bunch of networking tracepoints.
I agree! :-)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2017-08-31 21:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 5:18 [Bridge] [PATCH net-next] bridge: add tracepoint in br_fdb_update Roopa Prabhu
2017-08-31 5:18 ` Roopa Prabhu
2017-08-31 12:38 ` Jesper Dangaard Brouer
2017-08-31 12:38 ` [Bridge] " Jesper Dangaard Brouer
2017-08-31 15:21 ` Roopa Prabhu
2017-08-31 15:21 ` Roopa Prabhu
2017-08-31 15:30 ` [Bridge] " David Ahern
2017-08-31 15:30 ` David Ahern
2017-08-31 16:20 ` Jesper Dangaard Brouer
2017-08-31 16:20 ` [Bridge] " Jesper Dangaard Brouer
2017-08-31 18:56 ` Arnaldo Carvalho de Melo
2017-08-31 18:57 ` [Bridge] " Arnaldo Carvalho de Melo
2017-08-31 14:19 ` Nikolay Aleksandrov
2017-08-31 14:19 ` Nikolay Aleksandrov
2017-08-31 18:43 ` [Bridge] " David Miller
2017-08-31 18:43 ` David Miller
2017-08-31 21:50 ` Jesper Dangaard Brouer [this message]
2017-08-31 21:50 ` [Bridge] " Jesper Dangaard Brouer
2017-08-31 22:43 ` Stephen Hemminger
2017-08-31 22:43 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831235026.6377bf86@redhat.com \
--to=brouer@redhat.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.