From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Shaohua Li <shli@fb.com>,
linux-block@vger.kernel.org, Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL
Date: Fri, 01 Sep 2017 05:07:30 +0000 [thread overview]
Message-ID: <20170901050730.GA2584@kroah.com> (raw)
In-Reply-To: <26406dc8-2bdc-7bd3-7cd9-7e63986a8769@kernel.dk>
On Thu, Aug 31, 2017 at 01:56:40PM -0600, Jens Axboe wrote:
> On 08/31/2017 10:52 AM, Greg Kroah-Hartman wrote:
> > On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote:
> >> The kernfs_get_inode() returns NULL on error, it never returns error
> >> pointers.
> >>
> >> Fixes: aa8188253474 ("kernfs: add exportfs operations")
> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >> Acked-by: Tejun Heo <tj@kernel.org>
> >
> > Hm, I don't know what tree aa8188253474 is in, but it's not mine, so I
> > can't take this patch :(
>
> It's in my tree, I'll take it. Can I add your
> acked/reviewed/whatever-by?
Yes:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Shaohua Li <shli@fb.com>,
linux-block@vger.kernel.org, Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] kernfs: checking for IS_ERR() instead of NULL
Date: Fri, 1 Sep 2017 07:07:30 +0200 [thread overview]
Message-ID: <20170901050730.GA2584@kroah.com> (raw)
In-Reply-To: <26406dc8-2bdc-7bd3-7cd9-7e63986a8769@kernel.dk>
On Thu, Aug 31, 2017 at 01:56:40PM -0600, Jens Axboe wrote:
> On 08/31/2017 10:52 AM, Greg Kroah-Hartman wrote:
> > On Wed, Aug 30, 2017 at 05:04:56PM +0300, Dan Carpenter wrote:
> >> The kernfs_get_inode() returns NULL on error, it never returns error
> >> pointers.
> >>
> >> Fixes: aa8188253474 ("kernfs: add exportfs operations")
> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >> Acked-by: Tejun Heo <tj@kernel.org>
> >
> > Hm, I don't know what tree aa8188253474 is in, but it's not mine, so I
> > can't take this patch :(
>
> It's in my tree, I'll take it. Can I add your
> acked/reviewed/whatever-by?
Yes:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2017-09-01 5:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 14:04 [PATCH] kernfs: checking for IS_ERR() instead of NULL Dan Carpenter
2017-08-30 14:04 ` Dan Carpenter
2017-08-31 0:39 ` Tejun Heo
2017-08-31 0:39 ` Tejun Heo
2017-08-31 16:52 ` Greg Kroah-Hartman
2017-08-31 16:52 ` Greg Kroah-Hartman
2017-08-31 19:56 ` Jens Axboe
2017-08-31 19:56 ` Jens Axboe
2017-09-01 5:07 ` Greg Kroah-Hartman [this message]
2017-09-01 5:07 ` Greg Kroah-Hartman
2017-09-01 14:19 ` Jens Axboe
2017-09-01 14:19 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901050730.GA2584@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fb.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.