From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines
Date: Fri, 1 Sep 2017 19:00:52 +0300 [thread overview]
Message-ID: <20170901160052.GZ4914@intel.com> (raw)
In-Reply-To: <20170901144430.19164-1-thierry.reding@gmail.com>
On Fri, Sep 01, 2017 at 04:44:28PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> It's unusual to separate kerneldoc comments from the functions that they
> describe by a blank line. Remove them.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Series lgtm
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_scdc_helper.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c
> index 935653eb3616..d66c436a829e 100644
> --- a/drivers/gpu/drm/drm_scdc_helper.c
> +++ b/drivers/gpu/drm/drm_scdc_helper.c
> @@ -134,7 +134,6 @@ EXPORT_SYMBOL(drm_scdc_write);
> * Returns:
> * True if the scrambling is enabled, false otherwise.
> */
> -
> bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter)
> {
> u8 status;
> @@ -162,7 +161,6 @@ EXPORT_SYMBOL(drm_scdc_get_scrambling_status);
> * Returns:
> * True if scrambling is set/reset successfully, false otherwise.
> */
> -
> bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable)
> {
> u8 config;
> --
> 2.13.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-09-01 16:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 14:44 [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines Thierry Reding
2017-09-01 14:44 ` [PATCH 2/3] drm/scdc-helper: Use consistent error reporting Thierry Reding
2017-09-04 9:14 ` Sharma, Shashank
2017-09-01 14:44 ` [PATCH 3/3] drm/scdc-helper: Use consistent spelling for TMDS Thierry Reding
2017-09-04 9:16 ` Sharma, Shashank
2017-09-01 16:00 ` Ville Syrjälä [this message]
2017-09-01 19:03 ` [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines Thierry Reding
2017-09-04 9:13 ` Sharma, Shashank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901160052.GZ4914@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.