* [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines
@ 2017-09-01 14:44 Thierry Reding
2017-09-01 14:44 ` [PATCH 2/3] drm/scdc-helper: Use consistent error reporting Thierry Reding
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Thierry Reding @ 2017-09-01 14:44 UTC (permalink / raw)
To: dri-devel
From: Thierry Reding <treding@nvidia.com>
It's unusual to separate kerneldoc comments from the functions that they
describe by a blank line. Remove them.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/gpu/drm/drm_scdc_helper.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c
index 935653eb3616..d66c436a829e 100644
--- a/drivers/gpu/drm/drm_scdc_helper.c
+++ b/drivers/gpu/drm/drm_scdc_helper.c
@@ -134,7 +134,6 @@ EXPORT_SYMBOL(drm_scdc_write);
* Returns:
* True if the scrambling is enabled, false otherwise.
*/
-
bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter)
{
u8 status;
@@ -162,7 +161,6 @@ EXPORT_SYMBOL(drm_scdc_get_scrambling_status);
* Returns:
* True if scrambling is set/reset successfully, false otherwise.
*/
-
bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable)
{
u8 config;
--
2.13.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/3] drm/scdc-helper: Use consistent error reporting 2017-09-01 14:44 [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines Thierry Reding @ 2017-09-01 14:44 ` Thierry Reding 2017-09-04 9:14 ` Sharma, Shashank 2017-09-01 14:44 ` [PATCH 3/3] drm/scdc-helper: Use consistent spelling for TMDS Thierry Reding ` (2 subsequent siblings) 3 siblings, 1 reply; 8+ messages in thread From: Thierry Reding @ 2017-09-01 14:44 UTC (permalink / raw) To: dri-devel From: Thierry Reding <treding@nvidia.com> The error messages generated by the SCDC helpers are somewhat inconsistent with other DRM errors and even with other errors in the same file. Fix them all up to use a common format. Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/gpu/drm/drm_scdc_helper.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c index d66c436a829e..5e6f0709df49 100644 --- a/drivers/gpu/drm/drm_scdc_helper.c +++ b/drivers/gpu/drm/drm_scdc_helper.c @@ -141,7 +141,7 @@ bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) ret = drm_scdc_readb(adapter, SCDC_SCRAMBLER_STATUS, &status); if (ret < 0) { - DRM_ERROR("Failed to read scrambling status, error %d\n", ret); + DRM_ERROR("Failed to read scrambling status: %d\n", ret); return false; } @@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); if (ret < 0) { - DRM_ERROR("Failed to read tmds config, err=%d\n", ret); + DRM_ERROR("Failed to read tmds config: %d\n", ret); return false; } @@ -179,7 +179,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); if (ret < 0) { - DRM_ERROR("Failed to enable scrambling, error %d\n", ret); + DRM_ERROR("Failed to enable scrambling: %d\n", ret); return false; } @@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); if (ret < 0) { - DRM_ERROR("Failed to read tmds config, err=%d\n", ret); + DRM_ERROR("Failed to read tmds config: %d\n", ret); return false; } @@ -234,7 +234,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); if (ret < 0) { - DRM_ERROR("Failed to set TMDS clock ratio, error %d\n", ret); + DRM_ERROR("Failed to set TMDS clock ratio: %d\n", ret); return false; } -- 2.13.3 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] drm/scdc-helper: Use consistent error reporting 2017-09-01 14:44 ` [PATCH 2/3] drm/scdc-helper: Use consistent error reporting Thierry Reding @ 2017-09-04 9:14 ` Sharma, Shashank 0 siblings, 0 replies; 8+ messages in thread From: Sharma, Shashank @ 2017-09-04 9:14 UTC (permalink / raw) To: Thierry Reding, dri-devel Regards Shashank On 9/1/2017 8:14 PM, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > The error messages generated by the SCDC helpers are somewhat > inconsistent with other DRM errors and even with other errors in the > same file. Fix them all up to use a common format. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/gpu/drm/drm_scdc_helper.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c > index d66c436a829e..5e6f0709df49 100644 > --- a/drivers/gpu/drm/drm_scdc_helper.c > +++ b/drivers/gpu/drm/drm_scdc_helper.c > @@ -141,7 +141,7 @@ bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) > > ret = drm_scdc_readb(adapter, SCDC_SCRAMBLER_STATUS, &status); > if (ret < 0) { > - DRM_ERROR("Failed to read scrambling status, error %d\n", ret); > + DRM_ERROR("Failed to read scrambling status: %d\n", ret); > return false; > } > > @@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) > > ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); > if (ret < 0) { > - DRM_ERROR("Failed to read tmds config, err=%d\n", ret); > + DRM_ERROR("Failed to read tmds config: %d\n", ret); > return false; > } > > @@ -179,7 +179,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) > > ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); > if (ret < 0) { > - DRM_ERROR("Failed to enable scrambling, error %d\n", ret); > + DRM_ERROR("Failed to enable scrambling: %d\n", ret); > return false; > } > > @@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) > > ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); > if (ret < 0) { > - DRM_ERROR("Failed to read tmds config, err=%d\n", ret); > + DRM_ERROR("Failed to read tmds config: %d\n", ret); > return false; > } > > @@ -234,7 +234,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) > > ret = drm_scdc_writeb(adapter, SCDC_TMDS_CONFIG, config); > if (ret < 0) { > - DRM_ERROR("Failed to set TMDS clock ratio, error %d\n", ret); > + DRM_ERROR("Failed to set TMDS clock ratio: %d\n", ret); > return false; > } > Reviewed-by: Shashank Sharma <shashank.sharma@intel.com> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 3/3] drm/scdc-helper: Use consistent spelling for TMDS 2017-09-01 14:44 [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines Thierry Reding 2017-09-01 14:44 ` [PATCH 2/3] drm/scdc-helper: Use consistent error reporting Thierry Reding @ 2017-09-01 14:44 ` Thierry Reding 2017-09-04 9:16 ` Sharma, Shashank 2017-09-01 16:00 ` [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines Ville Syrjälä 2017-09-04 9:13 ` Sharma, Shashank 3 siblings, 1 reply; 8+ messages in thread From: Thierry Reding @ 2017-09-01 14:44 UTC (permalink / raw) To: dri-devel From: Thierry Reding <treding@nvidia.com> The file uses inconsistent capitalization for TMDS. Since it is an abbreviation, all uppercase is correct. Signed-off-by: Thierry Reding <treding@nvidia.com> --- drivers/gpu/drm/drm_scdc_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c index 5e6f0709df49..657ea5ab6c3f 100644 --- a/drivers/gpu/drm/drm_scdc_helper.c +++ b/drivers/gpu/drm/drm_scdc_helper.c @@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); if (ret < 0) { - DRM_ERROR("Failed to read tmds config: %d\n", ret); + DRM_ERROR("Failed to read TMDS config: %d\n", ret); return false; } @@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); if (ret < 0) { - DRM_ERROR("Failed to read tmds config: %d\n", ret); + DRM_ERROR("Failed to read TMDS config: %d\n", ret); return false; } -- 2.13.3 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] drm/scdc-helper: Use consistent spelling for TMDS 2017-09-01 14:44 ` [PATCH 3/3] drm/scdc-helper: Use consistent spelling for TMDS Thierry Reding @ 2017-09-04 9:16 ` Sharma, Shashank 0 siblings, 0 replies; 8+ messages in thread From: Sharma, Shashank @ 2017-09-04 9:16 UTC (permalink / raw) To: Thierry Reding, dri-devel Reviewed-by: Shashank Sharma <shashank.sharma@intel.com> Regards Shashank On 9/1/2017 8:14 PM, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > The file uses inconsistent capitalization for TMDS. Since it is an > abbreviation, all uppercase is correct. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/gpu/drm/drm_scdc_helper.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c > index 5e6f0709df49..657ea5ab6c3f 100644 > --- a/drivers/gpu/drm/drm_scdc_helper.c > +++ b/drivers/gpu/drm/drm_scdc_helper.c > @@ -168,7 +168,7 @@ bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) > > ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); > if (ret < 0) { > - DRM_ERROR("Failed to read tmds config: %d\n", ret); > + DRM_ERROR("Failed to read TMDS config: %d\n", ret); > return false; > } > > @@ -223,7 +223,7 @@ bool drm_scdc_set_high_tmds_clock_ratio(struct i2c_adapter *adapter, bool set) > > ret = drm_scdc_readb(adapter, SCDC_TMDS_CONFIG, &config); > if (ret < 0) { > - DRM_ERROR("Failed to read tmds config: %d\n", ret); > + DRM_ERROR("Failed to read TMDS config: %d\n", ret); > return false; > } > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines 2017-09-01 14:44 [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines Thierry Reding 2017-09-01 14:44 ` [PATCH 2/3] drm/scdc-helper: Use consistent error reporting Thierry Reding 2017-09-01 14:44 ` [PATCH 3/3] drm/scdc-helper: Use consistent spelling for TMDS Thierry Reding @ 2017-09-01 16:00 ` Ville Syrjälä 2017-09-01 19:03 ` Thierry Reding 2017-09-04 9:13 ` Sharma, Shashank 3 siblings, 1 reply; 8+ messages in thread From: Ville Syrjälä @ 2017-09-01 16:00 UTC (permalink / raw) To: Thierry Reding; +Cc: dri-devel On Fri, Sep 01, 2017 at 04:44:28PM +0200, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > It's unusual to separate kerneldoc comments from the functions that they > describe by a blank line. Remove them. > > Signed-off-by: Thierry Reding <treding@nvidia.com> Series lgtm Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/gpu/drm/drm_scdc_helper.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c > index 935653eb3616..d66c436a829e 100644 > --- a/drivers/gpu/drm/drm_scdc_helper.c > +++ b/drivers/gpu/drm/drm_scdc_helper.c > @@ -134,7 +134,6 @@ EXPORT_SYMBOL(drm_scdc_write); > * Returns: > * True if the scrambling is enabled, false otherwise. > */ > - > bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) > { > u8 status; > @@ -162,7 +161,6 @@ EXPORT_SYMBOL(drm_scdc_get_scrambling_status); > * Returns: > * True if scrambling is set/reset successfully, false otherwise. > */ > - > bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) > { > u8 config; > -- > 2.13.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines 2017-09-01 16:00 ` [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines Ville Syrjälä @ 2017-09-01 19:03 ` Thierry Reding 0 siblings, 0 replies; 8+ messages in thread From: Thierry Reding @ 2017-09-01 19:03 UTC (permalink / raw) To: Ville Syrjälä; +Cc: dri-devel [-- Attachment #1.1: Type: text/plain, Size: 501 bytes --] On Fri, Sep 01, 2017 at 07:00:52PM +0300, Ville Syrjälä wrote: > On Fri, Sep 01, 2017 at 04:44:28PM +0200, Thierry Reding wrote: > > From: Thierry Reding <treding@nvidia.com> > > > > It's unusual to separate kerneldoc comments from the functions that they > > describe by a blank line. Remove them. > > > > Signed-off-by: Thierry Reding <treding@nvidia.com> > > Series lgtm > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Applied to drm-misc-next, thanks. Thierry [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines 2017-09-01 14:44 [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines Thierry Reding ` (2 preceding siblings ...) 2017-09-01 16:00 ` [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines Ville Syrjälä @ 2017-09-04 9:13 ` Sharma, Shashank 3 siblings, 0 replies; 8+ messages in thread From: Sharma, Shashank @ 2017-09-04 9:13 UTC (permalink / raw) To: Thierry Reding, dri-devel Regards Shashank On 9/1/2017 8:14 PM, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > It's unusual to separate kerneldoc comments from the functions that they > describe by a blank line. Remove them. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/gpu/drm/drm_scdc_helper.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_scdc_helper.c b/drivers/gpu/drm/drm_scdc_helper.c > index 935653eb3616..d66c436a829e 100644 > --- a/drivers/gpu/drm/drm_scdc_helper.c > +++ b/drivers/gpu/drm/drm_scdc_helper.c > @@ -134,7 +134,6 @@ EXPORT_SYMBOL(drm_scdc_write); > * Returns: > * True if the scrambling is enabled, false otherwise. > */ > - > bool drm_scdc_get_scrambling_status(struct i2c_adapter *adapter) > { > u8 status; > @@ -162,7 +161,6 @@ EXPORT_SYMBOL(drm_scdc_get_scrambling_status); > * Returns: > * True if scrambling is set/reset successfully, false otherwise. > */ > - > bool drm_scdc_set_scrambling(struct i2c_adapter *adapter, bool enable) > { > u8 config; Thanks for the fix Reviewed-by: Shashank Sharma <shashank.sharma@intel.com> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-09-04 9:16 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-09-01 14:44 [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines Thierry Reding 2017-09-01 14:44 ` [PATCH 2/3] drm/scdc-helper: Use consistent error reporting Thierry Reding 2017-09-04 9:14 ` Sharma, Shashank 2017-09-01 14:44 ` [PATCH 3/3] drm/scdc-helper: Use consistent spelling for TMDS Thierry Reding 2017-09-04 9:16 ` Sharma, Shashank 2017-09-01 16:00 ` [PATCH 1/3] drm/scdc-helper: Remove gratuitous blank lines Ville Syrjälä 2017-09-01 19:03 ` Thierry Reding 2017-09-04 9:13 ` Sharma, Shashank
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.