From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/10] dmaengine: sun6i: Move number of pchans/vchans/request to device struct
Date: Mon, 4 Sep 2017 09:43:55 +0200 [thread overview]
Message-ID: <20170904074355.niloziky42aki7bg@flea> (raw)
In-Reply-To: <20170903224100.17893-6-stefan.bruens@rwth-aachen.de>
On Mon, Sep 04, 2017 at 12:40:56AM +0200, Stefan Br?ns wrote:
> Preparatory patch: If the same compatible is used for different SoCs which
> have a common register layout, but different number of channels, the
> channel count can no longer be stored in the config. Store it in the
> device structure instead.
>
> Signed-off-by: Stefan Br?ns <stefan.bruens@rwth-aachen.de>
As stated already, we already are going to have a different
compatible, and this is not something that will change from one
instance to the other. Having code is therefore:
A) Making the code more complex
B) For no particular reason.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170904/98b6865d/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: "Stefan Brüns" <stefan.bruens-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
Cc: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Code Kipper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Andre Przywara <andre.przywara-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH 05/10] dmaengine: sun6i: Move number of pchans/vchans/request to device struct
Date: Mon, 4 Sep 2017 09:43:55 +0200 [thread overview]
Message-ID: <20170904074355.niloziky42aki7bg@flea> (raw)
In-Reply-To: <20170903224100.17893-6-stefan.bruens-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
On Mon, Sep 04, 2017 at 12:40:56AM +0200, Stefan Brüns wrote:
> Preparatory patch: If the same compatible is used for different SoCs which
> have a common register layout, but different number of channels, the
> channel count can no longer be stored in the config. Store it in the
> device structure instead.
>
> Signed-off-by: Stefan Brüns <stefan.bruens-vA1bhqPz9FBZXbeN9DUtxg@public.gmane.org>
As stated already, we already are going to have a different
compatible, and this is not something that will change from one
instance to the other. Having code is therefore:
A) Making the code more complex
B) For no particular reason.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: "Stefan Brüns" <stefan.bruens@rwth-aachen.de>
Cc: linux-sunxi@googlegroups.com, devicetree@vger.kernel.org,
dmaengine@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
Code Kipper <codekipper@gmail.com>,
Andre Przywara <andre.przywara@arm.com>
Subject: Re: [PATCH 05/10] dmaengine: sun6i: Move number of pchans/vchans/request to device struct
Date: Mon, 4 Sep 2017 09:43:55 +0200 [thread overview]
Message-ID: <20170904074355.niloziky42aki7bg@flea> (raw)
In-Reply-To: <20170903224100.17893-6-stefan.bruens@rwth-aachen.de>
[-- Attachment #1: Type: text/plain, Size: 739 bytes --]
On Mon, Sep 04, 2017 at 12:40:56AM +0200, Stefan Brüns wrote:
> Preparatory patch: If the same compatible is used for different SoCs which
> have a common register layout, but different number of channels, the
> channel count can no longer be stored in the config. Store it in the
> device structure instead.
>
> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
As stated already, we already are going to have a different
compatible, and this is not something that will change from one
instance to the other. Having code is therefore:
A) Making the code more complex
B) For no particular reason.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-09-04 7:43 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 22:40 [PATCH 00/10] dmaengine: sun6i: Fixes for H3/A83T, enable A64 Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-03 22:40 ` [PATCH 01/10] dmaengine: sun6i: Correct setting of clock autogating register for A83T/H3 Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-03 23:23 ` André Przywara
2017-09-03 23:23 ` André Przywara
2017-09-04 7:06 ` Maxime Ripard
2017-09-04 7:06 ` Maxime Ripard
2017-09-04 7:06 ` Maxime Ripard
2017-09-03 22:40 ` [PATCH 02/10] dmaengine: sun6i: Correct burst length field offsets for H3 Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-04 7:59 ` Maxime Ripard
2017-09-04 7:59 ` Maxime Ripard
2017-09-04 7:59 ` Maxime Ripard
2017-09-04 14:47 ` Brüns, Stefan
2017-09-04 14:47 ` Brüns, Stefan
2017-09-04 14:47 ` Brüns, Stefan
2017-09-03 22:40 ` [PATCH 03/10] dmaengine: sun6i: Restructure code to allow extension for new SoCs Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-03 22:40 ` [PATCH 04/10] dmaengine: sun6i: Enable additional burst lengths/widths on H3 Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-04 8:00 ` Maxime Ripard
2017-09-04 8:00 ` Maxime Ripard
2017-09-04 8:00 ` Maxime Ripard
2017-09-03 22:40 ` [PATCH 05/10] dmaengine: sun6i: Move number of pchans/vchans/request to device struct Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-04 7:43 ` Maxime Ripard [this message]
2017-09-04 7:43 ` Maxime Ripard
2017-09-04 7:43 ` Maxime Ripard
2017-09-04 14:30 ` Brüns, Stefan
2017-09-04 14:30 ` Brüns, Stefan
2017-09-04 14:30 ` Brüns, Stefan
2017-09-08 14:37 ` Maxime Ripard
2017-09-08 14:37 ` Maxime Ripard
2017-09-08 14:37 ` Maxime Ripard
2017-09-03 22:40 ` [PATCH 06/10] arm64: allwinner: a64: Add devicetree binding for DMA controller Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-12 16:52 ` Rob Herring
2017-09-12 16:52 ` Rob Herring
2017-09-12 16:52 ` Rob Herring
2017-09-03 22:40 ` [PATCH 07/10] dmaengine: sun6i: Retrieve channel count/max request from devicetree Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-03 23:44 ` André Przywara
2017-09-03 23:44 ` André Przywara
2017-09-03 23:44 ` André Przywara
2017-09-04 0:12 ` Stefan Bruens
2017-09-04 0:12 ` Stefan Bruens
2017-09-04 0:12 ` Stefan Bruens
2017-09-03 22:40 ` [PATCH 08/10] dmaengine: sun6i: Add support for Allwinner A64 and compatibles Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-03 22:40 ` Stefan Brüns
2017-09-03 23:37 ` André Przywara
2017-09-03 23:37 ` André Przywara
2017-09-03 23:37 ` André Przywara
2017-09-04 0:13 ` Stefan Bruens
2017-09-04 0:13 ` Stefan Bruens
2017-09-04 0:13 ` Stefan Bruens
2017-09-03 22:41 ` [PATCH 09/10] arm64: allwinner: a64: Add device node for DMA controller Stefan Brüns
2017-09-03 22:41 ` Stefan Brüns
2017-09-03 22:41 ` Stefan Brüns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904074355.niloziky42aki7bg@flea \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.