From: Keith Busch <keith.busch@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: sagi@grimberg.me, mb@lightnvm.io, linux-nvme@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] nvme: fix lightnvm check
Date: Wed, 6 Sep 2017 11:06:04 -0400 [thread overview]
Message-ID: <20170906150604.GD17331@localhost.localdomain> (raw)
In-Reply-To: <20170906094825.8845-1-hch@lst.de>
On Wed, Sep 06, 2017 at 11:48:25AM +0200, Christoph Hellwig wrote:
> nvme_nvm_ns_supported assumes every device is a pci_dev, which leads to
> reading an incorrect field, or possible even a dereference of unallocated
> memory for fabrics controllers.
>
> Fix this by introducing a quirk for lighnvm capable devices instead.
Ugh, even with this quirk, new lightnvm device will be broken for
all existing kernels. This sort of thing really could benefit from a
standard's defined capability or command set supported bit to distinguish
lightnvm devices. Lacking that, this looks like the only thing we can
do at the moment.
Reviewed-by: Keith Busch <keith.busch@intel.com>
next prev parent reply other threads:[~2017-09-06 15:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 9:48 [PATCH] nvme: fix lightnvm check Christoph Hellwig
2017-09-06 10:22 ` Sagi Grimberg
2017-09-06 10:25 ` Sagi Grimberg
2017-09-06 15:06 ` Keith Busch [this message]
2017-09-07 12:01 ` Christoph Hellwig
2017-09-07 12:01 ` Christoph Hellwig
2017-09-07 12:15 ` Matias Bjørling
2017-09-07 12:15 ` Matias Bjørling
2017-09-07 12:20 ` Christoph Hellwig
2017-09-07 12:20 ` Christoph Hellwig
2017-09-07 12:34 ` Matias Bjørling
2017-09-07 12:34 ` Matias Bjørling
-- strict thread matches above, loose matches on Subject: below --
2017-09-06 9:50 Christoph Hellwig
2017-09-06 9:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906150604.GD17331@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=hch@lst.de \
--cc=linux-nvme@vger.kernel.org \
--cc=mb@lightnvm.io \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.