From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 3/4] nvme-pci: propagate (some) errors from host memory buffer setup
Date: Wed, 6 Sep 2017 17:49:09 -0400 [thread overview]
Message-ID: <20170906214909.GI17331@localhost.localdomain> (raw)
In-Reply-To: <20170906135532.21358-4-hch@lst.de>
On Wed, Sep 06, 2017@03:55:31PM +0200, Christoph Hellwig wrote:
> We want to catch command execution errors when resetting the device, so
> propagate errors from the Set Features when setting up the host memory
> buffer. We keep ignoring memory allocation failures, as the spec
> clearly says that the controller must work without a host memory buffer.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> Cc: stable at vger.kernel.org
Looks good.
Reviewed-by: Keith Busch <keith.busch at intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: sagi@grimberg.me, Akinobu Mita <akinobu.mita@gmail.com>,
linux-nvme@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH 3/4] nvme-pci: propagate (some) errors from host memory buffer setup
Date: Wed, 6 Sep 2017 17:49:09 -0400 [thread overview]
Message-ID: <20170906214909.GI17331@localhost.localdomain> (raw)
In-Reply-To: <20170906135532.21358-4-hch@lst.de>
On Wed, Sep 06, 2017 at 03:55:31PM +0200, Christoph Hellwig wrote:
> We want to catch command execution errors when resetting the device, so
> propagate errors from the Set Features when setting up the host memory
> buffer. We keep ignoring memory allocation failures, as the spec
> clearly says that the controller must work without a host memory buffer.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Cc: stable@vger.kernel.org
Looks good.
Reviewed-by: Keith Busch <keith.busch@intel.com>
next prev parent reply other threads:[~2017-09-06 21:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 13:55 nvme host memory buffer fixes and updates Christoph Hellwig
2017-09-06 13:55 ` [PATCH 1/4] nvme-pci: fix host memory buffer allocation fallback Christoph Hellwig
2017-09-06 13:55 ` Christoph Hellwig
2017-09-06 20:12 ` Keith Busch
2017-09-06 20:12 ` Keith Busch
2017-09-06 13:55 ` [PATCH 2/4] nvme-pci: use appropriate initial chunk size for HMB allocation Christoph Hellwig
2017-09-06 13:55 ` Christoph Hellwig
2017-09-06 20:13 ` Keith Busch
2017-09-06 20:13 ` Keith Busch
2017-09-06 13:55 ` [PATCH 3/4] nvme-pci: propagate (some) errors from host memory buffer setup Christoph Hellwig
2017-09-06 13:55 ` Christoph Hellwig
2017-09-06 14:19 ` Holger Hoffstätte
2017-09-06 14:19 ` Holger Hoffstätte
2017-09-06 20:27 ` Keith Busch
2017-09-06 20:27 ` Keith Busch
2017-09-06 21:49 ` Keith Busch [this message]
2017-09-06 21:49 ` Keith Busch
2017-09-06 13:55 ` [PATCH 4/4] nvme-pci: implement the HMB entry number and size limitations Christoph Hellwig
2017-09-06 20:11 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906214909.GI17331@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.