From: Greg KH <greg@kroah.com>
To: Pushkar Jambhlekar <pushkar.iit@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/staging/pi433: Fixing coding guidelines
Date: Thu, 7 Sep 2017 11:32:13 +0200 [thread overview]
Message-ID: <20170907093213.GC8102@kroah.com> (raw)
In-Reply-To: <1504676522-3049-1-git-send-email-pushkar.iit@gmail.com>
On Wed, Sep 06, 2017 at 11:12:02AM +0530, Pushkar Jambhlekar wrote:
> Fix brace style of if-else case
>
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/staging/pi433/pi433_if.c | 162 +++++++++++++--------------------------
> 1 file changed, 54 insertions(+), 108 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 93c0168..c070cf3 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -133,19 +133,16 @@ static irqreturn_t DIO0_irq_handler(int irq, void *dev_id)
> {
> struct pi433_device *device = dev_id;
>
> - if (device->irq_state[DIO0] == DIO_PacketSent)
> - {
> + if (device->irq_state[DIO0] == DIO_PacketSent) {
Those extra spaces after "if" really don't need to be there either,
right? Fix that at the same time please.
thanks,
greg k-h
prev parent reply other threads:[~2017-09-07 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 5:42 [PATCH] drivers/staging/pi433: Fixing coding guidelines Pushkar Jambhlekar
2017-09-07 9:32 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907093213.GC8102@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pushkar.iit@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.