All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roman Gushchin <guro@fb.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Linux MM <linux-mm@kvack.org>, Michal Hocko <mhocko@kernel.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	cgroups@vger.kernel.org, kernel-team@fb.com,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: memcontrol: use per-cpu stocks for socket memory uncharging
Date: Thu, 7 Sep 2017 19:47:45 +0100	[thread overview]
Message-ID: <20170907184745.GA20598@castle.DHCP.thefacebook.com> (raw)
In-Reply-To: <CALvZod5zP=LL=LhD0WX-zX4mPbn7F_obQmpCrrin9YuBQHJLow@mail.gmail.com>

On Thu, Sep 07, 2017 at 11:44:12AM -0700, Shakeel Butt wrote:
> >> As far as other types of pages go: page cache and anon are already
> >> batched pretty well, but I think kmem might benefit from this
> >> too. Have you considered using the stock in memcg_kmem_uncharge()?
> >
> > Good idea!
> > I'll try to find an appropriate testcase and check if it really
> > brings any benefits. If so, I'll master a patch.
> >
> 
> Hi Roman, did you get the chance to try this on memcg_kmem_uncharge()?

Hi Shakeel!

Not yet, I'll try to it asap.
Do you have an example when it's costly?

Thanks!

WARNING: multiple messages have this Message-ID (diff)
From: Roman Gushchin <guro@fb.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Linux MM <linux-mm@kvack.org>, Michal Hocko <mhocko@kernel.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	cgroups@vger.kernel.org, kernel-team@fb.com,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: memcontrol: use per-cpu stocks for socket memory uncharging
Date: Thu, 7 Sep 2017 19:47:45 +0100	[thread overview]
Message-ID: <20170907184745.GA20598@castle.DHCP.thefacebook.com> (raw)
In-Reply-To: <CALvZod5zP=LL=LhD0WX-zX4mPbn7F_obQmpCrrin9YuBQHJLow@mail.gmail.com>

On Thu, Sep 07, 2017 at 11:44:12AM -0700, Shakeel Butt wrote:
> >> As far as other types of pages go: page cache and anon are already
> >> batched pretty well, but I think kmem might benefit from this
> >> too. Have you considered using the stock in memcg_kmem_uncharge()?
> >
> > Good idea!
> > I'll try to find an appropriate testcase and check if it really
> > brings any benefits. If so, I'll master a patch.
> >
> 
> Hi Roman, did you get the chance to try this on memcg_kmem_uncharge()?

Hi Shakeel!

Not yet, I'll try to it asap.
Do you have an example when it's costly?

Thanks!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Roman Gushchin <guro@fb.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Linux MM <linux-mm@kvack.org>, Michal Hocko <mhocko@kernel.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	<cgroups@vger.kernel.org>, <kernel-team@fb.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: memcontrol: use per-cpu stocks for socket memory uncharging
Date: Thu, 7 Sep 2017 19:47:45 +0100	[thread overview]
Message-ID: <20170907184745.GA20598@castle.DHCP.thefacebook.com> (raw)
In-Reply-To: <CALvZod5zP=LL=LhD0WX-zX4mPbn7F_obQmpCrrin9YuBQHJLow@mail.gmail.com>

On Thu, Sep 07, 2017 at 11:44:12AM -0700, Shakeel Butt wrote:
> >> As far as other types of pages go: page cache and anon are already
> >> batched pretty well, but I think kmem might benefit from this
> >> too. Have you considered using the stock in memcg_kmem_uncharge()?
> >
> > Good idea!
> > I'll try to find an appropriate testcase and check if it really
> > brings any benefits. If so, I'll master a patch.
> >
> 
> Hi Roman, did you get the chance to try this on memcg_kmem_uncharge()?

Hi Shakeel!

Not yet, I'll try to it asap.
Do you have an example when it's costly?

Thanks!

  reply	other threads:[~2017-09-07 18:47 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-29 10:01 [PATCH] mm: memcontrol: use per-cpu stocks for socket memory uncharging Roman Gushchin
2017-08-29 10:01 ` Roman Gushchin
2017-08-29 10:01 ` Roman Gushchin
2017-08-29 19:26 ` Johannes Weiner
2017-08-29 19:26   ` Johannes Weiner
     [not found]   ` <20170829192621.GA5447-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2017-08-30 10:55     ` Roman Gushchin
2017-08-30 10:55       ` Roman Gushchin
2017-08-30 10:55       ` Roman Gushchin
2017-09-07 18:44       ` Shakeel Butt
2017-09-07 18:44         ` Shakeel Butt
2017-09-07 18:47         ` Roman Gushchin [this message]
2017-09-07 18:47           ` Roman Gushchin
2017-09-07 18:47           ` Roman Gushchin
2017-09-07 19:43           ` Shakeel Butt
2017-09-07 19:43             ` Shakeel Butt
2017-08-30 10:57     ` Roman Gushchin
2017-08-30 10:57       ` Roman Gushchin
2017-08-30 10:57       ` Roman Gushchin
     [not found] ` <20170829100150.4580-1-guro-b10kYP2dOMg@public.gmane.org>
2017-08-30 12:36   ` Michal Hocko
2017-08-30 12:36     ` Michal Hocko
2017-08-30 12:36     ` Michal Hocko
2017-08-30 12:44     ` Roman Gushchin
2017-08-30 12:44       ` Roman Gushchin
2017-08-30 12:55       ` Michal Hocko
2017-08-30 12:55         ` Michal Hocko
2017-08-30 12:57         ` Roman Gushchin
2017-08-30 12:57           ` Roman Gushchin
2017-08-30 14:23           ` Michal Hocko
2017-08-30 14:23             ` Michal Hocko
2017-08-30 14:24 ` Michal Hocko
2017-08-30 14:24   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170907184745.GA20598@castle.DHCP.thefacebook.com \
    --to=guro@fb.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=shakeelb@google.com \
    --cc=vdavydov.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.