From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: surface3_spi: make const array header static, reduces object code size
Date: Thu, 07 Sep 2017 21:31:56 +0000 [thread overview]
Message-ID: <20170907213156.GC19320@dtor-ws> (raw)
In-Reply-To: <20170906095137.21980-1-colin.king@canonical.com>
On Wed, Sep 06, 2017 at 10:51:37AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array header on the stack, instead make it
> static. Makes the object code smaller by over 180 bytes:
>
> Before:
> text data bss dec hex filename
> 6003 1536 0 7539 1d73 surface3_spi.o
>
> After:
> text data bss dec hex filename
> 5726 1632 0 7358 1cbe surface3_spi.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Applied, thank you.
> drivers/input/touchscreen/surface3_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c
> index e12fb9b63f31..ecba847889b5 100644
> --- a/drivers/input/touchscreen/surface3_spi.c
> +++ b/drivers/input/touchscreen/surface3_spi.c
> @@ -173,7 +173,7 @@ static void surface3_spi_process_pen(struct surface3_ts_data *ts_data, u8 *data)
>
> static void surface3_spi_process(struct surface3_ts_data *ts_data)
> {
> - const char header[] = {
> + static const char header[] = {
> 0xff, 0xff, 0xff, 0xff, 0xa5, 0x5a, 0xe7, 0x7e, 0x01
> };
> u8 *data = ts_data->rd_buf;
> --
> 2.14.1
>
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: surface3_spi: make const array header static, reduces object code size
Date: Thu, 7 Sep 2017 14:31:56 -0700 [thread overview]
Message-ID: <20170907213156.GC19320@dtor-ws> (raw)
In-Reply-To: <20170906095137.21980-1-colin.king@canonical.com>
On Wed, Sep 06, 2017 at 10:51:37AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array header on the stack, instead make it
> static. Makes the object code smaller by over 180 bytes:
>
> Before:
> text data bss dec hex filename
> 6003 1536 0 7539 1d73 surface3_spi.o
>
> After:
> text data bss dec hex filename
> 5726 1632 0 7358 1cbe surface3_spi.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Applied, thank you.
> drivers/input/touchscreen/surface3_spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/touchscreen/surface3_spi.c
> index e12fb9b63f31..ecba847889b5 100644
> --- a/drivers/input/touchscreen/surface3_spi.c
> +++ b/drivers/input/touchscreen/surface3_spi.c
> @@ -173,7 +173,7 @@ static void surface3_spi_process_pen(struct surface3_ts_data *ts_data, u8 *data)
>
> static void surface3_spi_process(struct surface3_ts_data *ts_data)
> {
> - const char header[] = {
> + static const char header[] = {
> 0xff, 0xff, 0xff, 0xff, 0xa5, 0x5a, 0xe7, 0x7e, 0x01
> };
> u8 *data = ts_data->rd_buf;
> --
> 2.14.1
>
--
Dmitry
next prev parent reply other threads:[~2017-09-07 21:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 9:51 [PATCH] input: surface3_spi: make const array header static, reduces object code size Colin King
2017-09-06 9:51 ` Colin King
2017-09-07 21:31 ` Dmitry Torokhov [this message]
2017-09-07 21:31 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170907213156.GC19320@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.