* [PATCH V3] Staging: speakup: Replace symbolic permission
@ 2017-09-09 17:40 Meghana Madhyastha
0 siblings, 0 replies; 3+ messages in thread
From: Meghana Madhyastha @ 2017-09-09 17:40 UTC (permalink / raw)
To: outreachy-kernel, gregkh, w.d.hubbs, chris
Replace S_IRUGO by 0444 in module parameter declaration. 0444 is more
readable and matches the style used in other declarations nearby.
Problem found using checkpatch.
Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
---
Changes in v2:
- Make the commit message more clearer and the title more concise
drivers/staging/speakup/speakup_acntsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/speakup_acntsa.c b/drivers/staging/speakup/speakup_acntsa.c
index 0e10404..4331584 100644
--- a/drivers/staging/speakup/speakup_acntsa.c
+++ b/drivers/staging/speakup/speakup_acntsa.c
@@ -136,7 +136,7 @@ static int synth_probe(struct spk_synth *synth)
}
module_param_named(ser, synth_acntsa.ser, int, 0444);
-module_param_named(dev, synth_acntsa.dev_name, charp, S_IRUGO);
+module_param_named(dev, synth_acntsa.dev_name, charp, 0444);
module_param_named(start, synth_acntsa.startup, short, 0444);
MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH V3] Staging: speakup: Replace symbolic permission
@ 2017-09-10 2:34 Meghana Madhyastha
2017-09-10 13:58 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Meghana Madhyastha @ 2017-09-10 2:34 UTC (permalink / raw)
To: outreachy-kernel, gregkh, w.d.hubbs, chris
Replace S_IRUGO by 0444 in module parameter declaration. 0444 is more
readable and matches the style used in other declarations nearby.
Problem found using checkpatch.
Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
---
Changes in v2:
- Make the commit message more clearer and the title more concise
Changes in v3:
-Mention the changes below ---
drivers/staging/speakup/speakup_acntsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/speakup_acntsa.c b/drivers/staging/speakup/speakup_acntsa.c
index 0e10404..4331584 100644
--- a/drivers/staging/speakup/speakup_acntsa.c
+++ b/drivers/staging/speakup/speakup_acntsa.c
@@ -136,7 +136,7 @@ static int synth_probe(struct spk_synth *synth)
}
module_param_named(ser, synth_acntsa.ser, int, 0444);
-module_param_named(dev, synth_acntsa.dev_name, charp, S_IRUGO);
+module_param_named(dev, synth_acntsa.dev_name, charp, 0444);
module_param_named(start, synth_acntsa.startup, short, 0444);
MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V3] Staging: speakup: Replace symbolic permission
2017-09-10 2:34 [PATCH V3] Staging: speakup: Replace symbolic permission Meghana Madhyastha
@ 2017-09-10 13:58 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2017-09-10 13:58 UTC (permalink / raw)
To: Meghana Madhyastha; +Cc: outreachy-kernel, w.d.hubbs, chris
On Sun, Sep 10, 2017 at 08:04:35AM +0530, Meghana Madhyastha wrote:
> Replace S_IRUGO by 0444 in module parameter declaration. 0444 is more
> readable and matches the style used in other declarations nearby.
>
> Problem found using checkpatch.
>
> Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
> ---
>
> Changes in v2:
> - Make the commit message more clearer and the title more concise
>
> Changes in v3:
> -Mention the changes below ---
I have two different v3 patches from you that both do the same thing,
yet they have two different subjects?
totally confused, please send a v4 with the "correct" one you wish to
submit.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-10 15:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-10 2:34 [PATCH V3] Staging: speakup: Replace symbolic permission Meghana Madhyastha
2017-09-10 13:58 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2017-09-09 17:40 Meghana Madhyastha
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.