* [PATCH] iio: core: Return error for failed read_reg
@ 2017-09-05 14:34 Lars-Peter Clausen
2017-09-05 15:20 ` Lars-Peter Clausen
0 siblings, 1 reply; 3+ messages in thread
From: Lars-Peter Clausen @ 2017-09-05 14:34 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Hartmut Knaack, Peter Meerwald-Stadler, Matt Fornero, linux-iio
From: Matt Fornero <matt.fornero@mathworks.com>
If an IIO device returns an error code for a read access via debugfs, it
is currently ignored by the IIO core (other than emitting an error
message). Instead, return this error code to user space, so upper layers
can detect it correctly.
Signed-off-by: Matt Fornero <matt.fornero@mathworks.com>
---
drivers/iio/industrialio-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index 7a5aa127c52e..9c4cfd19b739 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -310,8 +310,10 @@ static ssize_t iio_debugfs_read_reg(struct file *file, char __user *userbuf,
ret = indio_dev->info->debugfs_reg_access(indio_dev,
indio_dev->cached_reg_addr,
0, &val);
- if (ret)
+ if (ret) {
dev_err(indio_dev->dev.parent, "%s: read failed\n", __func__);
+ return ret;
+ }
len = snprintf(buf, sizeof(buf), "0x%X\n", val);
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] iio: core: Return error for failed read_reg
2017-09-05 14:34 [PATCH] iio: core: Return error for failed read_reg Lars-Peter Clausen
@ 2017-09-05 15:20 ` Lars-Peter Clausen
2017-09-10 15:26 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Lars-Peter Clausen @ 2017-09-05 15:20 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Hartmut Knaack, Peter Meerwald-Stadler, Matt Fornero, linux-iio
On 09/05/2017 04:34 PM, Lars-Peter Clausen wrote:
> From: Matt Fornero <matt.fornero@mathworks.com>
>
> If an IIO device returns an error code for a read access via debugfs, it
> is currently ignored by the IIO core (other than emitting an error
> message). Instead, return this error code to user space, so upper layers
> can detect it correctly.
>
> Signed-off-by: Matt Fornero <matt.fornero@mathworks.com>
Sorry, this should also have had:
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
> drivers/iio/industrialio-core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 7a5aa127c52e..9c4cfd19b739 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -310,8 +310,10 @@ static ssize_t iio_debugfs_read_reg(struct file *file, char __user *userbuf,
> ret = indio_dev->info->debugfs_reg_access(indio_dev,
> indio_dev->cached_reg_addr,
> 0, &val);
> - if (ret)
> + if (ret) {
> dev_err(indio_dev->dev.parent, "%s: read failed\n", __func__);
> + return ret;
> + }
>
> len = snprintf(buf, sizeof(buf), "0x%X\n", val);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iio: core: Return error for failed read_reg
2017-09-05 15:20 ` Lars-Peter Clausen
@ 2017-09-10 15:26 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2017-09-10 15:26 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: Hartmut Knaack, Peter Meerwald-Stadler, Matt Fornero, linux-iio
On Tue, 5 Sep 2017 17:20:57 +0200
Lars-Peter Clausen <lars@metafoo.de> wrote:
> On 09/05/2017 04:34 PM, Lars-Peter Clausen wrote:
> > From: Matt Fornero <matt.fornero@mathworks.com>
> >
> > If an IIO device returns an error code for a read access via debugfs, it
> > is currently ignored by the IIO core (other than emitting an error
> > message). Instead, return this error code to user space, so upper layers
> > can detect it correctly.
> >
> > Signed-off-by: Matt Fornero <matt.fornero@mathworks.com>
>
> Sorry, this should also have had:
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>
Applied to the fixes-togreg branch of iio.git and marked for stable.
Thanks,
Jonathan
> > ---
> > drivers/iio/industrialio-core.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> > index 7a5aa127c52e..9c4cfd19b739 100644
> > --- a/drivers/iio/industrialio-core.c
> > +++ b/drivers/iio/industrialio-core.c
> > @@ -310,8 +310,10 @@ static ssize_t iio_debugfs_read_reg(struct file *file, char __user *userbuf,
> > ret = indio_dev->info->debugfs_reg_access(indio_dev,
> > indio_dev->cached_reg_addr,
> > 0, &val);
> > - if (ret)
> > + if (ret) {
> > dev_err(indio_dev->dev.parent, "%s: read failed\n", __func__);
> > + return ret;
> > + }
> >
> > len = snprintf(buf, sizeof(buf), "0x%X\n", val);
> >
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-10 15:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-05 14:34 [PATCH] iio: core: Return error for failed read_reg Lars-Peter Clausen
2017-09-05 15:20 ` Lars-Peter Clausen
2017-09-10 15:26 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.