* [PATCH] Staging: ccree: Don't use volatile for monitor_lock @ 2017-09-11 15:59 ` Srishti Sharma 0 siblings, 0 replies; 15+ messages in thread From: Srishti Sharma @ 2017-09-11 15:59 UTC (permalink / raw) To: gilad Cc: gregkh, linux-crypto, driverdev-devel, devel, linux-kernel, outreachy-kernel, Srishti Sharma The use of volatile for the variable monitor_lock is unnecessary. Signed-off-by: Srishti Sharma <srishtishar@gmail.com> --- drivers/staging/ccree/ssi_request_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c index e5c2f92..7d77941 100644 --- a/drivers/staging/ccree/ssi_request_mgr.c +++ b/drivers/staging/ccree/ssi_request_mgr.c @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { dma_addr_t dummy_comp_buff_dma; struct cc_hw_desc monitor_desc; - volatile unsigned long monitor_lock; + unsigned long monitor_lock; #ifdef COMP_IN_WQ struct workqueue_struct *workq; struct delayed_work compwork; ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] Staging: ccree: Don't use volatile for monitor_lock @ 2017-09-11 15:59 ` Srishti Sharma 0 siblings, 0 replies; 15+ messages in thread From: Srishti Sharma @ 2017-09-11 15:59 UTC (permalink / raw) To: gilad Cc: gregkh, linux-crypto, driverdev-devel, devel, linux-kernel, outreachy-kernel, Srishti Sharma The use of volatile for the variable monitor_lock is unnecessary. Signed-off-by: Srishti Sharma <srishtishar@gmail.com> --- drivers/staging/ccree/ssi_request_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c index e5c2f92..7d77941 100644 --- a/drivers/staging/ccree/ssi_request_mgr.c +++ b/drivers/staging/ccree/ssi_request_mgr.c @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { dma_addr_t dummy_comp_buff_dma; struct cc_hw_desc monitor_desc; - volatile unsigned long monitor_lock; + unsigned long monitor_lock; #ifdef COMP_IN_WQ struct workqueue_struct *workq; struct delayed_work compwork; -- 2.7.4 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: ccree: Don't use volatile for monitor_lock 2017-09-11 15:59 ` Srishti Sharma (?) @ 2017-09-11 16:03 ` Julia Lawall -1 siblings, 0 replies; 15+ messages in thread From: Julia Lawall @ 2017-09-11 16:03 UTC (permalink / raw) To: Srishti Sharma Cc: gilad, gregkh, linux-crypto, driverdev-devel, devel, linux-kernel, outreachy-kernel On Mon, 11 Sep 2017, Srishti Sharma wrote: > The use of volatile for the variable monitor_lock is unnecessary. You need to give more evidence of why this is the case. How is the variable used? I guess this comes from checkpatch, but checkpatch has only a local view of things, and doesn't know how the variable is used. julia > > Signed-off-by: Srishti Sharma <srishtishar@gmail.com> > --- > drivers/staging/ccree/ssi_request_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c > index e5c2f92..7d77941 100644 > --- a/drivers/staging/ccree/ssi_request_mgr.c > +++ b/drivers/staging/ccree/ssi_request_mgr.c > @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { > dma_addr_t dummy_comp_buff_dma; > struct cc_hw_desc monitor_desc; > > - volatile unsigned long monitor_lock; > + unsigned long monitor_lock; > #ifdef COMP_IN_WQ > struct workqueue_struct *workq; > struct delayed_work compwork; > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505145571-11248-1-git-send-email-srishtishar%40gmail.com. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock 2017-09-11 15:59 ` Srishti Sharma @ 2017-09-11 16:04 ` Greg KH -1 siblings, 0 replies; 15+ messages in thread From: Greg KH @ 2017-09-11 16:04 UTC (permalink / raw) To: Srishti Sharma Cc: devel, outreachy-kernel, driverdev-devel, linux-kernel, linux-crypto On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: > The use of volatile for the variable monitor_lock is unnecessary. > > Signed-off-by: Srishti Sharma <srishtishar@gmail.com> > --- > drivers/staging/ccree/ssi_request_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c > index e5c2f92..7d77941 100644 > --- a/drivers/staging/ccree/ssi_request_mgr.c > +++ b/drivers/staging/ccree/ssi_request_mgr.c > @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { > dma_addr_t dummy_comp_buff_dma; > struct cc_hw_desc monitor_desc; > > - volatile unsigned long monitor_lock; > + unsigned long monitor_lock; While volatile is not right, odds are, this is still totally wrong as well. How about using a "real" lock instead? thanks, greg k-h ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock @ 2017-09-11 16:04 ` Greg KH 0 siblings, 0 replies; 15+ messages in thread From: Greg KH @ 2017-09-11 16:04 UTC (permalink / raw) To: Srishti Sharma Cc: gilad, linux-crypto, driverdev-devel, devel, linux-kernel, outreachy-kernel On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: > The use of volatile for the variable monitor_lock is unnecessary. > > Signed-off-by: Srishti Sharma <srishtishar@gmail.com> > --- > drivers/staging/ccree/ssi_request_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c > index e5c2f92..7d77941 100644 > --- a/drivers/staging/ccree/ssi_request_mgr.c > +++ b/drivers/staging/ccree/ssi_request_mgr.c > @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { > dma_addr_t dummy_comp_buff_dma; > struct cc_hw_desc monitor_desc; > > - volatile unsigned long monitor_lock; > + unsigned long monitor_lock; While volatile is not right, odds are, this is still totally wrong as well. How about using a "real" lock instead? thanks, greg k-h ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock 2017-09-11 16:04 ` Greg KH @ 2017-09-11 16:08 ` Srishti Sharma -1 siblings, 0 replies; 15+ messages in thread From: Srishti Sharma @ 2017-09-11 16:08 UTC (permalink / raw) To: Greg KH Cc: devel, outreachy-kernel, driverdev-devel, Linux kernel mailing list, Linux Crypto Mailing List On Mon, Sep 11, 2017 at 9:34 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> The use of volatile for the variable monitor_lock is unnecessary. >> >> Signed-off-by: Srishti Sharma <srishtishar@gmail.com> >> --- >> drivers/staging/ccree/ssi_request_mgr.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c >> index e5c2f92..7d77941 100644 >> --- a/drivers/staging/ccree/ssi_request_mgr.c >> +++ b/drivers/staging/ccree/ssi_request_mgr.c >> @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { >> dma_addr_t dummy_comp_buff_dma; >> struct cc_hw_desc monitor_desc; >> >> - volatile unsigned long monitor_lock; >> + unsigned long monitor_lock; > > While volatile is not right, odds are, this is still totally wrong as > well. How about using a "real" lock instead? I tried to find where is this variable being used in the code, but I didn't find any usage of it . It might be an important attribute of this structure definition but, I don't see it's value being set to anything or being used somewhere . Regards, Srishti > > thanks, > > greg k-h ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock @ 2017-09-11 16:08 ` Srishti Sharma 0 siblings, 0 replies; 15+ messages in thread From: Srishti Sharma @ 2017-09-11 16:08 UTC (permalink / raw) To: Greg KH Cc: Gilad Ben-Yossef, Linux Crypto Mailing List, driverdev-devel, devel, Linux kernel mailing list, outreachy-kernel On Mon, Sep 11, 2017 at 9:34 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> The use of volatile for the variable monitor_lock is unnecessary. >> >> Signed-off-by: Srishti Sharma <srishtishar@gmail.com> >> --- >> drivers/staging/ccree/ssi_request_mgr.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c >> index e5c2f92..7d77941 100644 >> --- a/drivers/staging/ccree/ssi_request_mgr.c >> +++ b/drivers/staging/ccree/ssi_request_mgr.c >> @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { >> dma_addr_t dummy_comp_buff_dma; >> struct cc_hw_desc monitor_desc; >> >> - volatile unsigned long monitor_lock; >> + unsigned long monitor_lock; > > While volatile is not right, odds are, this is still totally wrong as > well. How about using a "real" lock instead? I tried to find where is this variable being used in the code, but I didn't find any usage of it . It might be an important attribute of this structure definition but, I don't see it's value being set to anything or being used somewhere . Regards, Srishti > > thanks, > > greg k-h ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock 2017-09-11 16:08 ` Srishti Sharma (?) @ 2017-09-11 16:10 ` Sean Paul -1 siblings, 0 replies; 15+ messages in thread From: Sean Paul @ 2017-09-11 16:10 UTC (permalink / raw) To: Srishti Sharma Cc: Greg KH, Gilad Ben-Yossef, Linux Crypto Mailing List, driverdev-devel, devel, Linux kernel mailing list, outreachy-kernel On Mon, Sep 11, 2017 at 12:08 PM, Srishti Sharma <srishtishar@gmail.com> wrote: > On Mon, Sep 11, 2017 at 9:34 PM, Greg KH <gregkh@linuxfoundation.org> wrote: >> On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >>> The use of volatile for the variable monitor_lock is unnecessary. >>> >>> Signed-off-by: Srishti Sharma <srishtishar@gmail.com> >>> --- >>> drivers/staging/ccree/ssi_request_mgr.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c >>> index e5c2f92..7d77941 100644 >>> --- a/drivers/staging/ccree/ssi_request_mgr.c >>> +++ b/drivers/staging/ccree/ssi_request_mgr.c >>> @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { >>> dma_addr_t dummy_comp_buff_dma; >>> struct cc_hw_desc monitor_desc; >>> >>> - volatile unsigned long monitor_lock; >>> + unsigned long monitor_lock; >> >> While volatile is not right, odds are, this is still totally wrong as >> well. How about using a "real" lock instead? > > I tried to find where is this variable being used in the code, but I > didn't find any usage of it . It might be an important attribute of > this structure definition but, I don't see it's value being set to > anything or being used somewhere . > AFAICT, it's not used. Your patch should just remove it instead :) Sean > Regards, > Srishti >> >> thanks, >> >> greg k-h > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAB3L5oxcyhgyy8EuGuPo9QtJQd-W7JTgQQE1PfopZFmSx58P9g%40mail.gmail.com. > For more options, visit https://groups.google.com/d/optout. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock 2017-09-11 16:08 ` Srishti Sharma (?) (?) @ 2017-09-11 16:11 ` Julia Lawall 2017-09-11 16:15 ` Srishti Sharma -1 siblings, 1 reply; 15+ messages in thread From: Julia Lawall @ 2017-09-11 16:11 UTC (permalink / raw) To: Srishti Sharma Cc: Greg KH, Gilad Ben-Yossef, Linux Crypto Mailing List, driverdev-devel, devel, Linux kernel mailing list, outreachy-kernel On Mon, 11 Sep 2017, Srishti Sharma wrote: > On Mon, Sep 11, 2017 at 9:34 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: > >> The use of volatile for the variable monitor_lock is unnecessary. > >> > >> Signed-off-by: Srishti Sharma <srishtishar@gmail.com> > >> --- > >> drivers/staging/ccree/ssi_request_mgr.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c > >> index e5c2f92..7d77941 100644 > >> --- a/drivers/staging/ccree/ssi_request_mgr.c > >> +++ b/drivers/staging/ccree/ssi_request_mgr.c > >> @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { > >> dma_addr_t dummy_comp_buff_dma; > >> struct cc_hw_desc monitor_desc; > >> > >> - volatile unsigned long monitor_lock; > >> + unsigned long monitor_lock; > > > > While volatile is not right, odds are, this is still totally wrong as > > well. How about using a "real" lock instead? > > I tried to find where is this variable being used in the code, but I > didn't find any usage of it . It might be an important attribute of > this structure definition but, I don't see it's value being set to > anything or being used somewhere . Try removing it and see if the code still compiles. There is always a danger that a use of something could be constructed using ## in a macro, although given the uses of ## for this driver, it doesn't seem likely here. julia ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock 2017-09-11 16:11 ` Julia Lawall @ 2017-09-11 16:15 ` Srishti Sharma 0 siblings, 0 replies; 15+ messages in thread From: Srishti Sharma @ 2017-09-11 16:15 UTC (permalink / raw) To: Julia Lawall Cc: devel, outreachy-kernel, Greg KH, driverdev-devel, Linux kernel mailing list, Linux Crypto Mailing List On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall <julia.lawall@lip6.fr> wrote: > > > On Mon, 11 Sep 2017, Srishti Sharma wrote: > >> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH <gregkh@linuxfoundation.org> wrote: >> > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> >> The use of volatile for the variable monitor_lock is unnecessary. >> >> >> >> Signed-off-by: Srishti Sharma <srishtishar@gmail.com> >> >> --- >> >> drivers/staging/ccree/ssi_request_mgr.c | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> >> diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c >> >> index e5c2f92..7d77941 100644 >> >> --- a/drivers/staging/ccree/ssi_request_mgr.c >> >> +++ b/drivers/staging/ccree/ssi_request_mgr.c >> >> @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { >> >> dma_addr_t dummy_comp_buff_dma; >> >> struct cc_hw_desc monitor_desc; >> >> >> >> - volatile unsigned long monitor_lock; >> >> + unsigned long monitor_lock; >> > >> > While volatile is not right, odds are, this is still totally wrong as >> > well. How about using a "real" lock instead? >> >> I tried to find where is this variable being used in the code, but I >> didn't find any usage of it . It might be an important attribute of >> this structure definition but, I don't see it's value being set to >> anything or being used somewhere . > > Try removing it and see if the code still compiles. There is always a > danger that a use of something could be constructed using ## in a macro, > although given the uses of ## for this driver, it doesn't seem likely > here. Yes, I'll do that. Regards, Srishti > > julia ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock @ 2017-09-11 16:15 ` Srishti Sharma 0 siblings, 0 replies; 15+ messages in thread From: Srishti Sharma @ 2017-09-11 16:15 UTC (permalink / raw) To: Julia Lawall Cc: Greg KH, Gilad Ben-Yossef, Linux Crypto Mailing List, driverdev-devel, devel, Linux kernel mailing list, outreachy-kernel On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall <julia.lawall@lip6.fr> wrote: > > > On Mon, 11 Sep 2017, Srishti Sharma wrote: > >> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH <gregkh@linuxfoundation.org> wrote: >> > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> >> The use of volatile for the variable monitor_lock is unnecessary. >> >> >> >> Signed-off-by: Srishti Sharma <srishtishar@gmail.com> >> >> --- >> >> drivers/staging/ccree/ssi_request_mgr.c | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> >> diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c >> >> index e5c2f92..7d77941 100644 >> >> --- a/drivers/staging/ccree/ssi_request_mgr.c >> >> +++ b/drivers/staging/ccree/ssi_request_mgr.c >> >> @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { >> >> dma_addr_t dummy_comp_buff_dma; >> >> struct cc_hw_desc monitor_desc; >> >> >> >> - volatile unsigned long monitor_lock; >> >> + unsigned long monitor_lock; >> > >> > While volatile is not right, odds are, this is still totally wrong as >> > well. How about using a "real" lock instead? >> >> I tried to find where is this variable being used in the code, but I >> didn't find any usage of it . It might be an important attribute of >> this structure definition but, I don't see it's value being set to >> anything or being used somewhere . > > Try removing it and see if the code still compiles. There is always a > danger that a use of something could be constructed using ## in a macro, > although given the uses of ## for this driver, it doesn't seem likely > here. Yes, I'll do that. Regards, Srishti > > julia ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock 2017-09-11 16:15 ` Srishti Sharma (?) @ 2017-09-11 16:34 ` Srishti Sharma -1 siblings, 0 replies; 15+ messages in thread From: Srishti Sharma @ 2017-09-11 16:34 UTC (permalink / raw) To: Julia Lawall Cc: Greg KH, Gilad Ben-Yossef, Linux Crypto Mailing List, driverdev-devel, devel, Linux kernel mailing list, outreachy-kernel On Mon, Sep 11, 2017 at 9:45 PM, Srishti Sharma <srishtishar@gmail.com> wrote: > On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall <julia.lawall@lip6.fr> wrote: >> >> >> On Mon, 11 Sep 2017, Srishti Sharma wrote: >> >>> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH <gregkh@linuxfoundation.org> wrote: >>> > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >>> >> The use of volatile for the variable monitor_lock is unnecessary. >>> >> >>> >> Signed-off-by: Srishti Sharma <srishtishar@gmail.com> >>> >> --- >>> >> drivers/staging/ccree/ssi_request_mgr.c | 2 +- >>> >> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >> >>> >> diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c >>> >> index e5c2f92..7d77941 100644 >>> >> --- a/drivers/staging/ccree/ssi_request_mgr.c >>> >> +++ b/drivers/staging/ccree/ssi_request_mgr.c >>> >> @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { >>> >> dma_addr_t dummy_comp_buff_dma; >>> >> struct cc_hw_desc monitor_desc; >>> >> >>> >> - volatile unsigned long monitor_lock; >>> >> + unsigned long monitor_lock; >>> > >>> > While volatile is not right, odds are, this is still totally wrong as >>> > well. How about using a "real" lock instead? >>> >>> I tried to find where is this variable being used in the code, but I >>> didn't find any usage of it . It might be an important attribute of >>> this structure definition but, I don't see it's value being set to >>> anything or being used somewhere . >> >> Try removing it and see if the code still compiles. There is always a >> danger that a use of something could be constructed using ## in a macro, >> although given the uses of ## for this driver, it doesn't seem likely >> here. It compiles, so I have removed the variable and sent another patch Thanks, Srishti > > Yes, I'll do that. > > Regards, > Srishti >> >> julia ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock 2017-09-11 15:59 ` Srishti Sharma @ 2017-09-12 9:19 ` Dan Carpenter -1 siblings, 0 replies; 15+ messages in thread From: Dan Carpenter @ 2017-09-12 9:19 UTC (permalink / raw) To: Srishti Sharma Cc: devel, outreachy-kernel, gregkh, driverdev-devel, linux-kernel, linux-crypto On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: > The use of volatile for the variable monitor_lock is unnecessary. > > Signed-off-by: Srishti Sharma <srishtishar@gmail.com> > --- > drivers/staging/ccree/ssi_request_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c > index e5c2f92..7d77941 100644 > --- a/drivers/staging/ccree/ssi_request_mgr.c > +++ b/drivers/staging/ccree/ssi_request_mgr.c > @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { > dma_addr_t dummy_comp_buff_dma; > struct cc_hw_desc monitor_desc; > > - volatile unsigned long monitor_lock; > + unsigned long monitor_lock; The variable seems unused. Try deleting it instead. regards, dan carpenter ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock @ 2017-09-12 9:19 ` Dan Carpenter 0 siblings, 0 replies; 15+ messages in thread From: Dan Carpenter @ 2017-09-12 9:19 UTC (permalink / raw) To: Srishti Sharma Cc: gilad, devel, gregkh, driverdev-devel, linux-kernel, outreachy-kernel, linux-crypto On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: > The use of volatile for the variable monitor_lock is unnecessary. > > Signed-off-by: Srishti Sharma <srishtishar@gmail.com> > --- > drivers/staging/ccree/ssi_request_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c > index e5c2f92..7d77941 100644 > --- a/drivers/staging/ccree/ssi_request_mgr.c > +++ b/drivers/staging/ccree/ssi_request_mgr.c > @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { > dma_addr_t dummy_comp_buff_dma; > struct cc_hw_desc monitor_desc; > > - volatile unsigned long monitor_lock; > + unsigned long monitor_lock; The variable seems unused. Try deleting it instead. regards, dan carpenter ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock 2017-09-12 9:19 ` Dan Carpenter (?) @ 2017-09-12 12:05 ` Srishti Sharma -1 siblings, 0 replies; 15+ messages in thread From: Srishti Sharma @ 2017-09-12 12:05 UTC (permalink / raw) To: Dan Carpenter Cc: Gilad Ben-Yossef, devel, Greg KH, driverdev-devel, Linux kernel mailing list, outreachy-kernel, Linux Crypto Mailing List On Tue, Sep 12, 2017 at 2:49 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote: > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> The use of volatile for the variable monitor_lock is unnecessary. >> >> Signed-off-by: Srishti Sharma <srishtishar@gmail.com> >> --- >> drivers/staging/ccree/ssi_request_mgr.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c >> index e5c2f92..7d77941 100644 >> --- a/drivers/staging/ccree/ssi_request_mgr.c >> +++ b/drivers/staging/ccree/ssi_request_mgr.c >> @@ -49,7 +49,7 @@ struct ssi_request_mgr_handle { >> dma_addr_t dummy_comp_buff_dma; >> struct cc_hw_desc monitor_desc; >> >> - volatile unsigned long monitor_lock; >> + unsigned long monitor_lock; > > The variable seems unused. Try deleting it instead. Had already sent a patch for that as v2. Thanks Srishti > regards, > dan carpenter > ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2017-09-12 12:05 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-09-11 15:59 [PATCH] Staging: ccree: Don't use volatile for monitor_lock Srishti Sharma 2017-09-11 15:59 ` Srishti Sharma 2017-09-11 16:03 ` [Outreachy kernel] " Julia Lawall 2017-09-11 16:04 ` Greg KH 2017-09-11 16:04 ` Greg KH 2017-09-11 16:08 ` Srishti Sharma 2017-09-11 16:08 ` Srishti Sharma 2017-09-11 16:10 ` [Outreachy kernel] " Sean Paul 2017-09-11 16:11 ` Julia Lawall 2017-09-11 16:15 ` Srishti Sharma 2017-09-11 16:15 ` Srishti Sharma 2017-09-11 16:34 ` Srishti Sharma 2017-09-12 9:19 ` Dan Carpenter 2017-09-12 9:19 ` Dan Carpenter 2017-09-12 12:05 ` Srishti Sharma
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.