[PATCH v2] staging: rtl8723bs: Change coding style to (foo *bar)

[PATCH v2] staging: rtl8723bs: Change coding style to (foo *bar)

[Harsha Sharma]

This coding style (foo *bar) is more common for the kernel code.
Change foo* bar to foo *bar.
Change foo * bar to foo *bar.
Change (foo*) to (foo *).

Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
---
Change in v2:
 -Updated log message and subject
 
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 0215899..a82804b 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -142,11 +142,11 @@
 #endif
 module_param(rtw_qos_opt_enable, int, 0644);
 
-static char* ifname = "wlan%d";
+static char *ifname = "wlan%d";
 module_param(ifname, charp, 0644);
 MODULE_PARM_DESC(ifname, "The default name to allocate for first interface");
 
-char* rtw_initmac = NULL;  /*  temp mac address if users want to use instead of the mac address in Efuse */
+char *rtw_initmac = NULL;  /*  temp mac address if users want to use instead of the mac address in Efuse */
 
 module_param(rtw_initmac, charp, 0644);
 module_param(rtw_channel_plan, int, 0644);
@@ -460,7 +460,7 @@ u16 rtw_recv_select_queue(struct sk_buff *skb)
 
 }
 
-static int rtw_ndev_notifier_call(struct notifier_block * nb, unsigned long state, void *ptr)
+static int rtw_ndev_notifier_call(struct notifier_block *nb, unsigned long state, void *ptr)
 {
 	struct net_device *dev = netdev_notifier_info_to_dev(ptr);
 
@@ -623,7 +623,7 @@ void rtw_stop_drv_threads (struct adapter *padapter)
 static u8 rtw_init_default_value(struct adapter *padapter)
 {
 	u8 ret  = _SUCCESS;
-	struct registry_priv* pregistrypriv = &padapter->registrypriv;
+	struct registry_priv *pregistrypriv = &padapter->registrypriv;
 	struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 	struct security_priv *psecuritypriv = &padapter->securitypriv;
@@ -691,7 +691,7 @@ struct dvobj_priv *devobj_init(void)
 {
 	struct dvobj_priv *pdvobj = NULL;
 
-	if ((pdvobj = (struct dvobj_priv*)rtw_zmalloc(sizeof(*pdvobj))) == NULL)
+	if ((pdvobj = (struct dvobj_priv *)rtw_zmalloc(sizeof(*pdvobj))) == NULL)
 		return NULL;
 
 	mutex_init(&pdvobj->hw_init_mutex);
-- 
1.9.1

Re: [PATCH v2] staging: rtl8723bs: Change coding style to (foo *bar)

[Greg KH]

On Sat, Sep 09, 2017 at 10:43:36PM +0530, Harsha Sharma wrote:
> This coding style (foo *bar) is more common for the kernel code.
> Change foo* bar to foo *bar.
> Change foo * bar to foo *bar.
> Change (foo*) to (foo *).
> 
> Signed-off-by: Harsha Sharma <harshasharmaiitr@gmail.com>
> ---
> Change in v2:
>  -Updated log message and subject

Does not apply to my tree :(

Re: [PATCH v2] staging: rtl8723bs: Change coding style to (foo *bar)

[Harsha Sharma]

[-- Attachment #1.1: Type: text/plain, Size: 590 bytes --]



On Monday, September 11, 2017 at 10:08:13 PM UTC+5:30, gregkh wrote:
>
> On Sat, Sep 09, 2017 at 10:43:36PM +0530, Harsha Sharma wrote: 
> > This coding style (foo *bar) is more common for the kernel code. 
> > Change foo* bar to foo *bar. 
> > Change foo * bar to foo *bar. 
> > Change (foo*) to (foo *). 
> > 
> > Signed-off-by: Harsha Sharma <harshash...@gmail.com <javascript:>> 
> > --- 
> > Change in v2: 
> >  -Updated log message and subject 
>
> Does not apply to my tree :( 
>
 
Do I need to make any changes in this patch ?
Thanks a lot for your time.

Regards,
Harsha Sharma 

[-- Attachment #1.2: Type: text/html, Size: 1062 bytes --]

Re: [Outreachy kernel] Re: [PATCH v2] staging: rtl8723bs: Change coding style to (foo *bar)

[Greg KH]

On Mon, Sep 11, 2017 at 09:44:41AM -0700, Harsha Sharma wrote:
> 
> 
> On Monday, September 11, 2017 at 10:08:13 PM UTC+5:30, gregkh wrote:
> 
>     On Sat, Sep 09, 2017 at 10:43:36PM +0530, Harsha Sharma wrote:
>     > This coding style (foo *bar) is more common for the kernel code.
>     > Change foo* bar to foo *bar.
>     > Change foo * bar to foo *bar.
>     > Change (foo*) to (foo *).
>     >
>     > Signed-off-by: Harsha Sharma <harshash...@gmail.com>
>     > ---
>     > Change in v2:
>     > �-Updated log message and subject
> 
>     Does not apply to my tree :(
> 
> �
> Do I need to make any changes in this patch ?

If you want it applied, yes, you do :)

Please rebase it against my staging-testing branch and resend it.

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH v2] staging: rtl8723bs: Change coding style to (foo *bar)

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 909 bytes --]



On Mon, 11 Sep 2017, Harsha Sharma wrote:

>
>
> On Monday, September 11, 2017 at 10:08:13 PM UTC+5:30, gregkh wrote:
>       On Sat, Sep 09, 2017 at 10:43:36PM +0530, Harsha Sharma wrote:
>       > This coding style (foo *bar) is more common for the kernel
>       code.
>       > Change foo* bar to foo *bar.
>       > Change foo * bar to foo *bar.
>       > Change (foo*) to (foo *).
>       >
>       > Signed-off-by: Harsha Sharma <harshash...@gmail.com>
>       > ---
>       > Change in v2:
>       > ￜ-Updated log message and subject
>
>       Does not apply to my tree :(
>
> ￜ
> Do I need to make any changes in this patch ?
> Thanks a lot for your time.

You need to update your staging tree to the latest one, and then try to
reapply your patch to it.  Maybe the change has already been made by
someone else.  Or maybe some line that you have changed has been changed
by someone else.

julia