All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Congwen Zhang <zhang.congwen@zte.com.cn>
Cc: nelio.laranjeiro@6wind.com, dev@dpdk.org
Subject: Re: [PATCH] net/mlx5: fix tunnel_en initialization value
Date: Tue, 12 Sep 2017 12:19:29 +0200	[thread overview]
Message-ID: <20170912101929.GM2481@6wind.com> (raw)
In-Reply-To: <201709120914.v8C9Evq8012512@mse01.zte.com.cn>

Hi Congwen,

On Tue, Sep 12, 2017 at 05:05:50PM +0800, Congwen Zhang wrote:
> In function mlx5_pci_probe(), tunnel_en actually be used without
> being initialized. Fix it by initializing it to 0.
> 
> Signe-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>

Thanks, however it's already been addressed [1]. The related commit is only
part of dpdk-next-net though, it's not merged in the main tree yet.

[1] http://dpdk.org/ml/archives/dev/2017-September/074271.html

> ---
>  drivers/net/mlx5/mlx5.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index b7e5046..95e62ad 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -452,7 +452,7 @@ struct mlx5_args {
>  	struct ibv_device_attr device_attr;
>  	unsigned int sriov;
>  	unsigned int mps;
> -	unsigned int tunnel_en;
> +	unsigned int tunnel_en = 0;
>  	int idx;
>  	int i;
>  
> -- 
> 1.8.3.1
> 

-- 
Adrien Mazarguil
6WIND

      reply	other threads:[~2017-09-12 10:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-12  9:05 [PATCH] net/mlx5: fix tunnel_en initialization value Congwen Zhang
2017-09-12 10:19 ` Adrien Mazarguil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170912101929.GM2481@6wind.com \
    --to=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=zhang.congwen@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.