From: Cornelia Huck <cohuck@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
qemu-devel@nongnu.org, Greg Kurz <groug@kaod.org>,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-arm] [PATCH v4 3/4] dump: do not dump non-existent guest memory
Date: Wed, 13 Sep 2017 16:27:09 +0200 [thread overview]
Message-ID: <20170913162709.3933352d.cohuck@redhat.com> (raw)
In-Reply-To: <20170913142036.2469-4-lvivier@redhat.com>
On Wed, 13 Sep 2017 16:20:35 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> From: Cornelia Huck <cohuck@redhat.com>
>
> It does not really make sense to dump memory that is not there.
>
> Moreover, that fixes a segmentation fault when calling dump-guest-memory
> with no filter for a machine with no memory defined.
>
> New behaviour is:
>
> (qemu) dump-guest-memory /dev/null
> dump: no guest memory to dump
> (qemu) dump-guest-memory /dev/null 0 4096
> dump: no guest memory to dump
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> Tested-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: Greg Kurz <groug@kaod.org>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> ---
> dump.c | 6 ++++++
> 1 file changed, 6 insertions(+)
You need to supply your s-o-b as well, no?
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
qemu-devel@nongnu.org,
"Daniel P . Berrange" <berrange@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
Thomas Huth <thuth@redhat.com>,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>,
Greg Kurz <groug@kaod.org>
Subject: Re: [Qemu-devel] [PATCH v4 3/4] dump: do not dump non-existent guest memory
Date: Wed, 13 Sep 2017 16:27:09 +0200 [thread overview]
Message-ID: <20170913162709.3933352d.cohuck@redhat.com> (raw)
In-Reply-To: <20170913142036.2469-4-lvivier@redhat.com>
On Wed, 13 Sep 2017 16:20:35 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> From: Cornelia Huck <cohuck@redhat.com>
>
> It does not really make sense to dump memory that is not there.
>
> Moreover, that fixes a segmentation fault when calling dump-guest-memory
> with no filter for a machine with no memory defined.
>
> New behaviour is:
>
> (qemu) dump-guest-memory /dev/null
> dump: no guest memory to dump
> (qemu) dump-guest-memory /dev/null 0 4096
> dump: no guest memory to dump
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> Tested-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: Laurent Vivier <lvivier@redhat.com>
> Reviewed-by: Greg Kurz <groug@kaod.org>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> ---
> dump.c | 6 ++++++
> 1 file changed, 6 insertions(+)
You need to supply your s-o-b as well, no?
next prev parent reply other threads:[~2017-09-13 14:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 14:20 [Qemu-arm] [PATCH v4 0/4] hmp: fix "dump-quest-memory" segfault Laurent Vivier
2017-09-13 14:20 ` [Qemu-devel] " Laurent Vivier
2017-09-13 14:20 ` [Qemu-arm] [PATCH v4 1/4] hmp: fix "dump-quest-memory" segfault (ppc) Laurent Vivier
2017-09-13 14:20 ` [Qemu-devel] " Laurent Vivier
2017-09-14 0:14 ` [Qemu-arm] " David Gibson
2017-09-14 0:14 ` [Qemu-devel] " David Gibson
2017-09-13 14:20 ` [Qemu-arm] [PATCH v4 2/4] hmp: fix "dump-quest-memory" segfault (arm) Laurent Vivier
2017-09-13 14:20 ` [Qemu-devel] " Laurent Vivier
2017-09-14 6:41 ` [Qemu-arm] " Auger Eric
2017-09-14 6:41 ` Auger Eric
2017-09-13 14:20 ` [Qemu-arm] [PATCH v4 3/4] dump: do not dump non-existent guest memory Laurent Vivier
2017-09-13 14:20 ` [Qemu-devel] " Laurent Vivier
2017-09-13 14:27 ` Cornelia Huck [this message]
2017-09-13 14:27 ` Cornelia Huck
2017-09-13 14:30 ` [Qemu-arm] " Laurent Vivier
2017-09-13 14:30 ` [Qemu-devel] " Laurent Vivier
2017-09-14 9:48 ` [Qemu-arm] " Dr. David Alan Gilbert
2017-09-14 9:48 ` [Qemu-devel] " Dr. David Alan Gilbert
2017-09-13 14:20 ` [Qemu-devel] [PATCH v4 4/4] tests/hmp: test "none" machine with memory Laurent Vivier
2017-09-13 14:20 ` Laurent Vivier
2017-09-14 9:50 ` [Qemu-arm] [PATCH v4 0/4] hmp: fix "dump-quest-memory" segfault Dr. David Alan Gilbert
2017-09-14 9:50 ` [Qemu-devel] " Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913162709.3933352d.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=berrange@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.