From: David Sterba <dsterba@suse.cz>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs: build: omit unnecessary -MD flag
Date: Thu, 14 Sep 2017 14:42:03 +0200 [thread overview]
Message-ID: <20170914124203.GT29043@suse.cz> (raw)
In-Reply-To: <150538385685.24503.15875606860945494531.stgit@naota.dhcp.fujisawa.hgst.com>
On Thu, Sep 14, 2017 at 07:10:56PM +0900, Naohiro Aota wrote:
> According to gcc(1), "-MD is equivalent to -M -MF file, except that -E is not
> implied." Since the rule in the Makefile is just generating dependency file
> and not building object file, it is no use to have "-MD" here. Also, it's
> overridden and conflicting with the following "-MM" flag. I guess we can drop
> it.
>
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Applied, thanks.
next prev parent reply other threads:[~2017-09-14 12:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 10:10 [PATCH 1/2] btrfs-progs: build: generate all dependency files Naohiro Aota
2017-09-14 10:10 ` [PATCH 2/2] btrfs: build: omit unnecessary -MD flag Naohiro Aota
2017-09-14 12:42 ` David Sterba [this message]
2017-09-14 12:41 ` [PATCH 1/2] btrfs-progs: build: generate all dependency files David Sterba
2017-09-15 2:34 ` Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170914124203.GT29043@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.