From: David Sterba <dsterba@suse.cz>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs-progs: build: generate all dependency files
Date: Thu, 14 Sep 2017 14:41:08 +0200 [thread overview]
Message-ID: <20170914124108.GS29043@suse.cz> (raw)
In-Reply-To: <150538384653.24503.41288304442819820.stgit@naota.dhcp.fujisawa.hgst.com>
On Thu, Sep 14, 2017 at 07:10:46PM +0900, Naohiro Aota wrote:
> We're missing several dependency files like:
>
> $ diff -u <(find -name '*.o'|cut -d. -f2|sort) <(find -name '*.o.d'|cut -d. -f2|sort)
> --- /proc/self/fd/11 2017-09-14 18:17:44.460564620 +0900
> +++ /proc/self/fd/12 2017-09-14 18:17:44.460564620 +0900
Please note that an actual diff in the changelog is understood as start
of the patch by git-am, indenting the --- or +++ lines makes it work
again.
> @@ -3,7 +3,6 @@
> /btrfs-corrupt-block
> /btrfs-debug-tree
> /btrfs-find-root
> -/btrfs-list
> /btrfs-map-logical
> /btrfs-select-super
> /btrfstune
> @@ -29,11 +28,6 @@
> /cmds-scrub
> /cmds-send
> /cmds-subvolume
> -/convert/common
> -/convert/main
> -/convert/source-ext2
> -/convert/source-fs
> -/convert/source-reiserfs
> /ctree
> /dir-item
> /disk-io
> <snip>
>
> This is due to moving things out of objects and cmds_objects variables. Such
> missing dependency files cause mis-building of some source files (try touch
> utils.h; make mkfs/main.o).
>
> This patch introduce a new variable "all_objects" to keep all the objects and
> use the variable to generate proper dependency file building rules.
>
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
Applied, thanks.
next prev parent reply other threads:[~2017-09-14 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 10:10 [PATCH 1/2] btrfs-progs: build: generate all dependency files Naohiro Aota
2017-09-14 10:10 ` [PATCH 2/2] btrfs: build: omit unnecessary -MD flag Naohiro Aota
2017-09-14 12:42 ` David Sterba
2017-09-14 12:41 ` David Sterba [this message]
2017-09-15 2:34 ` [PATCH 1/2] btrfs-progs: build: generate all dependency files Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170914124108.GS29043@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.