From: Pavel Machek <pavel@ucw.cz>
To: Alan Mizrahi <alan@mizrahi.com.ve>
Cc: Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 1/1] leds: Add driver for PC Engines APU/APU2 LEDs
Date: Sun, 17 Sep 2017 11:26:28 +0200 [thread overview]
Message-ID: <20170917092628.GA6107@amd> (raw)
In-Reply-To: <20170917033529.GA12375@olympus.mizrahi.com.ve>
[-- Attachment #1: Type: text/plain, Size: 922 bytes --]
On Sun 2017-09-17 12:35:29, Alan Mizrahi wrote:
> ---
Some kind of changeset comment would be nice here.
Did you solve the crashes? What was the problem?
Pavel
> +static struct apu_led_profile apu1_led_profile[] = {
> + { "apu:1", 1, APU1_FCH_GPIO_BASE + 0 * APU1_IOSIZE },
> + { "apu:2", LED_OFF, APU1_FCH_GPIO_BASE + 1 * APU1_IOSIZE },
> + { "apu:3", LED_OFF, APU1_FCH_GPIO_BASE + 2 * APU1_IOSIZE },
> +};
> +
> +static struct apu_led_profile apu2_led_profile[] = {
> + { "apu2:1", 1, APU2_FCH_GPIO_BASE + 68 * APU2_IOSIZE },
> + { "apu2:2", LED_OFF, APU2_FCH_GPIO_BASE + 69 * APU2_IOSIZE },
> + { "apu2:3", LED_OFF, APU2_FCH_GPIO_BASE + 70 * APU2_IOSIZE },
> +};
Do the leds have better names than 1/2/3? Are colors known?
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-09-17 9:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-17 3:35 [PATCH 1/1] leds: Add driver for PC Engines APU/APU2 LEDs Alan Mizrahi
2017-09-17 9:26 ` Pavel Machek [this message]
2017-09-17 12:17 ` Alan Mizrahi
2017-09-17 18:23 ` Pavel Machek
2017-09-21 20:46 ` Jacek Anaszewski
2017-09-24 0:30 ` Alan Mizrahi
2017-09-29 21:28 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170917092628.GA6107@amd \
--to=pavel@ucw.cz \
--cc=alan@mizrahi.com.ve \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.