Re: [PATCH 1/1] leds: Add driver for PC Engines APU/APU2 LEDs

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]

On Sun 2017-09-17 21:17:04, Alan Mizrahi wrote:
> On 2017-09-17 18:26, Pavel Machek wrote:
> > On Sun 2017-09-17 12:35:29, Alan Mizrahi wrote:
> >> ---
> > 
> > Some kind of changeset comment would be nice here.
> 
> That's true, sorry about that.
> 
> > Did you solve the crashes? What was the problem?
> 
> The problem was gone after using led_classdev_unregister(), as suggested
> by Jacek.  Thanks for the hint!
> 
> >> +static struct apu_led_profile apu1_led_profile[] = {
> >> +	{ "apu:1", 1,       APU1_FCH_GPIO_BASE + 0 * APU1_IOSIZE },
> >> +	{ "apu:2", LED_OFF, APU1_FCH_GPIO_BASE + 1 * APU1_IOSIZE },
> >> +	{ "apu:3", LED_OFF, APU1_FCH_GPIO_BASE + 2 * APU1_IOSIZE },
> >> +};
> >> +
> >> +static struct apu_led_profile apu2_led_profile[] = {
> >> +	{ "apu2:1", 1,       APU2_FCH_GPIO_BASE + 68 * APU2_IOSIZE },
> >> +	{ "apu2:2", LED_OFF, APU2_FCH_GPIO_BASE + 69 * APU2_IOSIZE },
> >> +	{ "apu2:3", LED_OFF, APU2_FCH_GPIO_BASE + 70 * APU2_IOSIZE },
> >> +};
> > 
> > Do the leds have better names than 1/2/3? Are colors known?
> 
> There are some drivers out there and they all used these names. I think
> using them would prevent confusions.  The enclosures for these devices
> don't have any labels for the leds such as "on" or "error", it's very
> generic.  They are all green.

Ok then, perhaps led can be named apu:green:1 ...?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]