[PATCH] staging: lustre: fix comparisons should place the constant on the right side

[PATCH] staging: lustre: fix comparisons should place the constant on the right side

[Aastha Gupta]

This patch fixes checkpatch.pl warning:

WARNING: Comparisons should place the constant on the right side of the test

Signed-off-by: Aastha Gupta <aastha.gupta4104@gmail.com>
---
 drivers/staging/lustre/lustre/include/lu_object.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lustre/include/lu_object.h b/drivers/staging/lustre/lustre/include/lu_object.h
index 4f213c4..a3c0481 100644
--- a/drivers/staging/lustre/lustre/include/lu_object.h
+++ b/drivers/staging/lustre/lustre/include/lu_object.h
@@ -1130,7 +1130,7 @@ struct lu_context_key {
 	{							 \
 		type *value;				      \
 								  \
-		BUILD_BUG_ON(PAGE_SIZE < sizeof(*value));        \
+		BUILD_BUG_ON(sizeof(*value) > PAGE_SIZE);        \
 								  \
 		value = kzalloc(sizeof(*value), GFP_NOFS);	\
 		if (!value)				\
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] staging: lustre: fix comparisons should place the constant on the right side

[Julia Lawall]

On Thu, 14 Sep 2017, Aastha Gupta wrote:

> This patch fixes checkpatch.pl warning:
>
> WARNING: Comparisons should place the constant on the right side of the test
>
> Signed-off-by: Aastha Gupta <aastha.gupta4104@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Technically, both sides are constants, but at least one side looks more
constant-like.

julia

> ---
>  drivers/staging/lustre/lustre/include/lu_object.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/include/lu_object.h b/drivers/staging/lustre/lustre/include/lu_object.h
> index 4f213c4..a3c0481 100644
> --- a/drivers/staging/lustre/lustre/include/lu_object.h
> +++ b/drivers/staging/lustre/lustre/include/lu_object.h
> @@ -1130,7 +1130,7 @@ struct lu_context_key {
>  	{							 \
>  		type *value;				      \
>  								  \
> -		BUILD_BUG_ON(PAGE_SIZE < sizeof(*value));        \
> +		BUILD_BUG_ON(sizeof(*value) > PAGE_SIZE);        \
>  								  \
>  		value = kzalloc(sizeof(*value), GFP_NOFS);	\
>  		if (!value)				\
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505389603-8642-1-git-send-email-aastha.gupta4104%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH] staging: lustre: fix comparisons should place the constant on the right side

[Greg Kroah-Hartman]

On Thu, Sep 14, 2017 at 05:16:43PM +0530, Aastha Gupta wrote:
> This patch fixes checkpatch.pl warning:
> 
> WARNING: Comparisons should place the constant on the right side of the test
> 
> Signed-off-by: Aastha Gupta <aastha.gupta4104@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>  drivers/staging/lustre/lustre/include/lu_object.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I see at least 11 different lustre patches from you that you have
recently sent out, but yet I have no idea what patch to apply in what
order :(

Please fix this up and resend all of them as a single patch series so I
have a chance to get this correct.

thanks,

greg k-h