All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx6: disable clock command and print_cpuinfo code in SPL
Date: Tue, 19 Sep 2017 14:18:56 +0200	[thread overview]
Message-ID: <20170919141856.12fb051a@crub> (raw)
In-Reply-To: <58344258-849d-2eb0-39f4-444178f2953e@denx.de>

Hi Stefano,

On Tue, 19 Sep 2017 09:54:30 +0200
Stefano Babic sbabic at denx.de wrote:
...
> This patch has some side-effects and breaks some boards. Even if the
> changes are correct, some boards (wandboard, icore are examples) don't
> disable IPU support in SPL. Even if this is useless and generates only a
> bigger footprint.
> 
> In fact, I get :
> 
>        arm:  +   wandboard
> +board/wandboard/built-in.o: In function `setup_display':
> +board/wandboard/wandboard.c:355: undefined reference to `enable_ipu_clock'
> +make[2]: *** [spl/u-boot-spl] Error 1
> +make[1]: *** [spl/u-boot-spl] Error 2
> +make: *** [sub-make] Error 2
> 
> 
> Reason is clear: boards have in SPL a setup_display() that calls
> enable_ipu_clock. But it makes no sense to have IPU support in SPL.
> 
> We can fix with a follow-up patch, but this is bad for bisecting. The
> other option is to fix here and disable IPU in spl for the affected
> boards. What you think ?

Sorry for the build breakage, I didn't test with a full imx6 build.
Yes, we shouldn't break bisection. I'll fix and resubmit. Thanks!

--
Anatolij

  reply	other threads:[~2017-09-19 12:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28 19:46 [U-Boot] [PATCH] imx6: disable clock command and print_cpuinfo code in SPL Anatolij Gustschin
2017-09-19  7:54 ` Stefano Babic
2017-09-19 12:18   ` Anatolij Gustschin [this message]
2017-09-20  3:18   ` Fabio Estevam
2017-09-20 11:22     ` Anatolij Gustschin
2017-09-20 13:04       ` Stefano Babic
2017-09-21  9:10         ` Max Krummenacher
2017-09-21 11:01           ` Anatolij Gustschin
2017-09-23  1:55       ` Fabio Estevam
2017-09-23 16:29         ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170919141856.12fb051a@crub \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.