From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Liang, Kan" <kan.liang@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"Odzioba, Lukasz" <lukasz.odzioba@intel.com>,
"ak@linux.intel.com" <ak@linux.intel.com>
Subject: Re: [PATCH RFC V2 00/10] perf top optimization
Date: Tue, 19 Sep 2017 11:24:05 -0300 [thread overview]
Message-ID: <20170919142405.GA29668@kernel.org> (raw)
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F077537C3FFB@SHSMSX103.ccr.corp.intel.com>
Em Tue, Sep 19, 2017 at 12:39:47PM +0000, Liang, Kan escreveu:
> > On Mon, Sep 18, 2017 at 10:01:00AM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Mon, Sep 18, 2017 at 10:57:08AM +0200, Jiri Olsa escreveu:
> > > > he proposed solution and it was changed&posted by Arnaldo in here:
> > > > https://marc.info/?l=linux-kernel&m=149132267410294&w=2
> > > > but looks like it never got merged
> > > > could you please add this or similar code before you add the locking
> > > > code/overhead in?
> > > I'm rehashing that patch and adding it on top of what is in my
> > > perf/core branch, will push soon, for now you can take a look at
> > tmp.perf/core.
> > checked the code.. one nit, could we have single threaded by default?
> > only one command is multithreaded atm, it could call perf_set_multihreaded
> > instead of all current related commands call perf_set_singlethreaded
> I agree with single threaded as default setting, also I think we need both
> functions, perf_set_multihreaded and perf_set_singlethreaded.
> Perf tools probably be half single threaded and half multithreaded.
> E.g. the perf top optimization. Only the events synthesize codes are
> multithreaded. So we have to set multithreaded first, then change it
> to single threaded.
Ok, agreed with both of you, i.e. I'll make it single threaded by
default, and provide both functions, this way we get a default that is
what most tools use, and a way to select multithreaded mode for when it
is needed, then going back to single threaded.
- Arnaldo
prev parent reply other threads:[~2017-09-19 14:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 2:23 [PATCH RFC V2 00/10] perf top optimization kan.liang
2017-09-11 2:23 ` [PATCH RFC V2 01/10] perf tools: hashtable for machine threads kan.liang
2017-09-13 13:29 ` Arnaldo Carvalho de Melo
2017-09-22 16:42 ` [tip:perf/core] perf machine: Use " tip-bot for Kan Liang
2017-09-11 2:23 ` [PATCH RFC V2 02/10] perf tools: using scandir to replace readdir kan.liang
2017-09-13 15:19 ` Arnaldo Carvalho de Melo
2017-09-11 2:23 ` [PATCH RFC V2 03/10] petf tools: using comm_str to replace comm in hist_entry kan.liang
2017-09-13 15:21 ` Arnaldo Carvalho de Melo
2017-09-18 8:38 ` Jiri Olsa
2017-09-11 2:23 ` [PATCH RFC V2 04/10] petf tools: introduce a new function to set namespaces id kan.liang
2017-09-11 2:23 ` [PATCH RFC V2 05/10] perf tools: lock to protect thread list kan.liang
2017-09-18 8:50 ` Jiri Olsa
2017-09-18 16:18 ` Liang, Kan
2017-09-11 2:23 ` [PATCH RFC V2 06/10] perf tools: lock to protect comm_str rb tree kan.liang
2017-09-11 2:23 ` [PATCH RFC V2 07/10] perf tools: change machine comm_exec type to atomic kan.liang
2017-09-13 15:24 ` Arnaldo Carvalho de Melo
2017-09-15 20:05 ` Liang, Kan
2017-09-18 11:30 ` Jiri Olsa
2017-09-11 2:23 ` [PATCH RFC V2 08/10] perf top: implement multithreading for perf_event__synthesize_threads kan.liang
2017-09-18 11:24 ` Jiri Olsa
2017-09-11 2:23 ` [PATCH RFC V2 09/10] perf top: add option to set the number of thread for event synthesize kan.liang
2017-09-11 2:23 ` [PATCH RFC V2 10/10] perf top: switch back to overwrite mode kan.liang
2017-09-13 15:25 ` [PATCH RFC V2 00/10] perf top optimization Arnaldo Carvalho de Melo
2017-09-13 15:29 ` Liang, Kan
2017-09-13 15:38 ` Arnaldo Carvalho de Melo
2017-09-14 21:19 ` Arnaldo Carvalho de Melo
2017-09-15 15:11 ` Liang, Kan
2017-09-15 17:26 ` Arnaldo Carvalho de Melo
2017-09-15 17:29 ` Liang, Kan
2017-09-15 18:24 ` Arnaldo Carvalho de Melo
2017-09-15 18:26 ` Liang, Kan
2017-09-18 8:57 ` Jiri Olsa
2017-09-18 13:01 ` Arnaldo Carvalho de Melo
2017-09-18 16:21 ` Liang, Kan
2017-09-19 8:19 ` Jiri Olsa
2017-09-19 12:39 ` Liang, Kan
2017-09-19 14:24 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919142405.GA29668@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.odzioba@intel.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.