From: Tejun Heo <tj@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: linux-ide@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V3] libata: make static arrays const, reduces object code size
Date: Tue, 19 Sep 2017 18:54:04 +0000 [thread overview]
Message-ID: <20170919185404.GA828415@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20170919083952.5648-1-colin.king@canonical.com>
On Tue, Sep 19, 2017 at 09:39:52AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const arrayis on the stack, instead make them static.
> Makes the object code smaller by over 260 bytes:
>
> Before:
> text data bss dec hex filename
> 64864 5948 4128 74940 124bc drivers/ata/libata-scsi.o
>
> After:
> text data bss dec hex filename
> 64183 6364 4128 74675 123b3 drivers/ata/libata-scsi.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to libata/for-4.15.
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: linux-ide@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V3] libata: make static arrays const, reduces object code size
Date: Tue, 19 Sep 2017 11:54:04 -0700 [thread overview]
Message-ID: <20170919185404.GA828415@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20170919083952.5648-1-colin.king@canonical.com>
On Tue, Sep 19, 2017 at 09:39:52AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const arrayis on the stack, instead make them static.
> Makes the object code smaller by over 260 bytes:
>
> Before:
> text data bss dec hex filename
> 64864 5948 4128 74940 124bc drivers/ata/libata-scsi.o
>
> After:
> text data bss dec hex filename
> 64183 6364 4128 74675 123b3 drivers/ata/libata-scsi.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to libata/for-4.15.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-09-19 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 8:39 [PATCH][V3] libata: make static arrays const, reduces object code size Colin King
2017-09-19 8:39 ` Colin King
2017-09-19 18:54 ` Tejun Heo [this message]
2017-09-19 18:54 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919185404.GA828415@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.