* [PATCH] memory-barriers.txt: Fix typo in pairing example
@ 2017-09-19 18:16 Scott Tsai
2017-09-19 22:59 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Scott Tsai @ 2017-09-19 18:16 UTC (permalink / raw)
To: paulmck; +Cc: linux-kernel, Scott Tsai
In the "general barrier pairing with implicit control depdendency"
example, the last write by CPU 1 was meant to change variable x and not
y. The example would be pretty uninteresting if no CPU ever changes x
and the variable was initialized to zero.
Signed-off-by: Scott Tsai <scottt@scottt.tw>
---
Documentation/memory-barriers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
index b759a60624fd..468894a705a9 100644
--- a/Documentation/memory-barriers.txt
+++ b/Documentation/memory-barriers.txt
@@ -968,7 +968,7 @@ Or even:
=============== ===============================
r1 = READ_ONCE(y);
<general barrier>
- WRITE_ONCE(y, 1); if (r2 = READ_ONCE(x)) {
+ WRITE_ONCE(x, 1); if (r2 = READ_ONCE(x)) {
<implicit control dependency>
WRITE_ONCE(y, 1);
}
--
2.13.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] memory-barriers.txt: Fix typo in pairing example
2017-09-19 18:16 [PATCH] memory-barriers.txt: Fix typo in pairing example Scott Tsai
@ 2017-09-19 22:59 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2017-09-19 22:59 UTC (permalink / raw)
To: Scott Tsai; +Cc: linux-kernel
On Wed, Sep 20, 2017 at 02:16:00AM +0800, Scott Tsai wrote:
> In the "general barrier pairing with implicit control depdendency"
> example, the last write by CPU 1 was meant to change variable x and not
> y. The example would be pretty uninteresting if no CPU ever changes x
> and the variable was initialized to zero.
>
> Signed-off-by: Scott Tsai <scottt@scottt.tw>
Queued for review, thank you!!!
Thanx, Paul
> ---
> Documentation/memory-barriers.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
> index b759a60624fd..468894a705a9 100644
> --- a/Documentation/memory-barriers.txt
> +++ b/Documentation/memory-barriers.txt
> @@ -968,7 +968,7 @@ Or even:
> =============== ===============================
> r1 = READ_ONCE(y);
> <general barrier>
> - WRITE_ONCE(y, 1); if (r2 = READ_ONCE(x)) {
> + WRITE_ONCE(x, 1); if (r2 = READ_ONCE(x)) {
> <implicit control dependency>
> WRITE_ONCE(y, 1);
> }
> --
> 2.13.5
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-19 22:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-19 18:16 [PATCH] memory-barriers.txt: Fix typo in pairing example Scott Tsai
2017-09-19 22:59 ` Paul E. McKenney
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.