From: clabbe.montjoie@gmail.com (Corentin Labbe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: sun6i: sun4i-gpadc: use of_device_get_match_data
Date: Wed, 20 Sep 2017 09:21:22 +0200 [thread overview]
Message-ID: <20170920072122.GA19920@Red> (raw)
In-Reply-To: <20170920065814.fle73gxbu3oyqsr4@flea.home>
On Wed, Sep 20, 2017 at 08:58:14AM +0200, Maxime Ripard wrote:
> Hi,
>
> On Tue, Sep 19, 2017 at 06:44:47PM +0000, Corentin Labbe wrote:
> > The usage of of_device_get_match_data reduce the code size a bit.
> > Furthermore, it prevents an improbable dereference when
> > of_match_device() return NULL.
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> The prefix of your commit title is wrong, this isn't about the GPADC.
>
> Once fixed,
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Maxime
>
A copy/paste error, sorry
I will resend
thanks
Corentin Labbe
WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: vinod.koul@intel.com, dan.j.williams@intel.com, wens@csie.org,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: sun6i: sun4i-gpadc: use of_device_get_match_data
Date: Wed, 20 Sep 2017 09:21:22 +0200 [thread overview]
Message-ID: <20170920072122.GA19920@Red> (raw)
In-Reply-To: <20170920065814.fle73gxbu3oyqsr4@flea.home>
On Wed, Sep 20, 2017 at 08:58:14AM +0200, Maxime Ripard wrote:
> Hi,
>
> On Tue, Sep 19, 2017 at 06:44:47PM +0000, Corentin Labbe wrote:
> > The usage of of_device_get_match_data reduce the code size a bit.
> > Furthermore, it prevents an improbable dereference when
> > of_match_device() return NULL.
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> The prefix of your commit title is wrong, this isn't about the GPADC.
>
> Once fixed,
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>
> Maxime
>
A copy/paste error, sorry
I will resend
thanks
Corentin Labbe
next prev parent reply other threads:[~2017-09-20 7:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 18:44 [PATCH] dmaengine: sun6i: sun4i-gpadc: use of_device_get_match_data Corentin Labbe
2017-09-19 18:44 ` Corentin Labbe
2017-09-20 6:58 ` Maxime Ripard
2017-09-20 6:58 ` Maxime Ripard
2017-09-20 7:21 ` Corentin Labbe [this message]
2017-09-20 7:21 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920072122.GA19920@Red \
--to=clabbe.montjoie@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.