From: Kalle Valo <kvalo@codeaurora.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Amitkumar Karwar <amitkarwar@gmail.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>, Xinming Hu <huxm@marvell.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: mwifiex: make const arrays static to shink object code size
Date: Wed, 20 Sep 2017 12:47:40 +0000 [thread overview]
Message-ID: <20170920124740.CCDD160912@smtp.codeaurora.org> (raw)
In-Reply-To: <20170916153424.28285-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const arrays on the stack, instead make them static
> Makes the object code smaller by nearly 300 bytes:
>
> Before:
> text data bss dec hex filename
> 69260 16149 576 85985 14fe1 cfg80211.o
>
> After:
> text data bss dec hex filename
> 68385 16725 576 85686 14eb6 cfg80211.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
d157bcfaf854 mwifiex: make const arrays static to shink object code size
--
https://patchwork.kernel.org/patch/9954375/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Amitkumar Karwar <amitkarwar@gmail.com>,
Nishant Sarmukadam <nishants@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>, Xinming Hu <huxm@marvell.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: mwifiex: make const arrays static to shink object code size
Date: Wed, 20 Sep 2017 12:47:40 +0000 (UTC) [thread overview]
Message-ID: <20170920124740.CCDD160912@smtp.codeaurora.org> (raw)
In-Reply-To: <20170916153424.28285-1-colin.king@canonical.com>
Colin Ian King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate const arrays on the stack, instead make them static
> Makes the object code smaller by nearly 300 bytes:
>
> Before:
> text data bss dec hex filename
> 69260 16149 576 85985 14fe1 cfg80211.o
>
> After:
> text data bss dec hex filename
> 68385 16725 576 85686 14eb6 cfg80211.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied to wireless-drivers-next.git, thanks.
d157bcfaf854 mwifiex: make const arrays static to shink object code size
--
https://patchwork.kernel.org/patch/9954375/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2017-09-20 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-16 15:34 [PATCH] mwifiex: make const arrays static to shink object code size Colin King
2017-09-16 15:34 ` Colin King
2017-09-20 12:47 ` Kalle Valo [this message]
2017-09-20 12:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920124740.CCDD160912@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=colin.king@canonical.com \
--cc=gbhat@marvell.com \
--cc=huxm@marvell.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.