* Re: [PATCH] component-meta: Adding component meta information
2017-09-20 19:54 ` Denys Dmytriyenko
@ 2017-09-20 20:03 ` Radhakrishnan, Mahesh
0 siblings, 0 replies; 3+ messages in thread
From: Radhakrishnan, Mahesh @ 2017-09-20 20:03 UTC (permalink / raw)
To: Dmytriyenko, Denys; +Cc: meta-ti@yoctoproject.org
[-- Attachment #1: Type: text/plain, Size: 2256 bytes --]
Hi Denys,
Sorry, I thought I had not pushed the patch earlier, and missed the thread (attached)
I will resolve the name, description & push this to meta-processor-sdk .
Justin,
Can you share the description to the class?
The name is going to be 'comp-install-meta' then?
Regards
Machu.
-----Original Message-----
From: Dmytriyenko, Denys
Sent: Wednesday, September 20, 2017 3:55 PM
To: Radhakrishnan, Mahesh
Cc: meta-ti@yoctoproject.org
Subject: Re: [meta-ti] [PATCH] component-meta: Adding component meta information
NAK, this has been discussed in the past...
On Wed, Sep 20, 2017 at 11:37:30AM -0400, Mahesh Radhakrishnan wrote:
> Class for adding component meta information
>
> Signed-off-by: Mahesh Radhakrishnan <m-radhakrishnan2@ti.com>
> ---
> classes/component_meta.bbclass | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 classes/component_meta.bbclass
>
> diff --git a/classes/component_meta.bbclass
> b/classes/component_meta.bbclass new file mode 100644 index
> 0000000..f2dc754
> --- /dev/null
> +++ b/classes/component_meta.bbclass
> @@ -0,0 +1,29 @@
> +CM_NAME ?= ""
> +CM_VERSION ?= ""
> +CM_ROOT_DIR ?= ""
> +CM_BINARY ?= ""
> +CM_DESCRIPTION ?= ""
> +
> +do_component_meta() {
> + if [ ! -d "${DEPLOY_DIR_IMAGE}" ]
> + then
> + mkdir -p ${DEPLOY_DIR_IMAGE}
> + fi
> +
> + if [ ! -e "${DEPLOY_DIR_IMAGE}/.components_meta" ]
> + then
> + touch ${DEPLOY_DIR_IMAGE}/.components_meta
> + fi
> +
> + # Check if component is already documented in .components_meta
> + if ! grep -q "${CM_ROOT_DIR}" ${DEPLOY_DIR_IMAGE}/.components_meta
> + then
> + # Add component meta information
> + echo "${CM_NAME}|${CM_VERSION}|${CM_ROOT_DIR}|${CM_BINARY}|${CM_DESCRIPTION}" >> \
> + ${DEPLOY_DIR_IMAGE}/.components_meta
> + fi
> +}
> +
> +do_component_meta[lockfiles] = "${DEPLOY_DIR_IMAGE}/component_meta.lock"
> +
> +addtask do_component_meta after do_install before do_package
> --
> 1.9.1
>
> --
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
[-- Attachment #2: Type: message/rfc822, Size: 5392 bytes --]
From: "Sobota, Justin" <jsobota@ti.com>
To: "Dmytriyenko, Denys" <denys@ti.com>
Cc: "Radhakrishnan, Mahesh" <m-radhakrishnan2@ti.com>, "yocto-support@list.ti.com - Arago/Yocto/OpenEmbedded/TI-SDK internal support (May contain non-TIers)" <yocto-support@list.ti.com>
Subject: RE: [yocto-support] Re: [meta-ti] [PATCH] component_meta: Adding component_meta bbclass
Date: Tue, 18 Jul 2017 14:53:45 +0000
Message-ID: <311ECDE3E284F649854AED0B108A0CE14C0C8899@DFLE12.ent.ti.com>
> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Monday, July 17, 2017 7:31 PM
> To: Sobota, Justin
> Cc: Radhakrishnan, Mahesh; yocto-support@list.ti.com -
> Arago/Yocto/OpenEmbedded/TI-SDK internal support (May contain non-
> TIers)
> Subject: Re: [yocto-support] Re: [meta-ti] [PATCH] component_meta:
> Adding component_meta bbclass
>
> Thanks, Justin,
>
> Couple followup questions:
>
> 1. Can we come up with less generic name? Maybe with "install" word in the
> name? Also would be nice to have some short comment about the class at
> the beginning of the file.
How about "comp_install_meta"?
I'll add a description to the top of the class.
>
> 2. Can this be added to meta-arago instead? This sounds to me as a distro
> feature, instead of BSP one. And meta-ti is for BSP recipes and machine
> configs, while meta-arago is for apps recipes and distro configs.
>
I'm fine with this. Machu please upstream this to meta-arago after we resolve the naming and I update the class with a description.
> --
> Denys
>
>
> On Wed, Jul 12, 2017 at 11:48:48PM -0400, Sobota, Justin wrote:
> > Denys,
> >
> > This class is used by components to generate metadata which is used by
> our
> > InstallBuilder SDK creation scripts to generate the component selection
> menu
> > in the installer. Down the road there are plans to use the metadata to
> > auto-populate some of the SDK environment setup and makefile scripts
> which
> > have component versions within them.
> >
> > Justin
> >
> > > -----Original Message-----
> > > From: Dmytriyenko, Denys
> > > Sent: Tuesday, July 11, 2017 7:05 PM
> > > To: Radhakrishnan, Mahesh
> > > Cc: yocto-support@list.ti.com - Arago/Yocto/OpenEmbedded/TI-SDK
> internal
> > > support (May contain non-TIers)
> > > Subject: [yocto-support] Re: [meta-ti] [PATCH] component_meta:
> Adding
> > > component_meta bbclass
> > >
> > > -> internal list.
> > >
> > > No description - what's this? why is it needed?
> > >
> > >
> > > On Thu, Jul 06, 2017 at 12:26:57PM -0400, Mahesh Radhakrishnan wrote:
> > > > Signed-off-by: Mahesh Radhakrishnan <m-radhakrishnan2@ti.com>
> > > > ---
> > > > classes/component_meta.bbclass | 29
> > > +++++++++++++++++++++++++++++
> > > > 1 file changed, 29 insertions(+)
> > > > create mode 100644 classes/component_meta.bbclass
> > > >
> > > > diff --git a/classes/component_meta.bbclass
> > > > b/classes/component_meta.bbclass new file mode 100644 index
> > > > 0000000..f2dc754
> > > > --- /dev/null
> > > > +++ b/classes/component_meta.bbclass
> > > > @@ -0,0 +1,29 @@
> > > > +CM_NAME ?= ""
> > > > +CM_VERSION ?= ""
> > > > +CM_ROOT_DIR ?= ""
> > > > +CM_BINARY ?= ""
> > > > +CM_DESCRIPTION ?= ""
> > > > +
> > > > +do_component_meta() {
> > > > + if [ ! -d "${DEPLOY_DIR_IMAGE}" ]
> > > > + then
> > > > + mkdir -p ${DEPLOY_DIR_IMAGE}
> > > > + fi
> > > > +
> > > > + if [ ! -e "${DEPLOY_DIR_IMAGE}/.components_meta" ]
> > > > + then
> > > > + touch ${DEPLOY_DIR_IMAGE}/.components_meta
> > > > + fi
> > > > +
> > > > + # Check if component is already documented in .components_meta
> > > > + if ! grep -q "${CM_ROOT_DIR}"
> > > ${DEPLOY_DIR_IMAGE}/.components_meta
> > > > + then
> > > > + # Add component meta information
> > > > + echo
> > >
> "${CM_NAME}|${CM_VERSION}|${CM_ROOT_DIR}|${CM_BINARY}|${CM_
> > > DESCRIPTION}" >> \
> > > > + ${DEPLOY_DIR_IMAGE}/.components_meta
> > > > + fi
> > > > +}
> > > > +
> > > > +do_component_meta[lockfiles] =
> > > "${DEPLOY_DIR_IMAGE}/component_meta.lock"
> > > > +
> > > > +addtask do_component_meta after do_install before do_package
> > > > --
> > > > 1.9.1
> > > >
> > > > --
> > > > _______________________________________________
> > > > meta-ti mailing list
> > > > meta-ti@yoctoproject.org
> > > > https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 3+ messages in thread