From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: perag initialization should only touch m_ag_max_usable for AG 0
Date: Thu, 21 Sep 2017 07:04:21 -0700 [thread overview]
Message-ID: <20170921140421.GA24142@infradead.org> (raw)
In-Reply-To: <20170919181041.GC7112@magnolia>
On Tue, Sep 19, 2017 at 11:10:41AM -0700, Darrick J. Wong wrote:
> We call __xfs_ag_resv_init to make a per-AG reservation for each AG.
> This makes the reservation per-AG, not per-filesystem. Therefore, it
> is incorrect to adjust m_ag_max_usable for each AG. Adjust it only
> when we're reserving AG 0's blocks so that we only do it once per fs.
This looks correct to me, but I hate how we manipulate a per-mount
value. Is there a way we can just move this to the caller?
next prev parent reply other threads:[~2017-09-21 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 18:10 [PATCH] xfs: perag initialization should only touch m_ag_max_usable for AG 0 Darrick J. Wong
2017-09-20 13:23 ` Brian Foster
2017-09-21 14:04 ` Christoph Hellwig [this message]
2017-09-21 17:12 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921140421.GA24142@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.