From: Vinod Koul <vinod.koul@intel.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: linux-kernel@vger.kernel.org, t-kristo@ti.com,
dmaengine@vger.kernel.org, dan.j.williams@intel.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] dmaengine: omap-dma: Implement protection for invalid max_burst
Date: Thu, 21 Sep 2017 22:42:08 +0530 [thread overview]
Message-ID: <20170921171208.GF30097@localhost> (raw)
In-Reply-To: <20170912104424.18495-3-peter.ujfalusi@ti.com>
On Tue, Sep 12, 2017 at 01:44:21PM +0300, Peter Ujfalusi wrote:
> Set the device's max_burst to 16777215 (EN is 24bit unsigned value) so
> clients can take this into consideration when setting up the trasnfer.
ditto :D
>
> During slave transfer preparation check if the requested maxburst is valid.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/dma/omap-dma.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
> index 8c1665c8fe33..f6dd849159d8 100644
> --- a/drivers/dma/omap-dma.c
> +++ b/drivers/dma/omap-dma.c
> @@ -1288,6 +1288,10 @@ static int omap_dma_slave_config(struct dma_chan *chan, struct dma_slave_config
> cfg->dst_addr_width == DMA_SLAVE_BUSWIDTH_8_BYTES)
> return -EINVAL;
>
> + if (cfg->src_maxburst > chan->device->max_burst ||
> + cfg->dst_maxburst > chan->device->max_burst)
> + return -EINVAL;
> +
> memcpy(&c->cfg, cfg, sizeof(c->cfg));
>
> return 0;
> @@ -1482,6 +1486,7 @@ static int omap_dma_probe(struct platform_device *pdev)
> od->ddev.dst_addr_widths = OMAP_DMA_BUSWIDTHS;
> od->ddev.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
> od->ddev.residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
> + od->ddev.max_burst = SZ_16M - 1; /* CCEN: 24bit unsigned */
> od->ddev.dev = &pdev->dev;
> INIT_LIST_HEAD(&od->ddev.channels);
> spin_lock_init(&od->lock);
> --
> 2.14.1
>
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
>
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] dmaengine: omap-dma: Implement protection for invalid max_burst
Date: Thu, 21 Sep 2017 22:42:08 +0530 [thread overview]
Message-ID: <20170921171208.GF30097@localhost> (raw)
In-Reply-To: <20170912104424.18495-3-peter.ujfalusi@ti.com>
On Tue, Sep 12, 2017 at 01:44:21PM +0300, Peter Ujfalusi wrote:
> Set the device's max_burst to 16777215 (EN is 24bit unsigned value) so
> clients can take this into consideration when setting up the trasnfer.
ditto :D
>
> During slave transfer preparation check if the requested maxburst is valid.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/dma/omap-dma.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
> index 8c1665c8fe33..f6dd849159d8 100644
> --- a/drivers/dma/omap-dma.c
> +++ b/drivers/dma/omap-dma.c
> @@ -1288,6 +1288,10 @@ static int omap_dma_slave_config(struct dma_chan *chan, struct dma_slave_config
> cfg->dst_addr_width == DMA_SLAVE_BUSWIDTH_8_BYTES)
> return -EINVAL;
>
> + if (cfg->src_maxburst > chan->device->max_burst ||
> + cfg->dst_maxburst > chan->device->max_burst)
> + return -EINVAL;
> +
> memcpy(&c->cfg, cfg, sizeof(c->cfg));
>
> return 0;
> @@ -1482,6 +1486,7 @@ static int omap_dma_probe(struct platform_device *pdev)
> od->ddev.dst_addr_widths = OMAP_DMA_BUSWIDTHS;
> od->ddev.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
> od->ddev.residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
> + od->ddev.max_burst = SZ_16M - 1; /* CCEN: 24bit unsigned */
> od->ddev.dev = &pdev->dev;
> INIT_LIST_HEAD(&od->ddev.channels);
> spin_lock_init(&od->lock);
> --
> 2.14.1
>
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
>
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, t-kristo@ti.com
Subject: Re: [PATCH 2/5] dmaengine: omap-dma: Implement protection for invalid max_burst
Date: Thu, 21 Sep 2017 22:42:08 +0530 [thread overview]
Message-ID: <20170921171208.GF30097@localhost> (raw)
In-Reply-To: <20170912104424.18495-3-peter.ujfalusi@ti.com>
On Tue, Sep 12, 2017 at 01:44:21PM +0300, Peter Ujfalusi wrote:
> Set the device's max_burst to 16777215 (EN is 24bit unsigned value) so
> clients can take this into consideration when setting up the trasnfer.
ditto :D
>
> During slave transfer preparation check if the requested maxburst is valid.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> drivers/dma/omap-dma.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
> index 8c1665c8fe33..f6dd849159d8 100644
> --- a/drivers/dma/omap-dma.c
> +++ b/drivers/dma/omap-dma.c
> @@ -1288,6 +1288,10 @@ static int omap_dma_slave_config(struct dma_chan *chan, struct dma_slave_config
> cfg->dst_addr_width == DMA_SLAVE_BUSWIDTH_8_BYTES)
> return -EINVAL;
>
> + if (cfg->src_maxburst > chan->device->max_burst ||
> + cfg->dst_maxburst > chan->device->max_burst)
> + return -EINVAL;
> +
> memcpy(&c->cfg, cfg, sizeof(c->cfg));
>
> return 0;
> @@ -1482,6 +1486,7 @@ static int omap_dma_probe(struct platform_device *pdev)
> od->ddev.dst_addr_widths = OMAP_DMA_BUSWIDTHS;
> od->ddev.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
> od->ddev.residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
> + od->ddev.max_burst = SZ_16M - 1; /* CCEN: 24bit unsigned */
> od->ddev.dev = &pdev->dev;
> INIT_LIST_HEAD(&od->ddev.channels);
> spin_lock_init(&od->lock);
> --
> 2.14.1
>
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
>
--
~Vinod
next prev parent reply other threads:[~2017-09-21 17:12 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 10:44 [PATCH 0/5] dmaengine: core/edma/omap-dma: maximum SG len reporting Peter Ujfalusi
2017-09-12 10:44 ` Peter Ujfalusi
2017-09-12 10:44 ` Peter Ujfalusi
2017-09-12 10:44 ` [PATCH 1/5] dmaengine: edma: Implement protection for invalid max_burst Peter Ujfalusi
2017-09-12 10:44 ` Peter Ujfalusi
2017-09-12 10:44 ` Peter Ujfalusi
2017-09-21 17:10 ` Vinod Koul
2017-09-21 17:10 ` Vinod Koul
2017-09-21 17:10 ` Vinod Koul
2017-09-12 10:44 ` [PATCH 2/5] dmaengine: omap-dma: " Peter Ujfalusi
2017-09-12 10:44 ` Peter Ujfalusi
2017-09-12 10:44 ` Peter Ujfalusi
2017-09-21 17:12 ` Vinod Koul [this message]
2017-09-21 17:12 ` Vinod Koul
2017-09-21 17:12 ` Vinod Koul
2017-09-12 10:44 ` [PATCH 3/5] dmaengine: Support for querying maximum trasnfer length (of an SG element) Peter Ujfalusi
2017-09-12 10:44 ` Peter Ujfalusi
2017-09-12 10:44 ` Peter Ujfalusi
2017-09-21 17:14 ` Vinod Koul
2017-09-21 17:14 ` Vinod Koul
2017-09-21 17:14 ` Vinod Koul
2017-09-22 9:39 ` Peter Ujfalusi
2017-09-22 9:39 ` Peter Ujfalusi
2017-09-22 9:39 ` Peter Ujfalusi
2017-09-26 16:54 ` Vinod Koul
2017-09-26 16:54 ` Vinod Koul
2017-10-02 11:24 ` Peter Ujfalusi
2017-10-02 11:24 ` Peter Ujfalusi
2017-10-02 11:24 ` Peter Ujfalusi
2017-10-08 5:25 ` Vinod Koul
2017-10-08 5:25 ` Vinod Koul
2017-10-11 15:47 ` Peter Ujfalusi
2017-10-11 15:47 ` Peter Ujfalusi
2017-10-11 15:47 ` Peter Ujfalusi
2017-10-12 13:57 ` Vinod Koul
2017-10-12 13:57 ` Vinod Koul
2017-09-12 10:44 ` [PATCH 4/5] dmaengine: edma: Implement device_get_max_len callback Peter Ujfalusi
2017-09-12 10:44 ` Peter Ujfalusi
2017-09-12 10:44 ` Peter Ujfalusi
2017-09-12 10:44 ` [PATCH 5/5] dmaengine: omap-dma: " Peter Ujfalusi
2017-09-12 10:44 ` Peter Ujfalusi
2017-09-12 10:44 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921171208.GF30097@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.