All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <keith.busch@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org, linux-block@vger.kernel.org
Subject: Re: [PATCH 9/9] nvme: implement multipath access to nvme subsystems
Date: Thu, 21 Sep 2017 17:12:46 -0400	[thread overview]
Message-ID: <20170921211246.GB10713@localhost.localdomain> (raw)
In-Reply-To: <20170920235250.GA28865@lst.de>

On Thu, Sep 21, 2017 at 01:52:50AM +0200, Christoph Hellwig wrote:
> I noticed the odd renaming in sysfs and though about gettind rid
> of the /dev/nvme/ directory.  I just need to come up with a good
> name for the device nodes - the name can't contain /dev/nvme* as
> nvme-cli would break if it sees files that start with nvme in /dev/.

Ah, didn't know that. I'll fix nvme-cli to handle this.

We can still use a different naming convention for the multipath handles.

> /dev/nvmN ?

Looks safe.

BTW, considered persistent nameing rules to symlink these from
/dev/disk/by-id/? May need to add an attribute to the multipath object
to assist that.

WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 9/9] nvme: implement multipath access to nvme subsystems
Date: Thu, 21 Sep 2017 17:12:46 -0400	[thread overview]
Message-ID: <20170921211246.GB10713@localhost.localdomain> (raw)
In-Reply-To: <20170920235250.GA28865@lst.de>

On Thu, Sep 21, 2017@01:52:50AM +0200, Christoph Hellwig wrote:
> I noticed the odd renaming in sysfs and though about gettind rid
> of the /dev/nvme/ directory.  I just need to come up with a good
> name for the device nodes - the name can't contain /dev/nvme* as
> nvme-cli would break if it sees files that start with nvme in /dev/.

Ah, didn't know that. I'll fix nvme-cli to handle this.

We can still use a different naming convention for the multipath handles.

> /dev/nvmN ?

Looks safe.

BTW, considered persistent nameing rules to symlink these from
/dev/disk/by-id/? May need to add an attribute to the multipath object
to assist that.

  reply	other threads:[~2017-09-21 21:12 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-18 23:14 nvme multipath support V2 Christoph Hellwig
2017-09-18 23:14 ` Christoph Hellwig
2017-09-18 23:14 ` [PATCH 1/9] nvme: allow timed-out ios to retry Christoph Hellwig
2017-09-18 23:14   ` Christoph Hellwig
2017-09-18 23:14 ` [PATCH 2/9] block: move REQ_NOWAIT Christoph Hellwig
2017-09-18 23:14   ` Christoph Hellwig
2017-09-18 23:14 ` [PATCH 3/9] block: add REQ_DRV bit Christoph Hellwig
2017-09-18 23:14   ` Christoph Hellwig
2017-09-18 23:14 ` [PATCH 4/9] block: provide a direct_make_request helper Christoph Hellwig
2017-09-18 23:14   ` Christoph Hellwig
2017-09-18 23:14 ` [PATCH 5/9] block: add a blk_steal_bios helper Christoph Hellwig
2017-09-18 23:14   ` Christoph Hellwig
2017-09-18 23:14 ` [PATCH 6/9] nvme: track subsystems Christoph Hellwig
2017-09-18 23:14   ` Christoph Hellwig
2017-09-21 22:52   ` Keith Busch
2017-09-21 22:52     ` Keith Busch
2017-09-18 23:14 ` [PATCH 7/9] nvme: introduce a nvme_ns_ids structure Christoph Hellwig
2017-09-18 23:14   ` Christoph Hellwig
2017-09-20  8:27   ` Johannes Thumshirn
2017-09-20  8:27     ` Johannes Thumshirn
2017-09-18 23:14 ` [PATCH 8/9] nvme: track shared namespaces Christoph Hellwig
2017-09-18 23:14   ` Christoph Hellwig
2017-09-20  8:36   ` Johannes Thumshirn
2017-09-20  8:36     ` Johannes Thumshirn
2017-09-20 14:54     ` Christoph Hellwig
2017-09-20 14:54       ` Christoph Hellwig
2017-09-21  5:22       ` Johannes Thumshirn
2017-09-21  5:22         ` Johannes Thumshirn
2017-09-21 14:37         ` Christoph Hellwig
2017-09-21 14:37           ` Christoph Hellwig
2017-09-21 15:16           ` Keith Busch
2017-09-21 15:16             ` Keith Busch
2017-09-24 15:25             ` Christoph Hellwig
2017-09-24 15:25               ` Christoph Hellwig
2017-09-18 23:14 ` [PATCH 9/9] nvme: implement multipath access to nvme subsystems Christoph Hellwig
2017-09-18 23:14   ` Christoph Hellwig
2017-09-20  0:18   ` Tony Yang
2017-09-20  0:18     ` Tony Yang
2017-09-20  8:15     ` Johannes Thumshirn
2017-09-20  8:15       ` Johannes Thumshirn
2017-09-20  9:42   ` Johannes Thumshirn
2017-09-20  9:42     ` Johannes Thumshirn
2017-09-20 22:58   ` Keith Busch
2017-09-20 22:58     ` Keith Busch
2017-09-20 23:52     ` Christoph Hellwig
2017-09-20 23:52       ` Christoph Hellwig
2017-09-21 21:12       ` Keith Busch [this message]
2017-09-21 21:12         ` Keith Busch
2017-09-24 14:42         ` Christoph Hellwig
2017-09-24 14:42           ` Christoph Hellwig
2017-09-22 15:09   ` Keith Busch
2017-09-22 15:09     ` Keith Busch
2017-09-24 14:48     ` Christoph Hellwig
2017-09-24 14:48       ` Christoph Hellwig
2017-09-20 11:09 ` nvme multipath support V2 Johannes Thumshirn
2017-09-20 11:09   ` Johannes Thumshirn
2017-09-20 14:55   ` Christoph Hellwig
2017-09-20 14:55     ` Christoph Hellwig
2017-09-21  5:23     ` Johannes Thumshirn
2017-09-21  5:23       ` Johannes Thumshirn
2017-09-21 14:50       ` Christoph Hellwig
2017-09-21 14:50         ` Christoph Hellwig
2017-09-22  0:21         ` Tony Yang
2017-09-22  0:21           ` Tony Yang
2017-09-24 14:41           ` Christoph Hellwig
2017-09-24 14:41             ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170921211246.GB10713@localhost.localdomain \
    --to=keith.busch@intel.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.