* [PATCH] drivers/perf: arm_pmu_acpi: Release memory obtained by kasprintf
@ 2017-09-20 6:56 ` Arvind Yadav
0 siblings, 0 replies; 6+ messages in thread
From: Arvind Yadav @ 2017-09-20 6:56 UTC (permalink / raw)
To: linux-arm-kernel
Free memory region, if arm_pmu_acpi_probe is not successful.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/perf/arm_pmu_acpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c
index 0a9b787..3303dd8 100644
--- a/drivers/perf/arm_pmu_acpi.c
+++ b/drivers/perf/arm_pmu_acpi.c
@@ -235,6 +235,7 @@ int arm_pmu_acpi_probe(armpmu_init_fn init_fn)
ret = armpmu_register(pmu);
if (ret) {
pr_warn("Failed to register PMU for CPU%d\n", cpu);
+ kfree(pmu->name);
return ret;
}
}
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] drivers/perf: arm_pmu_acpi: Release memory obtained by kasprintf
@ 2017-09-20 6:56 ` Arvind Yadav
0 siblings, 0 replies; 6+ messages in thread
From: Arvind Yadav @ 2017-09-20 6:56 UTC (permalink / raw)
To: will.deacon, mark.rutland; +Cc: linux-arm-kernel, linux-kernel
Free memory region, if arm_pmu_acpi_probe is not successful.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/perf/arm_pmu_acpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c
index 0a9b787..3303dd8 100644
--- a/drivers/perf/arm_pmu_acpi.c
+++ b/drivers/perf/arm_pmu_acpi.c
@@ -235,6 +235,7 @@ int arm_pmu_acpi_probe(armpmu_init_fn init_fn)
ret = armpmu_register(pmu);
if (ret) {
pr_warn("Failed to register PMU for CPU%d\n", cpu);
+ kfree(pmu->name);
return ret;
}
}
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] drivers/perf: arm_pmu_acpi: Release memory obtained by kasprintf
2017-09-20 6:56 ` Arvind Yadav
@ 2017-09-22 10:54 ` Will Deacon
-1 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2017-09-22 10:54 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 20, 2017 at 12:26:38PM +0530, Arvind Yadav wrote:
> Free memory region, if arm_pmu_acpi_probe is not successful.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/perf/arm_pmu_acpi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c
> index 0a9b787..3303dd8 100644
> --- a/drivers/perf/arm_pmu_acpi.c
> +++ b/drivers/perf/arm_pmu_acpi.c
> @@ -235,6 +235,7 @@ int arm_pmu_acpi_probe(armpmu_init_fn init_fn)
> ret = armpmu_register(pmu);
> if (ret) {
> pr_warn("Failed to register PMU for CPU%d\n", cpu);
> + kfree(pmu->name);
> return ret;
> }
> }
It's a bit weird that we bail out of the loop on the first failing CPU, but
you've not changed that behaviour so your patch looks fine in isolation:
Acked-by: Will Deacon <will.deacon@arm.com>
Catalin: can you pick this up as a fix, please?
Will
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers/perf: arm_pmu_acpi: Release memory obtained by kasprintf
@ 2017-09-22 10:54 ` Will Deacon
0 siblings, 0 replies; 6+ messages in thread
From: Will Deacon @ 2017-09-22 10:54 UTC (permalink / raw)
To: Arvind Yadav, catalin.marinas
Cc: mark.rutland, linux-arm-kernel, linux-kernel
On Wed, Sep 20, 2017 at 12:26:38PM +0530, Arvind Yadav wrote:
> Free memory region, if arm_pmu_acpi_probe is not successful.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/perf/arm_pmu_acpi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c
> index 0a9b787..3303dd8 100644
> --- a/drivers/perf/arm_pmu_acpi.c
> +++ b/drivers/perf/arm_pmu_acpi.c
> @@ -235,6 +235,7 @@ int arm_pmu_acpi_probe(armpmu_init_fn init_fn)
> ret = armpmu_register(pmu);
> if (ret) {
> pr_warn("Failed to register PMU for CPU%d\n", cpu);
> + kfree(pmu->name);
> return ret;
> }
> }
It's a bit weird that we bail out of the loop on the first failing CPU, but
you've not changed that behaviour so your patch looks fine in isolation:
Acked-by: Will Deacon <will.deacon@arm.com>
Catalin: can you pick this up as a fix, please?
Will
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] drivers/perf: arm_pmu_acpi: Release memory obtained by kasprintf
2017-09-22 10:54 ` Will Deacon
@ 2017-09-22 14:12 ` Catalin Marinas
-1 siblings, 0 replies; 6+ messages in thread
From: Catalin Marinas @ 2017-09-22 14:12 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Sep 22, 2017 at 11:54:06AM +0100, Will Deacon wrote:
> On Wed, Sep 20, 2017 at 12:26:38PM +0530, Arvind Yadav wrote:
> > Free memory region, if arm_pmu_acpi_probe is not successful.
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > ---
> > drivers/perf/arm_pmu_acpi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c
> > index 0a9b787..3303dd8 100644
> > --- a/drivers/perf/arm_pmu_acpi.c
> > +++ b/drivers/perf/arm_pmu_acpi.c
> > @@ -235,6 +235,7 @@ int arm_pmu_acpi_probe(armpmu_init_fn init_fn)
> > ret = armpmu_register(pmu);
> > if (ret) {
> > pr_warn("Failed to register PMU for CPU%d\n", cpu);
> > + kfree(pmu->name);
> > return ret;
> > }
> > }
>
> It's a bit weird that we bail out of the loop on the first failing CPU, but
> you've not changed that behaviour so your patch looks fine in isolation:
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
> Catalin: can you pick this up as a fix, please?
Applied. Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drivers/perf: arm_pmu_acpi: Release memory obtained by kasprintf
@ 2017-09-22 14:12 ` Catalin Marinas
0 siblings, 0 replies; 6+ messages in thread
From: Catalin Marinas @ 2017-09-22 14:12 UTC (permalink / raw)
To: Will Deacon; +Cc: Arvind Yadav, mark.rutland, linux-kernel, linux-arm-kernel
On Fri, Sep 22, 2017 at 11:54:06AM +0100, Will Deacon wrote:
> On Wed, Sep 20, 2017 at 12:26:38PM +0530, Arvind Yadav wrote:
> > Free memory region, if arm_pmu_acpi_probe is not successful.
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > ---
> > drivers/perf/arm_pmu_acpi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c
> > index 0a9b787..3303dd8 100644
> > --- a/drivers/perf/arm_pmu_acpi.c
> > +++ b/drivers/perf/arm_pmu_acpi.c
> > @@ -235,6 +235,7 @@ int arm_pmu_acpi_probe(armpmu_init_fn init_fn)
> > ret = armpmu_register(pmu);
> > if (ret) {
> > pr_warn("Failed to register PMU for CPU%d\n", cpu);
> > + kfree(pmu->name);
> > return ret;
> > }
> > }
>
> It's a bit weird that we bail out of the loop on the first failing CPU, but
> you've not changed that behaviour so your patch looks fine in isolation:
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
> Catalin: can you pick this up as a fix, please?
Applied. Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-09-22 14:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-20 6:56 [PATCH] drivers/perf: arm_pmu_acpi: Release memory obtained by kasprintf Arvind Yadav
2017-09-20 6:56 ` Arvind Yadav
2017-09-22 10:54 ` Will Deacon
2017-09-22 10:54 ` Will Deacon
2017-09-22 14:12 ` Catalin Marinas
2017-09-22 14:12 ` Catalin Marinas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.