From: Darren Hart <dvhart@infradead.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org,
Jonathan Woithe <jwoithe@just42.net>,
Andy Shevchenko <andy@infradead.org>
Subject: Re: [PATCH] platform/x86: fujitsu-laptop: Don't oops when FUJ02E3 is not presnt
Date: Fri, 22 Sep 2017 17:00:48 -0700 [thread overview]
Message-ID: <20170923000048.GC20327@fury> (raw)
In-Reply-To: <20170918200059.16279-1-ville.syrjala@linux.intel.com>
On Mon, Sep 18, 2017 at 11:00:59PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> My Fujitsu-Siemens Lifebook S6120 doesn't have the FUJ02E3 device,
> but it does have FUJ02B1. That means we do register the backlight
> device (and it even seems to work), but the code will oops as soon
> as we try to set the backlight brightness because it's trying to
I'm curious by what you mean with "it even seems to work". Since it
crashes when adjusting, what does it do that "works" ?
> call call_fext_func() with a NULL device. Let's just skip those
> function calls when the FUJ02E3 device is not present.
>
Interesting. We call call_fext_func from many locations using the
"device" argument, or the driver static "fext".
This looks to me that we should be a bit more consistent here.
Finally, it seems a proper fix would be to either not register the
backlight device if !fext or to check for !fext inside call_fext_func.
Jonathan, your thoughts?
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-09-23 0:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 20:00 [PATCH] platform/x86: fujitsu-laptop: Don't oops when FUJ02E3 is not presnt Ville Syrjala
2017-09-19 4:06 ` Michał Kępień
2017-09-19 4:21 ` Jonathan Woithe
2017-09-19 4:42 ` Michał Kępień
2017-09-19 8:20 ` Jonathan Woithe
2017-09-19 13:25 ` Ville Syrjälä
2018-02-10 21:33 ` Michał Kępień
2017-09-23 0:00 ` Darren Hart [this message]
2017-09-23 2:03 ` Jonathan Woithe
2017-09-23 9:08 ` Jonathan Woithe
2017-09-25 12:14 ` Ville Syrjälä
2017-09-25 13:16 ` Jonathan Woithe
2017-09-26 4:49 ` Michał Kępień
2017-09-26 5:32 ` Jonathan Woithe
[not found] ` <20171018151058.GL10981@intel.com>
2017-10-20 17:29 ` Ville Syrjälä
2017-10-25 4:51 ` Michał Kępień
2017-10-25 10:05 ` Ville Syrjälä
2017-10-29 22:57 ` Jonathan Woithe
2018-02-11 21:33 ` Michał Kępień
2017-09-27 6:56 ` Darren Hart
2017-09-27 7:27 ` Jonathan Woithe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170923000048.GC20327@fury \
--to=dvhart@infradead.org \
--cc=andy@infradead.org \
--cc=jwoithe@just42.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.