From: Christos Gkekas <chris.gekas@gmail.com>
To: Petr Vandrovec <petr@vandrovec.name>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org
Cc: Christos Gkekas <chris.gekas@gmail.com>
Subject: [PATCH RESEND] ncpfs: ioctl: Delete unnecessary len variables
Date: Sun, 24 Sep 2017 18:43:59 +0100 [thread overview]
Message-ID: <20170924174359.GA4245@inspiron> (raw)
Variables oldnamelen, oldprivatelen and oldlen are set but are never
used, thus they need to be cleaned up.
Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
fs/ncpfs/ioctl.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/fs/ncpfs/ioctl.c b/fs/ncpfs/ioctl.c
index 12550c2..85c6c60 100644
--- a/fs/ncpfs/ioctl.c
+++ b/fs/ncpfs/ioctl.c
@@ -642,9 +642,7 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
struct ncp_objectname_ioctl user;
void* newname;
void* oldname;
- size_t oldnamelen;
void* oldprivate;
- size_t oldprivatelen;
#ifdef CONFIG_COMPAT
if (cmd == NCP_IOC_SETOBJECTNAME_32) {
@@ -671,9 +669,7 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
}
down_write(&server->auth_rwsem);
oldname = server->auth.object_name;
- oldnamelen = server->auth.object_name_len;
oldprivate = server->priv.data;
- oldprivatelen = server->priv.len;
server->auth.auth_type = user.auth_type;
server->auth.object_name_len = user.object_name_len;
server->auth.object_name = newname;
@@ -742,7 +738,6 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
struct ncp_privatedata_ioctl user;
void* new;
void* old;
- size_t oldlen;
#ifdef CONFIG_COMPAT
if (cmd == NCP_IOC_SETPRIVATEDATA_32) {
@@ -767,7 +762,6 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
}
down_write(&server->auth_rwsem);
old = server->priv.data;
- oldlen = server->priv.len;
server->priv.len = user.len;
server->priv.data = new;
up_write(&server->auth_rwsem);
--
2.7.4
reply other threads:[~2017-09-24 17:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170924174359.GA4245@inspiron \
--to=chris.gekas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=petr@vandrovec.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.