* [PATCH RESEND] ncpfs: ioctl: Delete unnecessary len variables
@ 2017-09-24 17:43 Christos Gkekas
0 siblings, 0 replies; only message in thread
From: Christos Gkekas @ 2017-09-24 17:43 UTC (permalink / raw)
To: Petr Vandrovec, Ingo Molnar, linux-kernel; +Cc: Christos Gkekas
Variables oldnamelen, oldprivatelen and oldlen are set but are never
used, thus they need to be cleaned up.
Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
fs/ncpfs/ioctl.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/fs/ncpfs/ioctl.c b/fs/ncpfs/ioctl.c
index 12550c2..85c6c60 100644
--- a/fs/ncpfs/ioctl.c
+++ b/fs/ncpfs/ioctl.c
@@ -642,9 +642,7 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
struct ncp_objectname_ioctl user;
void* newname;
void* oldname;
- size_t oldnamelen;
void* oldprivate;
- size_t oldprivatelen;
#ifdef CONFIG_COMPAT
if (cmd == NCP_IOC_SETOBJECTNAME_32) {
@@ -671,9 +669,7 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
}
down_write(&server->auth_rwsem);
oldname = server->auth.object_name;
- oldnamelen = server->auth.object_name_len;
oldprivate = server->priv.data;
- oldprivatelen = server->priv.len;
server->auth.auth_type = user.auth_type;
server->auth.object_name_len = user.object_name_len;
server->auth.object_name = newname;
@@ -742,7 +738,6 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
struct ncp_privatedata_ioctl user;
void* new;
void* old;
- size_t oldlen;
#ifdef CONFIG_COMPAT
if (cmd == NCP_IOC_SETPRIVATEDATA_32) {
@@ -767,7 +762,6 @@ static long __ncp_ioctl(struct inode *inode, unsigned int cmd, unsigned long arg
}
down_write(&server->auth_rwsem);
old = server->priv.data;
- oldlen = server->priv.len;
server->priv.len = user.len;
server->priv.data = new;
up_write(&server->auth_rwsem);
--
2.7.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-09-24 17:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-24 17:43 [PATCH RESEND] ncpfs: ioctl: Delete unnecessary len variables Christos Gkekas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.